From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759043AbcBYEO0 (ORCPT ); Wed, 24 Feb 2016 23:14:26 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:49410 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753051AbcBYEOY (ORCPT ); Wed, 24 Feb 2016 23:14:24 -0500 X-AuditID: cbfee690-f79646d000001316-65-56ce7f9de7e0 Subject: Re: [PATCH] arm64: dts: Add tmu node for exynos7 To: Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org References: <1456370865-10086-1-git-send-email-pankaj.dubey@samsung.com> <56CE7DAC.4000803@samsung.com> Cc: catalin.marinas@arm.com, will.deacon@arm.com, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, Alim Akhtar , Lukasz Majewski From: "pankaj.dubey" Message-id: <56CE7FF3.4030101@samsung.com> Date: Thu, 25 Feb 2016 09:45:47 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-version: 1.0 In-reply-to: <56CE7DAC.4000803@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrMIsWRmVeSWpSXmKPExsWyRsSkQ3du/bkwgwO3DCwezNvGZvF+WQ+j xfwj51gtXr8wtHjzcDOjxabH11gtLu+aw2Yx4/w+JouXH0+wOHB6rJm3htFj85J6j74tqxg9 Pm+SC2CJ4rJJSc3JLEst0rdL4Mq43rGbseCkVsXV5y1sDYydSl2MnBwSAiYS1zt/M0HYYhIX 7q1n62Lk4hASWMEo8fzha/YuRg6wotXvTCHisxglpvbsZYJwvjNKfHp7hBmkW1jAUuLaxylg tohApMSLPecYQWwhgUyJk3Pvs4A0MAs8YpR4ue4bWIJNQF9i+uNtbCAbeAW0JP5fcAMJswio Smz8O4sFJCwqECGxaEcmSJhXQFDix+R7LCA2p4C2xJ8nS8BKmAX0JO5f1AIJMwvIS2xe85YZ ZJOEwD12iQf9x5ggRgpIfJt8iAXiF1mJTQeYIf6VlDi44gbLBEaxWUg2zEKYOgvJ1AWMzKsY RVMLkguKk9KLTPSKE3OLS/PS9ZLzczcxAuPu9L9nE3Yw3jtgfYhRgINRiYc38vfZMCHWxLLi ytxDjKZAR0xklhJNzgdGd15JvKGxmZGFqYmpsZG5pZmSOO9rqZ/BQgLpiSWp2ampBalF8UWl OanFhxiZODilGhitNSPfOse8iMnPEXXTrw8MaZOOF17lL2Z4S+T/lDWzzlUFv3jd91GwW+ZV 6cNzn9dsF550ou1TzkeJWdMcrssqLbqw3TxZ5sw8q9AbjusUFFnnMfHXKRwPf3EnuGljjMjP Y921T3NeMSjtnN9/PUjoYb/7NkaFY8dNtm5sPGhtbVm8S8js3XYlluKMREMt5qLiRADmqRO4 tgIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrAIsWRmVeSWpSXmKPExsVy+t9jQd259efCDF6f0LZ4MG8bm8X7ZT2M FvOPnGO1eP3C0OLNw82MFpseX2O1uLxrDpvFjPP7mCxefjzB4sDpsWbeGkaPzUvqPfq2rGL0 +LxJLoAlqoHRJiM1MSW1SCE1Lzk/JTMv3VbJOzjeOd7UzMBQ19DSwlxJIS8xN9VWycUnQNct MwfoFCWFssScUqBQQGJxsZK+HaYJoSFuuhYwjRG6viFBcD1GBmggYR1jxvWO3YwFJ7Uqrj5v YWtg7FTqYuTgkBAwkVj9zrSLkRPIFJO4cG89WxcjF4eQwCxGiak9e5kgnO+MEp/eHmEGqRIW sJS49nEKmC0iECnxYs85RhBbSCBT4uTc+ywgDcwCjxglXq77BpZgE9CXmP54GxvINl4BLYn/ F9xAwiwCqhIb/85iAQmLCkRILNqRCRLmFRCU+DH5HguIzSmgLfHnyRKwEmYBPYn7F7VAwswC 8hKb17xlnsAIdCRCxyyEqllIqhYwMq9ilEgtSC4oTkrPNcpLLdcrTswtLs1L10vOz93ECI7t Z9I7GA/vcj/EKMDBqMTDy/DzbJgQa2JZcWXuIUYJDmYlEV6PunNhQrwpiZVVqUX58UWlOanF hxhNgb6YyCwlmpwPTDt5JfGGxiZmRpZGZhZGJubmSuK8j/+vCxMSSE8sSc1OTS1ILYLpY+Lg lGpgXKZyJmhDxI/jxdkzGlS+Ts2VO9mw7tFf88Y7GqKx0g6pvXLnNZ5O/r3oR5PM3AJvXjPl h6rWs5xd1GbU14ZJGR22m8N/qXfdSvP2HXKnL/6JlJzLpPna01PQ4dqfE22nDFcs/xrZpJ/s oyV5iIW3oe3clucV2UEX1yoJa2pst3Rjy5qScSBPiaU4I9FQi7moOBEAPt5QbQMDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof, On Thursday 25 February 2016 09:36 AM, Krzysztof Kozlowski wrote: > On 25.02.2016 12:27, Pankaj Dubey wrote: >> From: Alim Akhtar >> >> This patch adds tmu node, related temprature sensor and triping >> point data for Atlas cpu core found on exynos7 SoC. >> >> Signed-off-by: Alim Akhtar > > Yours Sob is missing. > > Cc-ed Lukasz Majewski. > Due to some technical difficulty Alim posted via my account. He will re-spin this patch via his account soon. Thanks, Pankaj Dubey > Lukasz, > Your review or ack would be appreciated. > > >> --- >> .../boot/dts/exynos/exynos7-tmu-sensor-conf.dtsi | 25 +++++++++ >> .../arm64/boot/dts/exynos/exynos7-trip-points.dtsi | 55 ++++++++++++++++++++ >> arch/arm64/boot/dts/exynos/exynos7.dtsi | 20 +++++++ >> 3 files changed, 100 insertions(+) >> create mode 100644 arch/arm64/boot/dts/exynos/exynos7-tmu-sensor-conf.dtsi >> create mode 100644 arch/arm64/boot/dts/exynos/exynos7-trip-points.dtsi >> >> diff --git a/arch/arm64/boot/dts/exynos/exynos7-tmu-sensor-conf.dtsi b/arch/arm64/boot/dts/exynos/exynos7-tmu-sensor-conf.dtsi >> new file mode 100644 >> index 0000000..1d6dcf2 >> --- /dev/null >> +++ b/arch/arm64/boot/dts/exynos/exynos7-tmu-sensor-conf.dtsi >> @@ -0,0 +1,25 @@ >> +/* >> + * Device tree sources for Exynos7 TMU sensor configuration >> + * >> + * Copyright (c) 2016 Samsung Electronics Co., Ltd. >> + * http://www.samsung.com >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License version 2 as >> + * published by the Free Software Foundation. >> + * >> + */ >> + >> +#include >> + >> +#thermal-sensor-cells = <0>; >> +samsung,tmu_gain = <9>; >> +samsung,tmu_reference_voltage = <17>; >> +samsung,tmu_noise_cancel_mode = <4>; >> +samsung,tmu_efuse_value = <75>; >> +samsung,tmu_min_efuse_value = <15>; >> +samsung,tmu_max_efuse_value = <100>; >> +samsung,tmu_first_point_trim = <25>; >> +samsung,tmu_second_point_trim = <85>; >> +samsung,tmu_default_temp_offset = <50>; >> +samsung,tmu_cal_type = ; >> diff --git a/arch/arm64/boot/dts/exynos/exynos7-trip-points.dtsi b/arch/arm64/boot/dts/exynos/exynos7-trip-points.dtsi >> new file mode 100644 >> index 0000000..3970545 >> --- /dev/null >> +++ b/arch/arm64/boot/dts/exynos/exynos7-trip-points.dtsi >> @@ -0,0 +1,55 @@ >> +/* >> + * Device tree sources for default Exynos7 thermal zone definition >> + * >> + * Copyright (c) 2016 Samsung Electronics Co., Ltd. >> + * http://www.samsung.com >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License version 2 as >> + * published by the Free Software Foundation. >> + * >> + */ >> + >> +trips { >> + cpu-alert-0 { >> + temperature = <75000>; /* millicelsius */ >> + hysteresis = <10000>; /* millicelsius */ >> + type = "passive"; >> + }; >> + cpu-alert-1 { >> + temperature = <80000>; /* millicelsius */ >> + hysteresis = <10000>; /* millicelsius */ >> + type = "passive"; >> + }; >> + cpu-alert-2 { >> + temperature = <85000>; /* millicelsius */ >> + hysteresis = <10000>; /* millicelsius */ >> + type = "passive"; >> + }; >> + cpu-alert-3 { >> + temperature = <90000>; /* millicelsius */ >> + hysteresis = <10000>; /* millicelsius */ >> + type = "passive"; >> + }; >> + cpu-alert-4 { >> + temperature = <95000>; /* millicelsius */ >> + hysteresis = <10000>; /* millicelsius */ >> + type = "passive"; >> + }; >> + cpu-alert-5 { >> + temperature = <100000>; /* millicelsius */ >> + hysteresis = <10000>; /* millicelsius */ >> + type = "passive"; >> + }; >> + cpu-alert-6 { >> + temperature = <110000>; /* millicelsius */ >> + hysteresis = <10000>; /* millicelsius */ >> + type = "passive"; >> + }; >> + /* HW Trip point */ > > The comment looks unnecessary, all of these are HW trip points, right? > >> + cpu-crit-0 { >> + temperature = <115000>; /* millicelsius */ >> + hysteresis = <0>; /* millicelsius */ >> + type = "critical"; >> + }; >> +}; >> diff --git a/arch/arm64/boot/dts/exynos/exynos7.dtsi b/arch/arm64/boot/dts/exynos/exynos7.dtsi >> index c662f98..fc9d130 100644 >> --- a/arch/arm64/boot/dts/exynos/exynos7.dtsi >> +++ b/arch/arm64/boot/dts/exynos/exynos7.dtsi >> @@ -27,6 +27,7 @@ >> pinctrl6 = &pinctrl_fsys0; >> pinctrl7 = &pinctrl_fsys1; >> pinctrl8 = &pinctrl_bus1; >> + tmuctrl0 = &tmuctrl_0; > > Why the alias is needed? > >> }; >> >> cpus { >> @@ -538,6 +539,25 @@ >> clocks = <&clock_peric0 PCLK_PWM>; >> clock-names = "timers"; >> }; >> + >> + tmuctrl_0: tmu@10060000 { >> + compatible = "samsung,exynos7-tmu"; >> + reg = <0x10060000 0x200>; >> + interrupts = <0 108 0>; >> + clocks = <&clock_peris PCLK_TMU>, >> + <&clock_peris SCLK_TMU>; >> + clock-names = "tmu_apbif", "tmu_sclk"; >> + #include "exynos7-tmu-sensor-conf.dtsi" >> + }; >> + >> + thermal-zones { >> + atlas_thermal: atlas-thermal { > > The atlas is a Exynos7 specific codename. The name of node should be a > general class of the device, so maybe: > atlas_thermal: cluster0-thermal > ? > > Best regards, > Krzysztof >