From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758818AbcBYESB (ORCPT ); Wed, 24 Feb 2016 23:18:01 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:34519 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755555AbcBYER7 (ORCPT ); Wed, 24 Feb 2016 23:17:59 -0500 X-AuditID: cbfee691-f79766d0000012b6-19-56ce806c2b21 Subject: Re: [GIT PULL 3/7] drivers: soc: EXYNOS drivers for v4.6 To: Krzysztof Kozlowski , Olof Johansson References: <1455496446-23779-1-git-send-email-k.kozlowski@samsung.com> <1455496446-23779-4-git-send-email-k.kozlowski@samsung.com> <20160224222254.GT10126@localhost> <56CE4E14.2050701@samsung.com> Cc: Arnd Bergmann , Kevin Hilman , arm@kernel.org, Kukjin Kim , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Pavel Fedin , Bartlomiej Zolnierkiewicz , Javier Martinez Canillas From: "pankaj.dubey" Message-id: <56CE80C1.8040801@samsung.com> Date: Thu, 25 Feb 2016 09:49:13 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-version: 1.0 In-reply-to: <56CE4E14.2050701@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrCIsWRmVeSWpSXmKPExsWyRsSkVTen4VyYwct7+hbHvmxhs/g76Ri7 xcYZ61kt3rxdw2Tx+oWhRf/j18wWTzc/ZrLY9Pgaq8XlXXPYLGac38dkcer6ZzaLV5dWsTnw ePz+NYnRY9OqTjaPzUvqPa6caGL12NJ/l92jb8sqRo/Pm+QC2KO4bFJSczLLUov07RK4MnY0 HmQp2ChSsWj7VPYGxp0CXYycHBICJhKXnncwQthiEhfurWfrYuTiEBJYwSjR0feYCabo8Y/D TBCJWYwSM1ctgHK+M0qs3nuCFaRKWMBRYsHC3WwgtohAiMS5ScdYIYpOMkrsbtrADOIwC3xg kvjS0cYMUsUmoC8x/fE2sA5eAS2JJ92rwQ5hEVCV2Pl7HdAKDg5RgQiJRTsyIUoEJX5MvscC YnMKaEus2rSAGaSEWUBP4v5FLZAws4C8xOY1b8FWSQh0ckh8f3QRaqSAxLfJh1hA6iUEZCU2 HWCG+ExS4uCKGywTGMVmIdkwC2HqLCRTFzAyr2IUTS1ILihOSi8y1StOzC0uzUvXS87P3cQI jNzT/55N3MF4/4D1IUYBDkYlHl6Gn2fDhFgTy4orcw8xmgIdMZFZSjQ5H5ge8kriDY3NjCxM TUyNjcwtzZTEeXWkfwYLCaQnlqRmp6YWpBbFF5XmpBYfYmTi4JRqYEz78mCSresX8bhPp5/4 L56QGG8RtpbX53tT99Lk3ckZrYe4FOv8Yie+vlthbamqHZousnb7kiCZTbMnpHKfEBO/Hrgn m3vGGvfFR35dujiLM95cZYfRvM6UysM9L5pMzhb9nyveWPaCe9tXoz826mItfLuDo66uZQue c7b4lJ2LYpbkmbQl8kosxRmJhlrMRcWJAJ3f9tzXAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprIKsWRmVeSWpSXmKPExsVy+t9jQd2chnNhBl/va1oc+7KFzeLvpGPs FhtnrGe1ePN2DZPF6xeGFv2PXzNbPN38mMli0+NrrBaXd81hs5hxfh+Txanrn9ksXl1axebA 4/H71yRGj02rOtk8Ni+p97hyoonVY0v/XXaPvi2rGD0+b5ILYI9qYLTJSE1MSS1SSM1Lzk/J zEu3VfIOjneONzUzMNQ1tLQwV1LIS8xNtVVy8QnQdcvMATpUSaEsMacUKBSQWFyspG+HaUJo iJuuBUxjhK5vSBBcj5EBGkhYx5ixo/EgS8FGkYpF26eyNzDuFOhi5OSQEDCRePzjMBOELSZx 4d56ti5GLg4hgVmMEjNXLWCCcL4zSqzee4IVpEpYwFFiwcLdbCC2iECIxLlJx1ghik4ySuxu 2sAM4jALfGCS+NLRxgxSxSagLzH98TawDl4BLYkn3asZQWwWAVWJnb/XAa3g4BAViJBYtCMT okRQ4sfkeywgNqeAtsSqTQuYQUqYBfQk7l/UAgkzC8hLbF7zlnkCI9CZCB2zEKpmIalawMi8 ilEitSC5oDgpPdcoL7Vcrzgxt7g0L10vOT93EyM4OTyT3sF4eJf7IUYBDkYlHl6Gn2fDhFgT y4orcw8xSnAwK4nwetSdCxPiTUmsrEotyo8vKs1JLT7EaAr0xURmKdHkfGDiyiuJNzQ2MTOy NDKzMDIxN1cS5338f12YkEB6YklqdmpqQWoRTB8TB6dUA2OJkb0Pu+mJtc11C14+M68vSd+r rWwZGJPMMK/h0IR12/UVm3uNHnZdaV5wxl/lzEL7fZoV0ZeSvOdzMuf8vOo+odTpsYpsxE/u vVcnuPnn/mKau61otqq6ffTMJ2Xyd7Ul93B+j2ryEEvYXMMu8E/FKGD+8zPTxMqWzLCtVrC5 02QgGbBaX4mlOCPRUIu5qDgRAE3a6GIkAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof, On Thursday 25 February 2016 06:13 AM, Krzysztof Kozlowski wrote: > On 25.02.2016 07:22, Olof Johansson wrote: >> On Mon, Feb 15, 2016 at 09:34:02AM +0900, Krzysztof Kozlowski wrote: >>> Hi Arnd, Kevin and Olof, >>> >>> This finally moves SROM controller and PMU code to separate >>> driver under drivers/soc/samsung. >>> >>> Kind regards, >>> Krzysztof >>> >>> >>> The following changes since commit 92e963f50fc74041b5e9e744c330dca48e04f08d: >>> >>> Linux 4.5-rc1 (2016-01-24 13:06:47 -0800) >>> >>> are available in the git repository at: >>> >>> git://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git tags/samsung-drivers-soc-srom-pmu-4.6 >>> >>> for you to fetch changes up to 74a6659e8bf193066ba6bf365de66baa897aebb1: >>> >>> drivers: soc: Add support for Exynos PMU driver (2016-01-25 10:46:59 +0900) >>> >>> ---------------------------------------------------------------- >>> A set of changes adding new drivers under drivers/soc/samsung: >>> >>> 1. Split code for handling SROM registers out of arm/mach-exynos >>> in to separate SROM controller driver under drivers/soc/samsung. >>> The driver will save and restore SROM registers during Suspend >>> to RAM. >>> >>> 2. Add to this SROM controller driver support for bank configuration >>> used by child devices. This allows usage of SMSC9115 Ethernet chip >>> on SMDK5410 (Exynos5410) directly connected to SROM controller. >> >> Hi, >> >> OMAP has GPMC drivers under drivers/memory. I wonder if SROM should go there >> too, since it's a quite similar bus. > > I wish I get this feedback before, when we were discussing the SROM > patches. :/ > > Indeed this sounds reasonable. On some boards the omap-gpmc is used for > the same purpose: interfacing to smsc,lan9115 (like on SMDK5410). > > >> Feel free to respin this without SROM now, so we can get the other pieces in >> sooner and then revisit the SROM asyncronously. That'll remove the dependencies >> on DT as well. > > Okay, I'll rebase all drivers/soc branches and respin the pull request > so PMU driver and other stuff could go in. > > BTW, just in case, although PMU stands for "Power Management Unit" I > don't think it should be placed under drivers/power because it is not a > avs/charger/battery/reset driver. Existing power-related drivers are > under driver/soc (bcm, dove, tegra). > > Re-work of SROM drivers could be started on top of it. > Please let me know if I need to take care of any of this work. Thanks, Pankaj Dubey > Best regards, > Krzysztof >