From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760125AbcBYJkJ (ORCPT ); Thu, 25 Feb 2016 04:40:09 -0500 Received: from bear.ext.ti.com ([192.94.94.41]:35447 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759547AbcBYJkH (ORCPT ); Thu, 25 Feb 2016 04:40:07 -0500 Subject: Re: [PATCH 3/5] ARM: davinci: dm365: Add dma_slave_map to edma To: Sekhar Nori References: <1454416997-14230-1-git-send-email-peter.ujfalusi@ti.com> <1454416997-14230-4-git-send-email-peter.ujfalusi@ti.com> <56CADBB1.9040908@ti.com> CC: , , , From: Peter Ujfalusi Message-ID: <56CECBD7.1020101@ti.com> Date: Thu, 25 Feb 2016 11:39:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <56CADBB1.9040908@ti.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/22/2016 11:58 AM, Sekhar Nori wrote: > On Tuesday 02 February 2016 06:13 PM, Peter Ujfalusi wrote: >> Provide the dma_slave_map to edma which will allow us to move the drivers >> to the new, simpler dmaengine API and we can remove the DMA resources also >> for the devices. >> >> Signed-off-by: Peter Ujfalusi > >> FIX: dm365 > > dropped this "note to self" :) Oh, yes, thanks. I needed to fix up things while addressing the core support comments and the struct changed on the way several times. Sorry about it. > >> --- >> arch/arm/mach-davinci/dm365.c | 22 ++++++++++++++++++++++ >> 1 file changed, 22 insertions(+) >> >> diff --git a/arch/arm/mach-davinci/dm365.c b/arch/arm/mach-davinci/dm365.c >> index 01843fbcc9ea..d26dc2b4339a 100644 >> --- a/arch/arm/mach-davinci/dm365.c >> +++ b/arch/arm/mach-davinci/dm365.c >> @@ -17,6 +17,7 @@ >> #include >> #include >> #include >> +#include >> #include >> #include >> #include >> @@ -862,9 +863,30 @@ static s8 dm365_queue_priority_mapping[][2] = { >> {-1, -1}, >> }; >> >> +static const struct dma_slave_map da365_edma_map[] = { > > This should be "dm365_edma_map". > > Fixed both locally while applying. > > Regards, > Sekhar > -- Péter