From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760877AbcBYO0b (ORCPT ); Thu, 25 Feb 2016 09:26:31 -0500 Received: from mail113-248.mail.alibaba.com ([205.204.113.248]:41102 "EHLO us-alimail-mta1.hst.scl.en.alidc.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1760837AbcBYO02 (ORCPT ); Thu, 25 Feb 2016 09:26:28 -0500 X-Alimail-AntiSpam: AC=CONTINUE;BC=0.107872|-1;FP=0|0|0|0|0|-1|-1|-1;HT=e01l10434;MF=chengang@emindsoft.com.cn;NM=1;PH=DS;RN=12;RT=11;SR=0;TI=SMTPD_----4YKQ-Qw_1456409995; Message-ID: <56CF0E6A.2090204@emindsoft.com.cn> Date: Thu, 25 Feb 2016 22:23:38 +0800 From: Chen Gang User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Michal Hocko CC: trivial@kernel.org, akpm@linux-foundation.org, vbabka@suse.cz, rientjes@google.com, linux-kernel@vger.kernel.org, hannes@cmpxchg.org, mgorman@techsingularity.net, vdavydov@virtuozzo.com, dan.j.williams@intel.com, linux-mm@kvack.org Subject: Re: [PATCH trivial] include/linux/gfp.h: Improve the coding styles References: <1456352791-2363-1-git-send-email-chengang@emindsoft.com.cn> <20160225085719.GA17573@dhcp22.suse.cz> In-Reply-To: <20160225085719.GA17573@dhcp22.suse.cz> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/25/16 16:57, Michal Hocko wrote: > On Thu 25-02-16 06:26:31, chengang@emindsoft.com.cn wrote: >> >> Always notice about 80 columns, and the white space near '|'. >> >> Let the wrapped function parameters align as the same styles. >> >> Remove redundant statement "enum zone_type z;" in function gfp_zone. > > I do not think this is an improvement. The comment placement is just odd > and artificially splitting the mask into more lines makes git grep > harder to use. > Excuse me, I am not quite sure your meaning is the whole contents of the patch is worthless, or only for the "comment placement"? For the "comment placement" the common way is below, but still make git grep harder: -#define __GFP_MOVABLE ((__force gfp_t)___GFP_MOVABLE) /* ZONE_MOVABLE allowed */ +/* ZONE_MOVABLE allowed */ +#define __GFP_MOVABLE ((__force gfp_t)___GFP_MOVABLE) Then how about: -#define __GFP_MOVABLE ((__force gfp_t)___GFP_MOVABLE) /* ZONE_MOVABLE allowed */ +#define __GFP_MOVABLE \ ((__force gfp_t)___GFP_MOVABLE) /* ZONE_MOVABLE allowed */ or: -#define __GFP_MOVABLE ((__force gfp_t)___GFP_MOVABLE) /* ZONE_MOVABLE allowed */ +#define __GFP_MOVABLE /* ZONE_MOVABLE allowed */ \ ((__force gfp_t)___GFP_MOVABLE) Thanks. -- Chen Gang (陈刚) Managing Natural Environments is the Duty of Human Beings.