From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760690AbcBYOgN (ORCPT ); Thu, 25 Feb 2016 09:36:13 -0500 Received: from mail113-251.mail.alibaba.com ([205.204.113.251]:56108 "EHLO us-alimail-mta2.hst.scl.en.alidc.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1760148AbcBYOgL (ORCPT ); Thu, 25 Feb 2016 09:36:11 -0500 X-Alimail-AntiSpam: AC=CONTINUE;BC=0.08164571|-1;FP=0|0|0|0|0|-1|-1|-1;HT=e01l07397;MF=chengang@emindsoft.com.cn;NM=1;PH=DS;RN=12;RT=12;SR=0;TI=SMTPD_----4YKToIf_1456410915; Message-ID: <56CF1202.2020809@emindsoft.com.cn> Date: Thu, 25 Feb 2016 22:38:58 +0800 From: Chen Gang User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Mel Gorman CC: trivial@kernel.org, akpm@linux-foundation.org, vbabka@suse.cz, rientjes@google.com, linux-kernel@vger.kernel.org, mhocko@suse.cz, hannes@cmpxchg.org, vdavydov@virtuozzo.com, dan.j.williams@intel.com, linux-mm@kvack.org, Chen Gang Subject: Re: [PATCH trivial] include/linux/gfp.h: Improve the coding styles References: <1456352791-2363-1-git-send-email-chengang@emindsoft.com.cn> <20160225092752.GU2854@techsingularity.net> In-Reply-To: <20160225092752.GU2854@techsingularity.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/25/16 17:27, Mel Gorman wrote: > On Thu, Feb 25, 2016 at 06:26:31AM +0800, chengang@emindsoft.com.cn wrote: >> From: Chen Gang >> >> Always notice about 80 columns, and the white space near '|'. >> >> Let the wrapped function parameters align as the same styles. >> >> Remove redundant statement "enum zone_type z;" in function gfp_zone. >> >> Signed-off-by: Chen Gang > > NAK from me at least. From my perspective, it's preferrable to preserve > blame than go through a layer of cleanup when looking for the commit > that defined particular flags. It's ok to cleanup code at the same time > definitions change for functional or performance reasons. > I can understand for your NAK, it is a trivial patch. For me, I guess trivial@kernel.org will care about this kind of patch. If we have another better way than sending trivial patch, that will be OK to me. At present, I am learning mm in my free time, when I feel something is valuable more or less, I will send related patch for it. And excuse me, I guess my english is not quite well, I am not quite understand the meaning below, could you provide more details? "it's preferable to preserve blame than go through a layer of cleanup when looking for the commit that defined particular flags". Thanks. -- Chen Gang (陈刚) Managing Natural Environments is the Duty of Human Beings.