From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933586AbcBYTG7 (ORCPT ); Thu, 25 Feb 2016 14:06:59 -0500 Received: from mail-pf0-f196.google.com ([209.85.192.196]:34850 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933351AbcBYTG5 (ORCPT ); Thu, 25 Feb 2016 14:06:57 -0500 Subject: Re: [PATCH 3/3] perf script: Remove duplicated code and needless a script_spec__findnew() To: Jiri Olsa References: <1456413190-12378-1-git-send-email-treeze.taeung@gmail.com> <20160225190222.GB4883@krava.redhat.com> Cc: Arnaldo Carvalho de Melo , linux-kernel@vger.kernel.org, Jiri Olsa , Namhyung Kim , Ingo Molnar From: Taeung Song Message-ID: <56CF50CD.4060306@gmail.com> Date: Fri, 26 Feb 2016 04:06:53 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160225190222.GB4883@krava.redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Jiri On 02/26/2016 04:02 AM, Jiri Olsa wrote: > On Fri, Feb 26, 2016 at 12:13:10AM +0900, Taeung Song wrote: >> script_spec_register() called two functions >> script_spec__find() and script_spec__findnew(). >> But script_spec__find() was called two times. >> >> So remove script_spec__findnew() and make >> script_spec_register() only call once script_spec__find(). >> >> Cc: Jiri Olsa >> Signed-off-by: Taeung Song > > Acked-by: Jiri Olsa > Thank you!! - Taeung