* [PATCH 3/3] perf script: Remove duplicated code and needless a script_spec__findnew()
@ 2016-02-25 15:13 Taeung Song
2016-02-25 19:02 ` Jiri Olsa
2016-02-27 9:41 ` [tip:perf/core] perf script: Remove duplicated code and needless script_spec__findnew() tip-bot for Taeung Song
0 siblings, 2 replies; 6+ messages in thread
From: Taeung Song @ 2016-02-25 15:13 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Jiri Olsa, Namhyung Kim, Ingo Molnar, Taeung Song
script_spec_register() called two functions
script_spec__find() and script_spec__findnew().
But script_spec__find() was called two times.
So remove script_spec__findnew() and make
script_spec_register() only call once script_spec__find().
Cc: Jiri Olsa <jolsa@kernel.org>
Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
---
tools/perf/builtin-script.c | 21 +++------------------
1 file changed, 3 insertions(+), 18 deletions(-)
diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
index ec4fbd4..57f9a7e 100644
--- a/tools/perf/builtin-script.c
+++ b/tools/perf/builtin-script.c
@@ -1212,23 +1212,6 @@ static struct script_spec *script_spec__find(const char *spec)
return NULL;
}
-static struct script_spec *script_spec__findnew(const char *spec,
- struct scripting_ops *ops)
-{
- struct script_spec *s = script_spec__find(spec);
-
- if (s)
- return s;
-
- s = script_spec__new(spec, ops);
- if (!s)
- return NULL;
-
- script_spec__add(s);
-
- return s;
-}
-
int script_spec_register(const char *spec, struct scripting_ops *ops)
{
struct script_spec *s;
@@ -1237,9 +1220,11 @@ int script_spec_register(const char *spec, struct scripting_ops *ops)
if (s)
return -1;
- s = script_spec__findnew(spec, ops);
+ s = script_spec__new(spec, ops);
if (!s)
return -1;
+ else
+ script_spec__add(s);
return 0;
}
--
2.5.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 3/3] perf script: Remove duplicated code and needless a script_spec__findnew()
2016-02-25 15:13 [PATCH 3/3] perf script: Remove duplicated code and needless a script_spec__findnew() Taeung Song
@ 2016-02-25 19:02 ` Jiri Olsa
2016-02-25 19:06 ` Taeung Song
2016-02-25 19:16 ` Arnaldo Carvalho de Melo
2016-02-27 9:41 ` [tip:perf/core] perf script: Remove duplicated code and needless script_spec__findnew() tip-bot for Taeung Song
1 sibling, 2 replies; 6+ messages in thread
From: Jiri Olsa @ 2016-02-25 19:02 UTC (permalink / raw)
To: Taeung Song
Cc: Arnaldo Carvalho de Melo, linux-kernel, Jiri Olsa, Namhyung Kim,
Ingo Molnar
On Fri, Feb 26, 2016 at 12:13:10AM +0900, Taeung Song wrote:
> script_spec_register() called two functions
> script_spec__find() and script_spec__findnew().
> But script_spec__find() was called two times.
>
> So remove script_spec__findnew() and make
> script_spec_register() only call once script_spec__find().
>
> Cc: Jiri Olsa <jolsa@kernel.org>
> Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
thanks,
jirka
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 3/3] perf script: Remove duplicated code and needless a script_spec__findnew()
2016-02-25 19:02 ` Jiri Olsa
@ 2016-02-25 19:06 ` Taeung Song
2016-02-25 19:16 ` Arnaldo Carvalho de Melo
1 sibling, 0 replies; 6+ messages in thread
From: Taeung Song @ 2016-02-25 19:06 UTC (permalink / raw)
To: Jiri Olsa
Cc: Arnaldo Carvalho de Melo, linux-kernel, Jiri Olsa, Namhyung Kim,
Ingo Molnar
Hi, Jiri
On 02/26/2016 04:02 AM, Jiri Olsa wrote:
> On Fri, Feb 26, 2016 at 12:13:10AM +0900, Taeung Song wrote:
>> script_spec_register() called two functions
>> script_spec__find() and script_spec__findnew().
>> But script_spec__find() was called two times.
>>
>> So remove script_spec__findnew() and make
>> script_spec_register() only call once script_spec__find().
>>
>> Cc: Jiri Olsa <jolsa@kernel.org>
>> Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
>
> Acked-by: Jiri Olsa <jolsa@kernel.org>
>
Thank you!!
- Taeung
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 3/3] perf script: Remove duplicated code and needless a script_spec__findnew()
2016-02-25 19:02 ` Jiri Olsa
2016-02-25 19:06 ` Taeung Song
@ 2016-02-25 19:16 ` Arnaldo Carvalho de Melo
2016-02-25 19:17 ` Taeung Song
1 sibling, 1 reply; 6+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-02-25 19:16 UTC (permalink / raw)
To: Jiri Olsa; +Cc: Taeung Song, linux-kernel, Jiri Olsa, Namhyung Kim, Ingo Molnar
Em Thu, Feb 25, 2016 at 08:02:22PM +0100, Jiri Olsa escreveu:
> On Fri, Feb 26, 2016 at 12:13:10AM +0900, Taeung Song wrote:
> > script_spec_register() called two functions
> > script_spec__find() and script_spec__findnew().
> > But script_spec__find() was called two times.
> >
> > So remove script_spec__findnew() and make
> > script_spec_register() only call once script_spec__find().
> >
> > Cc: Jiri Olsa <jolsa@kernel.org>
> > Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
>
> Acked-by: Jiri Olsa <jolsa@kernel.org>
Looks good, applied.
Thanks,
- Arnaldo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 3/3] perf script: Remove duplicated code and needless a script_spec__findnew()
2016-02-25 19:16 ` Arnaldo Carvalho de Melo
@ 2016-02-25 19:17 ` Taeung Song
0 siblings, 0 replies; 6+ messages in thread
From: Taeung Song @ 2016-02-25 19:17 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo, Jiri Olsa
Cc: linux-kernel, Jiri Olsa, Namhyung Kim, Ingo Molnar
On 02/26/2016 04:16 AM, Arnaldo Carvalho de Melo wrote:
> Em Thu, Feb 25, 2016 at 08:02:22PM +0100, Jiri Olsa escreveu:
>> On Fri, Feb 26, 2016 at 12:13:10AM +0900, Taeung Song wrote:
>>> script_spec_register() called two functions
>>> script_spec__find() and script_spec__findnew().
>>> But script_spec__find() was called two times.
>>>
>>> So remove script_spec__findnew() and make
>>> script_spec_register() only call once script_spec__find().
>>>
>>> Cc: Jiri Olsa <jolsa@kernel.org>
>>> Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
>>
>> Acked-by: Jiri Olsa <jolsa@kernel.org>
>
> Looks good, applied.
>
> Thanks,
>
> - Arnaldo
Thank you!!
Taeung
^ permalink raw reply [flat|nested] 6+ messages in thread
* [tip:perf/core] perf script: Remove duplicated code and needless script_spec__findnew()
2016-02-25 15:13 [PATCH 3/3] perf script: Remove duplicated code and needless a script_spec__findnew() Taeung Song
2016-02-25 19:02 ` Jiri Olsa
@ 2016-02-27 9:41 ` tip-bot for Taeung Song
1 sibling, 0 replies; 6+ messages in thread
From: tip-bot for Taeung Song @ 2016-02-27 9:41 UTC (permalink / raw)
To: linux-tip-commits
Cc: acme, jolsa, mingo, linux-kernel, hpa, tglx, treeze.taeung,
namhyung
Commit-ID: 8560bae02a948876b26d1d86423cf5e0bb04a815
Gitweb: http://git.kernel.org/tip/8560bae02a948876b26d1d86423cf5e0bb04a815
Author: Taeung Song <treeze.taeung@gmail.com>
AuthorDate: Fri, 26 Feb 2016 00:13:10 +0900
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Thu, 25 Feb 2016 16:14:33 -0300
perf script: Remove duplicated code and needless script_spec__findnew()
script_spec_register() called two functions: script_spec__find() and
script_spec__findnew(). But this way script_spec__find() gets called
two times, directly and via script_spec__findnew().
So remove script_spec__findnew() and make script_spec_register() only
call once script_spec__find().
Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: http://lkml.kernel.org/r/1456413190-12378-1-git-send-email-treeze.taeung@gmail.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-script.c | 21 +++------------------
1 file changed, 3 insertions(+), 18 deletions(-)
diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
index ec4fbd4..57f9a7e 100644
--- a/tools/perf/builtin-script.c
+++ b/tools/perf/builtin-script.c
@@ -1212,23 +1212,6 @@ static struct script_spec *script_spec__find(const char *spec)
return NULL;
}
-static struct script_spec *script_spec__findnew(const char *spec,
- struct scripting_ops *ops)
-{
- struct script_spec *s = script_spec__find(spec);
-
- if (s)
- return s;
-
- s = script_spec__new(spec, ops);
- if (!s)
- return NULL;
-
- script_spec__add(s);
-
- return s;
-}
-
int script_spec_register(const char *spec, struct scripting_ops *ops)
{
struct script_spec *s;
@@ -1237,9 +1220,11 @@ int script_spec_register(const char *spec, struct scripting_ops *ops)
if (s)
return -1;
- s = script_spec__findnew(spec, ops);
+ s = script_spec__new(spec, ops);
if (!s)
return -1;
+ else
+ script_spec__add(s);
return 0;
}
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-02-27 9:41 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-25 15:13 [PATCH 3/3] perf script: Remove duplicated code and needless a script_spec__findnew() Taeung Song
2016-02-25 19:02 ` Jiri Olsa
2016-02-25 19:06 ` Taeung Song
2016-02-25 19:16 ` Arnaldo Carvalho de Melo
2016-02-25 19:17 ` Taeung Song
2016-02-27 9:41 ` [tip:perf/core] perf script: Remove duplicated code and needless script_spec__findnew() tip-bot for Taeung Song
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox