From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933615AbcBYTSE (ORCPT ); Thu, 25 Feb 2016 14:18:04 -0500 Received: from mail-pa0-f68.google.com ([209.85.220.68]:33158 "EHLO mail-pa0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933377AbcBYTSC (ORCPT ); Thu, 25 Feb 2016 14:18:02 -0500 Subject: Re: [PATCH 3/3] perf script: Remove duplicated code and needless a script_spec__findnew() To: Arnaldo Carvalho de Melo , Jiri Olsa References: <1456413190-12378-1-git-send-email-treeze.taeung@gmail.com> <20160225190222.GB4883@krava.redhat.com> <20160225191606.GR8720@kernel.org> Cc: linux-kernel@vger.kernel.org, Jiri Olsa , Namhyung Kim , Ingo Molnar From: Taeung Song Message-ID: <56CF5364.90509@gmail.com> Date: Fri, 26 Feb 2016 04:17:56 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160225191606.GR8720@kernel.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/26/2016 04:16 AM, Arnaldo Carvalho de Melo wrote: > Em Thu, Feb 25, 2016 at 08:02:22PM +0100, Jiri Olsa escreveu: >> On Fri, Feb 26, 2016 at 12:13:10AM +0900, Taeung Song wrote: >>> script_spec_register() called two functions >>> script_spec__find() and script_spec__findnew(). >>> But script_spec__find() was called two times. >>> >>> So remove script_spec__findnew() and make >>> script_spec_register() only call once script_spec__find(). >>> >>> Cc: Jiri Olsa >>> Signed-off-by: Taeung Song >> >> Acked-by: Jiri Olsa > > Looks good, applied. > > Thanks, > > - Arnaldo Thank you!! Taeung