From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752050AbcBYWQg (ORCPT <rfc822;w@1wt.eu>);
	Thu, 25 Feb 2016 17:16:36 -0500
Received: from mail113-251.mail.alibaba.com ([205.204.113.251]:60120 "EHLO
	us-alimail-mta2.hst.scl.en.alidc.net" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1751953AbcBYWQf (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 25 Feb 2016 17:16:35 -0500
X-Alimail-AntiSpam: AC=CONTINUE;BC=0.08283991|-1;FP=0|0|0|0|0|-1|-1|-1;HT=e01l07394;MF=chengang@emindsoft.com.cn;NM=1;PH=DS;RN=12;RT=12;SR=0;TI=SMTPD_----4YNC7L0_1456438561;
Message-ID: <56CF7E00.10101@emindsoft.com.cn>
Date: Fri, 26 Feb 2016 06:19:44 +0800
From: Chen Gang <chengang@emindsoft.com.cn>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Jiri Kosina <jikos@kernel.org>
CC: Mel Gorman <mgorman@techsingularity.net>, akpm@linux-foundation.org,
        vbabka@suse.cz, rientjes@google.com, linux-kernel@vger.kernel.org,
        mhocko@suse.cz, hannes@cmpxchg.org, vdavydov@virtuozzo.com,
        dan.j.williams@intel.com, linux-mm@kvack.org,
        Chen Gang <gang.chen.5i5j@gmail.com>
Subject: Re: [PATCH trivial] include/linux/gfp.h: Improve the coding styles
References: <1456352791-2363-1-git-send-email-chengang@emindsoft.com.cn> <20160225092752.GU2854@techsingularity.net> <56CF1202.2020809@emindsoft.com.cn> <alpine.LNX.2.00.1602251609120.22700@cbobk.fhfr.pm>
In-Reply-To: <alpine.LNX.2.00.1602251609120.22700@cbobk.fhfr.pm>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2/25/16 23:12, Jiri Kosina wrote:
> On Thu, 25 Feb 2016, Chen Gang wrote:
> 
>> I can understand for your NAK, it is a trivial patch. 
> 
> Not all trivial patches are NAKed :) But they have to be generally useful.
> 
> Shuffling code around, without actually changing / improving it a bit, 
> just for the sole purpose of formatting, is kind of pointless (especially 
> given the fact that the current code as-is is easily readable; it's not 
> like it'd be a horrible mess difficult to understand).
> 
> Sure, it might had been formatted better at the time it was actually 
> merged. But changing it "just because" after being in tree for long time 
> doesn't fix any problem really.
> 

OK, thanks. I have replied the related contents in the other thread.

Welcome any ideas, suggestions, and completions in the other related
thread.

Thanks.
-- 
Chen Gang (陈刚)

Managing Natural Environments is the Duty of Human Beings.