* [PATCH] ARM: s3c24xx: avoid warning for inb/outb
@ 2016-02-25 22:04 Arnd Bergmann
2016-02-25 23:46 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2016-02-25 22:04 UTC (permalink / raw)
To: Kukjin Kim, Krzysztof Kozlowski
Cc: linux-arm-kernel, Arnd Bergmann, linux-samsung-soc, linux-kernel
s3c24xx implements its own inb/outb macros, but the implementation
prints warnings when the port number argument is not a 32-bit scalar:
drivers/scsi/pas16.c: In function 'NCR5380_pwrite':
arch/arm/mach-s3c24xx/include/mach/io.h:193:68: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
#define __ioaddrc(port) ((__PORT_PCIO(port) ? PCIO_BASE + (port) : (void __iomem *)(port)))
This slightly modifies the definition of the __ioaddrc macro to avoid
the warning.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
arch/arm/mach-s3c24xx/include/mach/io.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-s3c24xx/include/mach/io.h b/arch/arm/mach-s3c24xx/include/mach/io.h
index 5dd1db4e2677..235c53647aa4 100644
--- a/arch/arm/mach-s3c24xx/include/mach/io.h
+++ b/arch/arm/mach-s3c24xx/include/mach/io.h
@@ -190,7 +190,7 @@ DECLARE_IO(int,l,"")
result; \
})
-#define __ioaddrc(port) ((__PORT_PCIO(port) ? PCIO_BASE + (port) : (void __iomem *)(port)))
+#define __ioaddrc(port) ((__PORT_PCIO(port) ? PCIO_BASE + (port) : (void __iomem *)0 + (port)))
#define inb(p) (__builtin_constant_p((p)) ? __inbc(p) : __inb(p))
#define inw(p) (__builtin_constant_p((p)) ? __inwc(p) : __inw(p))
--
2.7.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: s3c24xx: avoid warning for inb/outb
2016-02-25 22:04 [PATCH] ARM: s3c24xx: avoid warning for inb/outb Arnd Bergmann
@ 2016-02-25 23:46 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2016-02-25 23:46 UTC (permalink / raw)
To: Arnd Bergmann, Kukjin Kim
Cc: linux-arm-kernel, linux-samsung-soc, linux-kernel
On 26.02.2016 07:04, Arnd Bergmann wrote:
> s3c24xx implements its own inb/outb macros, but the implementation
> prints warnings when the port number argument is not a 32-bit scalar:
>
> drivers/scsi/pas16.c: In function 'NCR5380_pwrite':
> arch/arm/mach-s3c24xx/include/mach/io.h:193:68: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> #define __ioaddrc(port) ((__PORT_PCIO(port) ? PCIO_BASE + (port) : (void __iomem *)(port)))
>
> This slightly modifies the definition of the __ioaddrc macro to avoid
> the warning.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> arch/arm/mach-s3c24xx/include/mach/io.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Thanks, applied.
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-02-25 23:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-25 22:04 [PATCH] ARM: s3c24xx: avoid warning for inb/outb Arnd Bergmann
2016-02-25 23:46 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox