From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932392AbcBZHZq (ORCPT ); Fri, 26 Feb 2016 02:25:46 -0500 Received: from mailout1.w1.samsung.com ([210.118.77.11]:52856 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753841AbcBZHZo (ORCPT ); Fri, 26 Feb 2016 02:25:44 -0500 X-AuditID: cbfec7f5-f79b16d000005389-7b-56cffdf422c5 Subject: Re: [RESPIN 2/6] drivers: memory: Add support for exynos SROM driver To: Pankaj Dubey , linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <1456389222-12738-1-git-send-email-pankaj.dubey@samsung.com> <1456389222-12738-3-git-send-email-pankaj.dubey@samsung.com> Cc: kgene.kim@samsung.com, thomas.ab@samsung.com, olof@lixom.net, p.fedin@samsung.com, Kukjin Kim From: Krzysztof Kozlowski Message-id: <56CFFDF0.9040107@samsung.com> Date: Fri, 26 Feb 2016 16:25:36 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-version: 1.0 In-reply-to: <1456389222-12738-3-git-send-email-pankaj.dubey@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrGLMWRmVeSWpSXmKPExsVy+t/xq7pf/p4PM/iyxtri9QtDi94FV9ks +h+/ZrbY9Pgaq8XlXXPYLGac38dkcer6ZzaLV5dWsVks2vqF3aJjGaMDl8emVZ1sHpuX1Htc OdHE6tG3ZRWjx+dNcgGsUVw2Kak5mWWpRfp2CVwZX87vZi7oFau4t+ANWwNjm1AXIyeHhICJ xIGzzcwQtpjEhXvr2boYuTiEBJYySkw//xTKecoosfhvFytIlbCAr0Rr6zMmkISIwBRGia0z jrKBJIQE2hkljqwOArGZBcokPp4+yg5iswkYS2xevgSohoODV0BL4u5VP5Awi4CqxPl5T5lA bFGBCInDnV1g5bwCghI/Jt9jAbE5BTwlfs3oZwdpZRbQk7h/UQtiurzE5jVvmScwCsxC0jEL oWoWkqoFjMyrGEVTS5MLipPSc430ihNzi0vz0vWS83M3MUJC/+sOxqXHrA4xCnAwKvHwSlw4 HybEmlhWXJl7iFGCg1lJhDf4B1CINyWxsiq1KD++qDQntfgQozQHi5I478xd70OEBNITS1Kz U1MLUotgskwcnFINjPv0Nm7/VaHro/zt4brLm5lyZO+dF1hSfnvVjnsxjpxns97pK6y7vPur +ZHJzVE8c3Yfq+TN0jGyuKqm8/azS1uJ3f7TRSJlUhzyk7uWOW/effqt9ernDG3lGaGSKy++ v6wsukvye7KGRUZ/rMX3UwsWS39Z/Hf6mp/5l7UrEm4+tE5o6vrI+kWJpTgj0VCLuag4EQDr YQmqeQIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25.02.2016 17:33, Pankaj Dubey wrote: > This patch adds Exynos SROM controller driver which will handle > save restore of SROM registers during S2R. > > Signed-off-by: Pankaj Dubey > Reviewed-by: Krzysztof Kozlowski > [p.fedin@samsung.com: tested on SMDK5410] > Tested-by: Pavel Fedin > Signed-off-by: Kukjin Kim > Signed-off-by: Krzysztof Kozlowski > --- > drivers/memory/Kconfig | 1 + > drivers/memory/Makefile | 1 + > drivers/memory/samsung/Kconfig | 12 +++ > drivers/memory/samsung/Makefile | 1 + > drivers/memory/samsung/exynos-srom.c | 175 +++++++++++++++++++++++++++++++++++ > drivers/memory/samsung/exynos-srom.h | 51 ++++++++++ > 6 files changed, 241 insertions(+) > create mode 100644 drivers/memory/samsung/Kconfig > create mode 100644 drivers/memory/samsung/Makefile > create mode 100644 drivers/memory/samsung/exynos-srom.c > create mode 100644 drivers/memory/samsung/exynos-srom.h > > diff --git a/drivers/memory/Kconfig b/drivers/memory/Kconfig > index 6f31546..bcb1982 100644 > --- a/drivers/memory/Kconfig > +++ b/drivers/memory/Kconfig > @@ -114,6 +114,7 @@ config JZ4780_NEMC > the Ingenic JZ4780. This controller is used to handle external > memory devices such as NAND and SRAM. > > +source "drivers/memory/samsung/Kconfig" > source "drivers/memory/tegra/Kconfig" > > endif > diff --git a/drivers/memory/Makefile b/drivers/memory/Makefile > index 1c46af5..d100e40 100644 > --- a/drivers/memory/Makefile > +++ b/drivers/memory/Makefile > @@ -16,4 +16,5 @@ obj-$(CONFIG_MVEBU_DEVBUS) += mvebu-devbus.o > obj-$(CONFIG_TEGRA20_MC) += tegra20-mc.o > obj-$(CONFIG_JZ4780_NEMC) += jz4780-nemc.o > > +obj-$(CONFIG_SAMSUNG_MC) += samsung/ > obj-$(CONFIG_TEGRA_MC) += tegra/ > diff --git a/drivers/memory/samsung/Kconfig b/drivers/memory/samsung/Kconfig > new file mode 100644 > index 0000000..c2cd45e > --- /dev/null > +++ b/drivers/memory/samsung/Kconfig > @@ -0,0 +1,12 @@ > +config SAMSUNG_MC > + bool "SAMSUNG Exynos Memory Controller support" if COMPILE_TEST > + default y > + depends on ARCH_EXYNOS > + help > + This driver supports the Memory Controller (MC) hardwares found on > + SAMSUNG Exynos SoCs. > + if SAMSUNG_MC > +config EXYNOS_SROM > + bool > + depends on (ARM && ARCH_EXYNOS && PM) || ((ARM || ARM64) && COMPILE_TEST) (ARM && ARCH_EXYNOS && PM) || COMPILE_TEST You don't need to limit compile testing to ARM/ARM64. Rest is good. If there are no comments from other people, then I can fix this while applying. If there will be a comment or re-spin, then please apply my comments. Best regards, Krzysztof