From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932338AbcBZIEE (ORCPT ); Fri, 26 Feb 2016 03:04:04 -0500 Received: from mail-cys01nam02on0045.outbound.protection.outlook.com ([104.47.37.45]:52160 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753439AbcBZIEA (ORCPT ); Fri, 26 Feb 2016 03:04:00 -0500 Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=xilinx.com; kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=bestguesspass action=none header.from=xilinx.com; Subject: Re: [PATCH v3 6/6] PCI: xilinx: Allow build on MIPS platforms To: Bjorn Helgaas , Paul Burton References: <1454602213-967-1-git-send-email-paul.burton@imgtec.com> <1454602213-967-7-git-send-email-paul.burton@imgtec.com> <20160204175325.GB31145@NP-P-BURTON> <20160225154326.GE8120@localhost> CC: Rob Herring , Linux-MIPS , Bharat Kumar Gogada , Michal Simek , Ravikiran Gummaluri , "Ley Foon Tan" , Arnd Bergmann , Bjorn Helgaas , Phil Edworthy , "Scott Branden" , Stanimir Varbanov , "linux-kernel@vger.kernel.org" , Duc Dang , "linux-pci@vger.kernel.org" , Gabriele Paoloni , Marc Zyngier , Geert Uytterhoeven , Ray Jui , Hauke Mehrtens From: Michal Simek Message-ID: <56D00390.7030600@xilinx.com> Date: Fri, 26 Feb 2016 08:49:36 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160225154326.GE8120@localhost> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.0.0.1202-22154.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:149.199.60.83;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(164054003)(199003)(24454002)(189002)(377454003)(87936001)(65816999)(6806005)(11100500001)(23746002)(63266004)(87266999)(76176999)(54356999)(50986999)(189998001)(230700001)(4326007)(36756003)(93886004)(1220700001)(47776003)(86362001)(5001960100002)(65956001)(1096002)(2906002)(5001770100001)(36386004)(5008740100001)(586003)(64126003)(83506001)(92566002)(65806001)(106466001)(77096005)(19580395003)(19580405001)(80316001)(2950100001)(33656002)(7059030)(107986001);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1NAM02HT106;H:xsj-pvapsmtpgw01;FPR:;SPF:Pass;MLV:sfv;A:1;MX:1;LANG:en; X-MS-Office365-Filtering-Correlation-Id: bf45f768-8c93-45a5-f014-08d33e8166c3 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501002);SRVR:SN1NAM02HT106; X-Microsoft-Antispam-PRVS: <09108835da56428e9e457c8c5ee5bf5f@SN1NAM02HT106.eop-nam02.prod.protection.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(13017025)(13018025)(8121501046)(13024025)(13023025)(13015025)(3002001)(10201501046);SRVR:SN1NAM02HT106;BCL:0;PCL:0;RULEID:;SRVR:SN1NAM02HT106; X-Forefront-PRVS: 0864A36BBF X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2016 07:49:47.8785 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.83];Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1NAM02HT106 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25.2.2016 16:43, Bjorn Helgaas wrote: > On Thu, Feb 04, 2016 at 05:53:25PM +0000, Paul Burton wrote: >> On Thu, Feb 04, 2016 at 11:46:28AM -0600, Rob Herring wrote: >>> On Thu, Feb 4, 2016 at 10:10 AM, Paul Burton wrote: >>>> Allow the xilinx-pcie driver to be built on MIPS platforms. This will be >>>> used on the MIPS Boston board. >>>> >>>> Signed-off-by: Paul Burton >>>> >>>> --- >>>> >>>> Changes in v3: >>>> - Split out from Boston patchset. >>>> >>>> Changes in v2: None >>>> >>>> drivers/pci/host/Kconfig | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig >>>> index 75a6054..0aee193 100644 >>>> --- a/drivers/pci/host/Kconfig >>>> +++ b/drivers/pci/host/Kconfig >>>> @@ -81,7 +81,7 @@ config PCI_KEYSTONE >>>> >>>> config PCIE_XILINX >>>> bool "Xilinx AXI PCIe host bridge support" >>>> - depends on ARCH_ZYNQ >>>> + depends on ARCH_ZYNQ || MIPS >>> >>> Why don't you just remove the dependency? Then it gets better build coverage. >>> >>> Rob >> >> That seems like a call best made by whomever has to maintain this - if >> that's the preferred way to go I'm fine with it. > > I'm in favor of removing the dependency if possible. I guess Michal > would be the person to ack that. Not a problem to remove dependency on archs. There is pending support for Microblaze anyway. Thanks, Michal