From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754107AbcBZNpa (ORCPT <rfc822;w@1wt.eu>);
	Fri, 26 Feb 2016 08:45:30 -0500
Received: from mailapp01.imgtec.com ([195.59.15.196]:14442 "EHLO
	mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754057AbcBZNp2 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 26 Feb 2016 08:45:28 -0500
Subject: Re: [PATCH v7] mtd: nand: increase ready wait timeout and report
 timeouts
To: Richard Weinberger <richard@nod.at>,
        Boris Brezillon <boris.brezillon@free-electrons.com>,
        Brian Norris <computersforpeace@gmail.com>
References: <1444139527-14087-1-git-send-email-harvey.hunt@imgtec.com>
 <CAFLxGvxvWSGt3Z8p0yTPMh6v7LnjLKGtSeGdPkqauCYOXVnTzg@mail.gmail.com>
 <20160225231432.GN21465@google.com> <20160226002302.2f56f1a9@bbrezillon>
 <56CF8DCA.7010606@nod.at>
CC: Alex Smith <alex.smith@imgtec.com>, Alex Smith <alex@alex-smith.me.uk>,
        Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com>,
        David Woodhouse <dwmw2@infradead.org>,
        Niklas Cassel <niklas.cassel@axis.com>,
        "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
        LKML <linux-kernel@vger.kernel.org>
From: Harvey Hunt <harvey.hunt@imgtec.com>
Message-ID: <56D056F5.8040302@imgtec.com>
Date: Fri, 26 Feb 2016 13:45:25 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <56CF8DCA.7010606@nod.at>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [192.168.154.40]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

On 25/02/16 23:27, Richard Weinberger wrote:
> Am 26.02.2016 um 00:23 schrieb Boris Brezillon:
>>> Regardless, this timeout loop is wrong. Shouldn't it have something like
>>> the following?
>>>
>>> diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
>>> index f2c8ff398d6c..596a9b0503da 100644
>>> --- a/drivers/mtd/nand/nand_base.c
>>> +++ b/drivers/mtd/nand/nand_base.c
>>> @@ -566,8 +566,8 @@ void nand_wait_ready(struct mtd_info *mtd)
>>>   		cond_resched();
>>>   	} while (time_before(jiffies, timeo));
>>>
>>> -	pr_warn_ratelimited(
>>> -		"timeout while waiting for chip to become ready\n");
>>> +	if (!chip->dev_ready(mtd))
>>> +		pr_warn_ratelimited("timeout while waiting for chip to become ready\n");
>>>   out:
>>>   	led_trigger_event(nand_led_trigger, LED_OFF);
>>>   }
>>
>> Looks good to me.
>>
>> If you post the patch, you can add
>>
>> Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com>
>
> Same here.
>
> Reviewed-by: Richard Weinberger <richard@nod.at>
>
> Thanks,
> //richard
>

-cc IMG list (I left it in my gitconfig when I originally sent this 
patch...).

Thanks for debugging and fixing this - proposed patch looks good to me:

Reviewed-by: Harvey Hunt <harvey.hunt@imgtec.com>

Thanks,

Harvey