From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933851AbcBZTQm (ORCPT <rfc822;w@1wt.eu>);
	Fri, 26 Feb 2016 14:16:42 -0500
Received: from mga04.intel.com ([192.55.52.120]:44668 "EHLO mga04.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S933304AbcBZTQl (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 26 Feb 2016 14:16:41 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.22,504,1449561600"; 
   d="scan'208";a="753915096"
Subject: Re: [PATCH] x86/mpx: Fix off-by-one comparison with nr_registers
To: Colin King <colin.king@canonical.com>,
        Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@kernel.org>,
        "H . Peter Anvin" <hpa@linux.intel.com>, x86@kernel.org,
        Borislav Petkov <bp@alien8.de>,
        "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>
References: <1456512931-3388-1-git-send-email-colin.king@canonical.com>
Cc: linux-kernel@vger.kernel.org
From: Dave Hansen <dave.hansen@linux.intel.com>
Message-ID: <56D0A29C.9040504@linux.intel.com>
Date: Fri, 26 Feb 2016 11:08:12 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <1456512931-3388-1-git-send-email-colin.king@canonical.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 02/26/2016 10:55 AM, Colin King wrote:
> In the unlikely event that regno == nr_registers then we get an array
> overrun on regoff because the invalid register check is currently
> off-by-one. Fix this with a check that regno is >= nr_registers instead.
> 
> Detected with static analysis using CoverityScan.

Oh, the irony of an overrun in the MPX code!  Thanks for catching this.

Acked-by: Dave Hansen <dave.hansen@intel.com>