From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754818AbcBZXqE (ORCPT ); Fri, 26 Feb 2016 18:46:04 -0500 Received: from mail-oi0-f41.google.com ([209.85.218.41]:34060 "EHLO mail-oi0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755128AbcBZXqC (ORCPT ); Fri, 26 Feb 2016 18:46:02 -0500 Subject: Re: [PATCH] tools lib traceevent: Add '~' operation within arg_num_eval() To: Steven Rostedt , Arnaldo Carvalho de Melo References: <1456512767-1164-1-git-send-email-namhyung@kernel.org> <1456512767-1164-4-git-send-email-namhyung@kernel.org> <20160226214307.GX8720@kernel.org> <20160226214506.GY8720@kernel.org> <20160226220819.GZ8720@kernel.org> <20160226181328.22f47129@gandalf.local.home> Cc: Namhyung Kim , Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , Andi Kleen , Stephane Eranian , Wang Nan From: David Ahern Message-ID: <56D0E3B7.5090202@gmail.com> Date: Fri, 26 Feb 2016 16:45:59 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160226181328.22f47129@gandalf.local.home> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/26/16 4:13 PM, Steven Rostedt wrote: > When evaluating values for print flags, if the value included a '~' > operator, the parsing would fail. This broke kmalloc's parsing of: > > __print_flags(REC->gfp_flags, "|", {(unsigned > long)((((((( gfp_t)(0x400000u|0x2000000u)) | (( gfp_t)0x40u) | > (( gfp_t)0x80u) | (( gfp_t)0x20000u)) | (( gfp_t)0x02u)) | > (( gfp_t)0x08u)) | (( gfp_t)0x4000u) | (( gfp_t)0x10000u) | > (( gfp_t)0x1000u) | (( gfp_t)0x200u)) & ~(( gfp_t)0x2000000u)) > ^ > | > here > > Signed-off-by: Steven Rostedt > --- I've been meaning to chase this down for a few weeks. Worked for me. Tested-by: David Ahern