From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756556AbcB0L5S (ORCPT ); Sat, 27 Feb 2016 06:57:18 -0500 Received: from mx2.suse.de ([195.135.220.15]:60911 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756183AbcB0L5Q (ORCPT ); Sat, 27 Feb 2016 06:57:16 -0500 Subject: Re: [PATCH v2 1/6] hisi_sas: change tmf func complete check To: John Garry , JBottomley@odin.com, martin.petersen@oracle.com References: <1456393335-38294-1-git-send-email-john.garry@huawei.com> <1456393335-38294-2-git-send-email-john.garry@huawei.com> Cc: linuxarm@huawei.com, john.garry2@mail.dcu.ie, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org From: Hannes Reinecke Message-ID: <56D18F0A.30400@suse.de> Date: Sat, 27 Feb 2016 19:56:58 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1456393335-38294-2-git-send-email-john.garry@huawei.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/25/2016 05:42 PM, John Garry wrote: > In hisi_sas_exec_internal_tmf_task(), the check for > SAM_STAT_GOOD is replaced with > TMF_RESP_FUNC_COMPLETE, which is a genuine tmf > response code. > SAM_STAT_GOOD and TMF_RESP_FUNC_COMPLETE have the > same value, so this is why it worked before. > > Signed-off-by: John Garry > --- Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)