From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423587AbcB0MAL (ORCPT ); Sat, 27 Feb 2016 07:00:11 -0500 Received: from mx2.suse.de ([195.135.220.15]:32843 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1423506AbcB0MAJ (ORCPT ); Sat, 27 Feb 2016 07:00:09 -0500 Subject: Re: [PATCH v2 5/6] hisi_sas: add hisi_sas_slave_configure() To: John Garry , JBottomley@odin.com, martin.petersen@oracle.com References: <1456393335-38294-1-git-send-email-john.garry@huawei.com> <1456393335-38294-6-git-send-email-john.garry@huawei.com> Cc: linuxarm@huawei.com, john.garry2@mail.dcu.ie, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org From: Hannes Reinecke Message-ID: <56D18FBC.8050501@suse.de> Date: Sat, 27 Feb 2016 19:59:56 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1456393335-38294-6-git-send-email-john.garry@huawei.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/25/2016 05:42 PM, John Garry wrote: > In high-datarate aging tests, it is found that the > SCSI framework can periodically issue lu resets as > some commands timeout. > Response TASK SET FULL and SAS_QUEUE_FULL may be > returned many times for the same command, causing the > timeouts. > The SAS_QUEUE_FULL errors come from > TRANS_TX_CREDIT_TIMEOUT_ERR, TRANS_TX_CLOSE_NORMAL_ERR, > and TRANS_TX_ERR_FRAME_TXED errors. They do not mean > that the queue is full in the host, but rather it is > equivalent to meaning the queue is full for the sdev. > To overcome this, the queue depth for the sdev is > reduced to 64 (from 256, set in sas_slave_configure()). > Normally error code SAS_QUEUE_FULL will result in the > sdev queue depth falling, but it falls too slowly during > high-datarate tests and commands timeout before it > has fallen to an adequete level from original value. > > Signed-off-by: John Garry > --- Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)