From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756605AbcB2Ekx (ORCPT ); Sun, 28 Feb 2016 23:40:53 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:47304 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753320AbcB2Eku (ORCPT ); Sun, 28 Feb 2016 23:40:50 -0500 Subject: Re: [PATCH v7] watchdog: Add watchdog timer support for the WinSystems EBC-C384 To: William Breathitt Gray , wim@iguana.be References: <20160229042039.GA29582@sophia> Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org From: Guenter Roeck Message-ID: <56D3CBD0.1000706@roeck-us.net> Date: Sun, 28 Feb 2016 20:40:48 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160229042039.GA29582@sophia> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 02/28/2016 08:20 PM, William Breathitt Gray wrote: > The WinSystems EBC-C384 has an onboard watchdog timer. The timeout range > supported by the watchdog timer is 1 second to 255 minutes. Timeouts > under 256 seconds have a 1 second granularity, while the rest have a 1 > minute granularity. > > This driver adds watchdog timer support for this onboard watchdog timer. > The timeout may be configured via the timeout module parameter. > > Signed-off-by: William Breathitt Gray > Reviewed-by: Guenter Roeck > --- > Changes in v7: > - Make sure timeout member is in seconds resolution despite minutes > granularity > For Wim's benefit: You forgot the actual change. The follow-up RESEND is really confusing; RESEND indicates that no change was made, and leaves it up to us to figure out what is going on. If something like this happens again, just add another rev and add a note indicating what has (really) changed. Also, when you make code changes, please drop previous Reviewed-by: or Acked-by: tags unless you got explicit permission from the reviewer to keep the tag. Thanks, Guenter