public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Vaishali Thakkar <vaishali.thakkar@oracle.com>
To: Tapan Prakash T <tapanprakasht@gmail.com>,
	gregkh@linuxfoundation.org, mateusz.kulikowski@gmail.com,
	vthakkar1994@gmail.com
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8192e: rtllib_softmac.c: Remove multiple blank lines
Date: Mon, 29 Feb 2016 16:41:27 +0530	[thread overview]
Message-ID: <56D4275F.2010602@oracle.com> (raw)
In-Reply-To: <1456670916-16809-1-git-send-email-tapanprakasht@gmail.com>



On Sunday 28 February 2016 08:18 PM, Tapan Prakash T wrote:
> Fixed blank lines issues reported by checkpatch.pl
Hi,

I can see that you have sent 3 patches for the same file. But they are
sent as separate patches. So, this might be confusing for the maintainer.

So, in this case these are some points you need to keep in mind:

1. You can send a single patch for the same warnings/errors in the same
file or directory covering all occurrences.

2. If you want to send patches for different errors in a single file then you
need to send a patch in the form of a patchset.

I think this should help you with understanding my point in a better way:

https://www.kernel.org/doc/Documentation/SubmittingPatches

> Signed-off-by: Tapan Prakash T <tapanprakasht@gmail.com>
> ---
>  drivers/staging/rtl8192e/rtllib_softmac.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c
> index 25b5b5e..b40298b 100644
> --- a/drivers/staging/rtl8192e/rtllib_softmac.c
> +++ b/drivers/staging/rtl8192e/rtllib_softmac.c
> @@ -13,7 +13,6 @@
>   * released under the GPL
>   */
>  
> -
>  #include "rtllib.h"
>  
>  #include <linux/random.h>
> @@ -25,7 +24,6 @@
>  
>  static void rtllib_sta_wakeup(struct rtllib_device *ieee, short nl);
>  
> -
>  static short rtllib_is_54g(struct rtllib_network *net)
>  {
>  	return (net->rates_ex_len > 0) || (net->rates_len > 4);

-- 
Vaishali

  reply	other threads:[~2016-02-29 11:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-28 14:48 [PATCH] staging: rtl8192e: rtllib_softmac.c: Remove multiple blank lines Tapan Prakash T
2016-02-29 11:11 ` Vaishali Thakkar [this message]
  -- strict thread matches above, loose matches on Subject: below --
2016-02-28 16:53 Tapan Prakash T
2016-03-05 22:59 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56D4275F.2010602@oracle.com \
    --to=vaishali.thakkar@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mateusz.kulikowski@gmail.com \
    --cc=tapanprakasht@gmail.com \
    --cc=vthakkar1994@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox