From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754465AbcB2LLx (ORCPT ); Mon, 29 Feb 2016 06:11:53 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:41604 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754405AbcB2LLt (ORCPT ); Mon, 29 Feb 2016 06:11:49 -0500 Subject: Re: [PATCH] staging: rtl8192e: rtllib_softmac.c: Remove multiple blank lines To: Tapan Prakash T , gregkh@linuxfoundation.org, mateusz.kulikowski@gmail.com, vthakkar1994@gmail.com References: <1456670916-16809-1-git-send-email-tapanprakasht@gmail.com> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org From: Vaishali Thakkar Message-ID: <56D4275F.2010602@oracle.com> Date: Mon, 29 Feb 2016 16:41:27 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <1456670916-16809-1-git-send-email-tapanprakasht@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sunday 28 February 2016 08:18 PM, Tapan Prakash T wrote: > Fixed blank lines issues reported by checkpatch.pl Hi, I can see that you have sent 3 patches for the same file. But they are sent as separate patches. So, this might be confusing for the maintainer. So, in this case these are some points you need to keep in mind: 1. You can send a single patch for the same warnings/errors in the same file or directory covering all occurrences. 2. If you want to send patches for different errors in a single file then you need to send a patch in the form of a patchset. I think this should help you with understanding my point in a better way: https://www.kernel.org/doc/Documentation/SubmittingPatches > Signed-off-by: Tapan Prakash T > --- > drivers/staging/rtl8192e/rtllib_softmac.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c > index 25b5b5e..b40298b 100644 > --- a/drivers/staging/rtl8192e/rtllib_softmac.c > +++ b/drivers/staging/rtl8192e/rtllib_softmac.c > @@ -13,7 +13,6 @@ > * released under the GPL > */ > > - > #include "rtllib.h" > > #include > @@ -25,7 +24,6 @@ > > static void rtllib_sta_wakeup(struct rtllib_device *ieee, short nl); > > - > static short rtllib_is_54g(struct rtllib_network *net) > { > return (net->rates_ex_len > 0) || (net->rates_len > 4); -- Vaishali