From: Chen Gang <chengang@emindsoft.com.cn>
To: "Theodore Ts'o" <tytso@mit.edu>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH trivial] include/linux/gfp.h: Improve the coding styles
Date: Mon, 29 Feb 2016 23:48:44 +0800 [thread overview]
Message-ID: <56D4685C.2020805@emindsoft.com.cn> (raw)
In-Reply-To: <20160228222334.GA8010@thunk.org>
On 2/29/16 06:23, Theodore Ts'o wrote:
> On Sun, Feb 28, 2016 at 08:47:23AM +0800, Chen Gang wrote:
>>
>> Excuse me, when I sent this patch, I did not know who I shall send to, I
>> have to reference to "./scripts/get_maintainer.pl".
>>
>> If any members have no time to care about it (every members' time are
>> really expensive), please let me know (can reply directly).
>
> Yes, everybody's time is very expensive. So why are you wasting it
> all with a "last post wins" style of argumentation? A maintainer has
> NAK'ed it. Please drop this.
>
For me, I don't care about "last post wins".
But I care about the technical correctness, and for me, we (all of us)
need try our best to let the email reply as correct as we can, so can
avoid to mislead another readers.
So for me, if any members have new ideas, suggestions, or completions,
they can still reply at any time (may be next day, next week, or next
month ...).
> There is a reason why whitespace fixes are often consider to have
> extreme negative value, and a deep suspicion that people are doing
> this just to say that they have a patch in the kernel, perhaps in the
> misapprehension that this will help them get a job.
>
For me, I don't think so, at least for me, contribution and learning is
my main goal in open source community, so I mainly focus on correctness.
All of us know when some related maintainer NAK'ed, the related patch,
of cause, must be dropped, the reason why I still reply the mail is: I
shall try to make the discussion/communication as correct as I can.
For "get a job", I guess, the open source community is helpful, but I
also suggest: if someone wants to "get a job", he/she should not depend
on the open source community (community has no duty for it).
> Let me say that if I were a hiring manager, and I did a Google search
> on a potential job application, and came across a thread like this, my
> reaction would be extremely negative.
>
For me, job hunter and HR hunter can use open source community, but the
open source community's main goal is not for job hunter or HR hunter. I
guess, the open source community's goal should be:
- Develop the relate product (we can treat it as urgent thing, e.g.
new features, bug fix).
- Learning and discussing the product related technical issues (we can
treat it as important thing, I guess, "coding styles issues" should
be one of these issues).
Welcome any members ideas, suggestions, and completions for it.
Thanks.
--
Chen Gang (陈刚)
Managing Natural Environments is the Duty of Human Beings.
prev parent reply other threads:[~2016-02-29 17:47 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-24 22:26 [PATCH trivial] include/linux/gfp.h: Improve the coding styles chengang
2016-02-25 1:01 ` SeongJae Park
2016-02-25 14:12 ` Chen Gang
2016-02-25 8:57 ` Michal Hocko
2016-02-25 14:23 ` Chen Gang
2016-02-25 14:47 ` Michal Hocko
2016-02-25 22:17 ` Chen Gang
2016-02-25 9:27 ` Mel Gorman
2016-02-25 14:38 ` Chen Gang
2016-02-25 15:12 ` Jiri Kosina
2016-02-25 22:19 ` Chen Gang
2016-02-25 16:07 ` Mel Gorman
2016-02-25 22:29 ` Chen Gang
2016-02-25 22:39 ` Jiri Kosina
2016-02-26 14:57 ` Chen Gang
2016-02-25 23:12 ` SeongJae Park
2016-02-26 15:06 ` Chen Gang
2016-02-26 2:32 ` Jianyu Zhan
2016-02-26 15:26 ` Chen Gang
2016-02-27 2:45 ` Theodore Ts'o
2016-02-27 14:32 ` Chen Gang
2016-02-27 16:53 ` Theodore Ts'o
2016-02-28 0:21 ` Chen Gang
2016-02-28 13:27 ` Mel Gorman
2016-02-28 15:28 ` Chen Gang
2016-02-27 23:14 ` Jiri Kosina
2016-02-28 0:47 ` Chen Gang
2016-02-28 22:23 ` Theodore Ts'o
2016-02-29 15:48 ` Chen Gang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D4685C.2020805@emindsoft.com.cn \
--to=chengang@emindsoft.com.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox