From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752611AbcB2SOB (ORCPT ); Mon, 29 Feb 2016 13:14:01 -0500 Received: from mail-bl2on0077.outbound.protection.outlook.com ([65.55.169.77]:31664 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750871AbcB2SN4 (ORCPT ); Mon, 29 Feb 2016 13:13:56 -0500 Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=caviumnetworks.com; Message-ID: <56D48A5C.6040709@caviumnetworks.com> Date: Mon, 29 Feb 2016 10:13:48 -0800 From: David Daney User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Robert Richter CC: David Daney , Will Deacon , , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , , Ard Biesheuvel , Frank Rowand , Grant Likely , Catalin Marinas , Matt Fleming , , Ganapatrao Kulkarni , Robert Richter , , David Daney Subject: Re: [PATCH v12 3/5] dt, numa: Add NUMA dt binding implementation. References: <1456192703-2274-1-git-send-email-ddaney.cavm@gmail.com> <1456192703-2274-4-git-send-email-ddaney.cavm@gmail.com> <20160229172956.GF31343@rric.localdomain> In-Reply-To: <20160229172956.GF31343@rric.localdomain> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [64.2.3.194] X-ClientProxiedBy: SN1PR0701CA0047.namprd07.prod.outlook.com (25.163.126.15) To SN1PR07MB2142.namprd07.prod.outlook.com (25.164.47.12) X-Microsoft-Exchange-Diagnostics: 1;SN1PR07MB2142;2:sCAVotJWEwTRBSZn+xSDC9mxdlfCJCiGXdaYrsbyNNoUkSxzQsumFXTdIhsSRDFCNG8QxvWXbsTuakj8TyMwpH1YvMFdJgAT6+DRANLJf8+U6ClqiyV/nVEGTBe6lUzg2i8lJSwcdJaWjDjqx009rA==;3:C+D/ytKtnPO72lp+xA21HqIcAPxd6Vryjydnlrmz3YtqCg84bqJsKfX5CylI/geWm5XnAlcU2CslhijH04mmWYITYXlxRW0j1AkCbfasqMiCan83vHPpXA8xgaba01Ry;25:BKYkdwRpsMNRJT5eY+oJd4wKRd0/vuxV8m0K6pRyBPaJVAJCtHxCx0VImfayALOL68gBMJUb30lI/GnUUyg+uYG+kSpaHvz0eVkirQLhHFNfLul4+NO/GDAqbnA8ZRhFcMzeQnEz17RtazysJIq2M83lsfgxv4qNJuzjZ4gg6c5kc4fogoYb6gJp2Q0LE8nA+9sXf5EmUhJy+rY4keXom1wuW8Bh0h0PLbV1lDpSLAwBfFvbQMkDfGPuwVqZnSMrKm7zVKgrj/afCJxPUWFE+Pq9mguKOeKXNW9S3LhLMyXI6Delgw9xohLUJj7XR6+cL1PSQO0yoLcOJfPb2XjHEQ== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SN1PR07MB2142; X-MS-Office365-Filtering-Correlation-Id: 60cc43de-bcf6-4ce1-79f9-08d341341492 X-Microsoft-Exchange-Diagnostics: 1;SN1PR07MB2142;20:ygbA6aWUAhNBszjb3OwB9evzU63nZNsLwbcUwpEy+EwwkLN/qoEgM65Q7cHKnQ8we/tFQK1AG+aKE7+JI2NHirjTA6Cfx3O1V/mm67LaUNEb/CNpgLk0hJc1WzeI4yncXJPMFd2G8sGw885BNT/JgBUg4olLwPoPHBXFXiEfinvOWfG9UlE4sVFqtqO07lsIb0lyJQ6xBH0ciuA+unSz5qzC/LIqipWEFCLJh7dtFWXWrbqgGToxioFMO7ycmYUwagg9lVFNmYBZxaCaUQOwOwNip7M/DemoSC30A1yCPgPDTnBZiB+IO7jcFchSLLzBDjtKJHJ3yHGAOIQCq1e+e6LpcXB7OCfAsPbw7FtfwyPWaISxZFBgVFL460jau9mbcPhBRnhORWOeDB/72EYmbtxVA3SlFrLnwxR6KptUmGyCpoUDOcv5E+iUXGpCZb6R3S1iCVk8i1PEEQjYFD1wpSA+qhfyse15ff5nSEePmoK572jcQzT1cTjztcBrwnaCHRCNDzwAHqKe6WsE0YVbVPrNYmJYGzxRh4apNS72zU/ttyAKOm7kc6YTQVI94EZ2/zMLwaADy9qzcJ2MjUPj9LP02sXeCOD+gVTSiNeUSj4= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046);SRVR:SN1PR07MB2142;BCL:0;PCL:0;RULEID:;SRVR:SN1PR07MB2142; X-Microsoft-Exchange-Diagnostics: 1;SN1PR07MB2142;4:/cnS+MGIe6teg4CYy7PJFJfBsD1M714sVGNEMVNQzYqkeT1dvDgG3bMjIlHIaJ8/J3hWJOcbaCvsipgcd+JBvtbx8BTSQl1bUvHYUC8tyi7uUsrUzg/z561AzmDBZMQVnvPMdM0ob3nQvV7kCGLpeXttJs7Ls7awDGwxJM1B5EOLdyHT4qLw2RhVJt+g0JfrwHD/1E5NdXpgoFi4/J9ZE9Ex0V0kJzUfFRsMwrVUFUJ42mIufGexm5uhshITq6bZkrPzxekKjwjLIMhyADbp+KbL5wj5uVKqxn1pflA+I4diTMAp8JEhsOqXhHi+XB0IStuQKRvbecAtIE1GlQ4i3XgW/slRF7CmjYbeIB7Rs0k6kNsq+CirMhXJfG2IDB8E X-Forefront-PRVS: 0867F4F1AA X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(479174004)(24454002)(377454003)(87266999)(65816999)(40100003)(23756003)(76176999)(110136002)(54356999)(50986999)(33656002)(189998001)(122386002)(87976001)(64126003)(65956001)(2950100001)(2906002)(66066001)(5008740100001)(47776003)(36756003)(81156008)(1096002)(6116002)(19580405001)(19580395003)(230700001)(80316001)(5004730100002)(77096005)(42186005)(53416004)(3846002)(4001350100001)(586003)(92566002)(5001960100003);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR07MB2142;H:dl.caveonetworks.com;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?iso-8859-1?Q?1;SN1PR07MB2142;23:YQjpTYL/jec8S8idVP//PWOrvrr7ZKHGlwseFjH?= =?iso-8859-1?Q?cD6dQ9ltKmnE6uc/J93JU4bJbLXUeB5sR7hB0FtEGl6iAGG1VZn/wQ3qa+?= =?iso-8859-1?Q?F/jHpQP2oHmNl3aDJEVwKvI6mVcMJw9rz3diAsrpLvU5Xv7vea83p2Hx1+?= =?iso-8859-1?Q?S3VziTqQjmyK/mz5xdHcp0v/FL/bRqcfFoFL1oxsTRN6Sdgwe9v1I2F3/w?= =?iso-8859-1?Q?xaagcwo6GQIhV+x4kvoR1PAT+/8evzyTaXavhGh6AMn+B/BnMsAOFK3yiJ?= =?iso-8859-1?Q?gVjbXABZWc2FOeyzbXjeMpg84als/bgS4dRlxmMKBiT70aSv7OcYpEmPUR?= =?iso-8859-1?Q?XFiPDPMEimHMeKii7Ad8nLHCuMus+IFBE0SzIcIzeqZQTRe4BMyRB2Axgz?= =?iso-8859-1?Q?d+eDUwm67IeZDtGf+TWkee7mtEUUjdXtxmSDUOUdYy7+AZttw1uYjotpI8?= =?iso-8859-1?Q?EXYQhPUqkgPGHOX0nFdbQbax5GkZ02rRODaM5dfHwdLkZzob+xr6KbVJiD?= =?iso-8859-1?Q?cCx1ZnFVMo+K/zILjk2S/rgN0tth8lHFkk31FBWUf3rAd+PXWIpZElx19y?= =?iso-8859-1?Q?EBAeV9FDdbW0zVSJ1PmIHMAIs042lbqa/AvQROoL128WjsoU94HBJjwY69?= =?iso-8859-1?Q?rEGl/o99w/QkePFJATbVmX3vqAtloLgbrpJk76rrx4eKHXEfXaMafZvpro?= =?iso-8859-1?Q?M8o3OY0zlobqK+jTTrgxFdwnOG1CCGyFDwIUEBpJcRuv72+64iA1zNrT7j?= =?iso-8859-1?Q?dtnRelxBgLDs50CXiEuvhzRyK5G/J9aL2jICBc6TC4Qw65OZkZ2Z5Qydz4?= =?iso-8859-1?Q?NetGa+dPiF9pHzMPbo5hNNU1gstbr4ggoJ4R8AGsGBzcd2HCCLGg15HOfk?= =?iso-8859-1?Q?nFnucYnrPtABu5e0ARXKgT8QKLNL1kHCAQP06yiFwkkWMPViTGINQLDo+q?= =?iso-8859-1?Q?+7nkJ+Z7VPte+zwDQDjImPTpCBUkLrYqqa2LAscmHuO1/w2mDFOda6NhhD?= =?iso-8859-1?Q?Vgzc76v8xSKbd32+225Ip/Kb4NTYOPXJ9MFh21WCU0ew8z4OQ2jWR2OfRD?= =?iso-8859-1?Q?+2afwbt+fNDR0ChMHWYNSHj8KdKLR2KyNRQSBU1EzQHIQZWY6ry2LYkTdM?= =?iso-8859-1?Q?NaWNtSx8PSjgqDau8SCYoTt0X0A=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;SN1PR07MB2142;5:cC4CEzOAFktdbgPi84gBH6c1jwzfma2XKkw/STnozGb2S+QIAr48Tvx8Z1j/XfCZyzdqxMW7EooNa4gujFTD2OlhVbBUaA6VbNzrWvaVemKpEb0mjhDXXHa0XsL8yZ92vG80wF2glWHCBY9l9pGq+w==;24:u9qdOEkGzKMZ9mn6XXw36tWo9VAoaTEca3ip+BAhcRIQu0+k+DPOkhbu/mFjD/ZYnm/nEXDXSE9PLtJhq4hM/SDqr6NCvl3JByTFifxtHZ4= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Feb 2016 18:13:51.7682 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR07MB2142 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/29/2016 09:29 AM, Robert Richter wrote: > On 22.02.16 17:58:21, David Daney wrote: >> From: Ganapatrao Kulkarni >> >> ADD device tree node parsing for NUMA topology using device >> "numa-node-id" property distance-map. >> >> Reviewed-by: Robert Richter >> Signed-off-by: Ganapatrao Kulkarni >> Signed-off-by: David Daney >> --- >> drivers/of/Kconfig | 3 + >> drivers/of/Makefile | 1 + >> drivers/of/of_numa.c | 211 +++++++++++++++++++++++++++++++++++++++++++++++++++ >> include/linux/of.h | 9 +++ >> 4 files changed, 224 insertions(+) >> create mode 100644 drivers/of/of_numa.c >> >> diff --git a/drivers/of/Kconfig b/drivers/of/Kconfig >> index e2a4841..b3bec3a 100644 >> --- a/drivers/of/Kconfig >> +++ b/drivers/of/Kconfig >> @@ -112,4 +112,7 @@ config OF_OVERLAY >> While this option is selected automatically when needed, you can >> enable it manually to improve device tree unit test coverage. >> >> +config OF_NUMA > > In arch/arm64/Kconfig you now need to: > > select OF_NUMA if NUMA && OF > > This should depend here on OF and NUMA and enabled in that case. Why > moving that to arch code? The dependency on of_numa.o is in the architecture specific code, so that is where the Kconfig select should be too. For new code, we try to avoid putting architecture specific things into the core Kconfig files. Since arm64 is the only architecture that is currently using this, we don't want to select it for non-arm64 kernels that happen to select NUMA && OF. I will restore the depends, as it is guard against errors in the architecture specific Kconfig select statements, but I am going to leave the NUMA && OF in the arm64/Kconfig for clarity. > This duplicates code as the same needs to be > implemented for every arch. > Better to duplicate a single Kconfig select statement a few times in architecture specific Kconfig files, than force people to continuously modify the depends in drivers/of/Kconfig David.