From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751814AbcCAC4Z (ORCPT ); Mon, 29 Feb 2016 21:56:25 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:34509 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750849AbcCAC4U (ORCPT ); Mon, 29 Feb 2016 21:56:20 -0500 Subject: Re: [PATCH 2/3] ipmi/watchdog: Use nmi_panic() when kernel panics in NMI handler To: Hidehiro Kawai , Andrew Morton , Thomas Mingarelli , Wim Van Sebroeck , Corey Minyard References: <20160301015035.4318.78677.stgit@softrs> <20160301015039.4318.58063.stgit@softrs> Cc: openipmi-developer@lists.sourceforge.net, Michal Hocko , Borislav Petkov , linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org From: Guenter Roeck Message-ID: <56D504D2.3070701@roeck-us.net> Date: Mon, 29 Feb 2016 18:56:18 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160301015039.4318.58063.stgit@softrs> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/29/2016 05:50 PM, Hidehiro Kawai wrote: > commit 58c5661f2144 ("panic, x86: Allow CPUs to save registers even > if looping in NMI context") introduced nmi_panic() which prevents > concurrent/recursive execution of panic(). It also saves registers > for the crash dump on x86. > > ipmi_watchdog driver can call panic() from NMI handler, so replace > it with nmi_panic(). > > Signed-off-by: Hidehiro Kawai > Cc: Corey Minyard > Cc: openipmi-developer@lists.sourceforge.net Acked-by: Guenter Roeck > --- > drivers/char/ipmi/ipmi_watchdog.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/char/ipmi/ipmi_watchdog.c b/drivers/char/ipmi/ipmi_watchdog.c > index 096f0ce..4facc75 100644 > --- a/drivers/char/ipmi/ipmi_watchdog.c > +++ b/drivers/char/ipmi/ipmi_watchdog.c > @@ -1140,7 +1140,7 @@ ipmi_nmi(unsigned int val, struct pt_regs *regs) > the timer. So do so. */ > pretimeout_since_last_heartbeat = 1; > if (atomic_inc_and_test(&preop_panic_excl)) > - panic(PFX "pre-timeout"); > + nmi_panic(regs, PFX "pre-timeout"); > } > > return NMI_HANDLED; > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >