From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751885AbcCAGp0 (ORCPT ); Tue, 1 Mar 2016 01:45:26 -0500 Received: from szxga01-in.huawei.com ([58.251.152.64]:46709 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751199AbcCAGpY (ORCPT ); Tue, 1 Mar 2016 01:45:24 -0500 Reply-To: Subject: Re: [PATCH v4 1/2] gpio: designware: switch device node to fwnode and add acpi binding References: <1456751596-98963-1-git-send-email-qiujiang@huawei.com> <1456751596-98963-2-git-send-email-qiujiang@huawei.com> To: Andy Shevchenko CC: Linus Walleij , Alexandre Courbot , Mika Westerberg , "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "linux-acpi@vger.kernel.org" , , , From: Jiang Qiu Message-ID: <56D539A6.1080906@huawei.com> Date: Tue, 1 Mar 2016 14:41:42 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.74.160.152] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020201.56D539B5.000E,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: c40144469259a85939bf54111555e347 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2016/2/29 21:51, Andy Shevchenko 写道: > On Mon, Feb 29, 2016 at 3:13 PM, qiujiang wrote: >> This patch switches device node to fwnode and adds acpi >> binding. As a result, DT and acpi bingdings are compatible >> for this driver. > > I'm not sure it makes sense to add ACPI binding here. It more logical > to me to add them in patch 2/2. > And I see that it touches different subsystems. > >> >> Acked-by: Mika Westerberg > > Due to above and Mika's Ack was only to ACPI parts, I think > you may be split this also to two and we will have clearly logical set: > 1. Convert to fwnode > 2. Add ACPI bindings > 3. ACPI event support. > > Does it sound okay to you? > > If you do that I give my > Acked-by: Andy Shevchenko > to intel_quark_i2c_gpio.c part and > Reviewed-by: Andy Shevchenko > to the rest. > >> Signed-off-by: qiujiang >> --- >> drivers/gpio/gpio-dwapb.c | 62 +++++++++++++++++++------------- >> drivers/mfd/intel_quark_i2c_gpio.c | 2 +- >> include/linux/platform_data/gpio-dwapb.h | 2 +- >> 3 files changed, 39 insertions(+), 27 deletions(-) >> >> diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c >> index 597de1e..7a37c65 100644 >> --- a/drivers/gpio/gpio-dwapb.c >> +++ b/drivers/gpio/gpio-dwapb.c >> @@ -7,6 +7,7 @@ >> * >> * All enquiries to support@picochip.com >> */ >> +#include > > +#include instead (see above). > >> #include >> /* FIXME: for gpio_get_value(), replace this with direct register read */ >> #include > >> @@ -496,18 +492,27 @@ dwapb_gpio_get_pdata_of(struct device *dev) >> * Only port A can provide interrupts in all configurations of >> * the IP. >> */ >> - if (pp->idx == 0 && >> - of_property_read_bool(port_np, "interrupt-controller")) { >> - pp->irq = irq_of_parse_and_map(port_np, 0); >> + if (dev->of_node && pp->idx == 0 && >> + of_property_read_bool(to_of_node(fwnode), >> + "interrupt-controller")) { > >> + if (has_acpi_companion(dev) && pp->idx == 0) >> + pp->irq = platform_get_irq(to_platform_device(dev), 0); >> + > > To patch 2. > >> pp->irq_shared = false; >> pp->gpio_base = -1; > >> - pp->name = port_np->full_name; >> + >> + if (dev->of_node) >> + pp->name = to_of_node(fwnode)->full_name; >> + > > And here you have to provide something in case of default / built-in > device properties. Sorry, I'm not very clear here about the case of default / built-in device properties, can you give a example about what will the code look like ? > > >> + if (has_acpi_companion(dev)) >> + pp->name = acpi_dev_name(to_acpi_device_node(fwnode)); > > To patch 2. > >> } >> >> return pdata; > >> @@ -580,6 +585,12 @@ static const struct of_device_id dwapb_of_match[] = { >> }; >> MODULE_DEVICE_TABLE(of, dwapb_of_match); >> >> +static const struct acpi_device_id dwapb_acpi_match[] = { >> + {"HISI0181", 0}, >> + { } >> +}; >> +MODULE_DEVICE_TABLE(acpi, dwapb_acpi_match); >> + >> #ifdef CONFIG_PM_SLEEP >> static int dwapb_gpio_suspend(struct device *dev) >> { >> @@ -674,6 +685,7 @@ static struct platform_driver dwapb_gpio_driver = { >> .name = "gpio-dwapb", >> .pm = &dwapb_gpio_pm_ops, >> .of_match_table = of_match_ptr(dwapb_of_match), >> + .acpi_match_table = ACPI_PTR(dwapb_acpi_match), >> }, >> .probe = dwapb_gpio_probe, >> .remove = dwapb_gpio_remove, > > Ditto to the above hunks. >