public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Martin Kepplinger <martink@posteo.de>
To: Daniel Baluta <daniel.baluta@intel.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Matt Ranostaj <mranostay@gmail.com>,
	Haneen Mohammed <hamohammed.sa@gmail.com>,
	Darshana Padmadas <darshanapadmadas@gmail.com>,
	mfuzzey@parkeon.com,
	"octavian.purdila@intel.com" <octavian.purdila@intel.com>,
	Irina Tirdea <irina.tirdea@intel.com>,
	Cristina Georgiana Opriceana <cristina.opriceana@gmail.com>,
	Vladimir Barinov <vladimir.barinov@cogentembedded.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Subject: Re: extending /sys/.../iio:deviceX/in_accelX_power_mode
Date: Tue, 1 Mar 2016 10:47:34 +0100	[thread overview]
Message-ID: <56D56536.9060301@posteo.de> (raw)
In-Reply-To: <CAEnQRZCx7nFhJfA31mfdTicCppfh-n7usKucQx1dvjPuFNESsA@mail.gmail.com>

Am 2016-03-01 um 10:38 schrieb Daniel Baluta:
> On Tue, Mar 1, 2016 at 10:59 AM, Martin Kepplinger <martink@posteo.de> wrote:
>> Would it be ok, if adding in_accelX_power_mode to a driver, to extend it
>> so that in_accel_power_mode_available offers:
>>
>> low_noise low_power low_power_low_noise normal
>>
>> if there's a default "normal" mode, plus options to increase or decrease
>> oversampling / power consumption for my device?
>>
>> Specifically I'm unsure about "low_power_low_noise" being enough
>> user-friendly. The chip I work with just happens to offer these 4 modes.
>> Would you leave out "low_power_low_noise" and go with
>>
>> low_noise low_power normal
>>
>> or is it not even desired to add "normal" to the list?
>>
>> Although strictly not necessary, I would add any new addition to the
>> Documentation as well.
> 
> The problem with this is that is not uniform across sensors. What
> chip are you looking at?
> 
> For example INV6500 has:
> * sleep mode
> * standby mode
> * etc.
> 
> Daniel.
> 

I suspect these modes are something else. I'm looking at the mma8452
driver, and it also has "active" "standby" and "sleep" modes, but I'm
talking about different *power* (oversampling) configurations in
"active" mode, which is what said sysfs file is about.

But yes, it should be potenially uniform across sensors, which is why I
would probably only add "normal" to the list. At least I can imagine
that many devices have an oversampling mode called "normal".

A simple user interface is important so right now I think the best is to
leave it as it is, and not to add complexity and every possible option
for the user.

  reply	other threads:[~2016-03-01  9:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-01  8:59 extending /sys/.../iio:deviceX/in_accelX_power_mode Martin Kepplinger
2016-03-01  9:38 ` Daniel Baluta
2016-03-01  9:47   ` Martin Kepplinger [this message]
2016-03-01  9:53     ` Crt Mori
2016-03-01 10:07       ` Martin Kepplinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56D56536.9060301@posteo.de \
    --to=martink@posteo.de \
    --cc=cristina.opriceana@gmail.com \
    --cc=daniel.baluta@intel.com \
    --cc=darshanapadmadas@gmail.com \
    --cc=hamohammed.sa@gmail.com \
    --cc=irina.tirdea@intel.com \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mfuzzey@parkeon.com \
    --cc=mranostay@gmail.com \
    --cc=octavian.purdila@intel.com \
    --cc=vladimir.barinov@cogentembedded.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox