From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751979AbcCAW70 (ORCPT <rfc822;w@1wt.eu>);
	Tue, 1 Mar 2016 17:59:26 -0500
Received: from foss.arm.com ([217.140.101.70]:54912 "EHLO foss.arm.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751785AbcCAW7Y (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 1 Mar 2016 17:59:24 -0500
Subject: Re: [PATCH 7/8] ARM64: dts: amlogic: Extend GXBaby GIC node
To: =?UTF-8?Q?Andreas_F=c3=a4rber?= <afaerber@suse.de>,
        linux-meson@googlegroups.com
References: <1456789465-2962-1-git-send-email-afaerber@suse.de>
 <1456789465-2962-8-git-send-email-afaerber@suse.de>
 <56D57673.8030702@arm.com> <56D57A7F.5020806@suse.de>
 <56D58E88.2080700@arm.com> <56D61BE3.90505@suse.de>
Cc: Mark Rutland <mark.rutland@arm.com>,
        devicetree <devicetree@vger.kernel.org>,
        Matthias Brugger <mbrugger@suse.com>, Pawel Moll <pawel.moll@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Nicolas Saenz <nicolassaenzj@gmail.com>,
        Will Deacon <will.deacon@arm.com>, LKML <linux-kernel@vger.kernel.org>,
        Rob Herring <robh+dt@kernel.org>, Kumar Gala <galak@codeaurora.org>,
        Carlo Caione <carlo@caione.org>, linux-arm-kernel@lists.infradead.org
From: =?UTF-8?Q?Andr=c3=a9_Przywara?= <andre.przywara@arm.com>
Organization: ARM Ltd.
Message-ID: <56D61EA2.8090103@arm.com>
Date: Tue, 1 Mar 2016 22:58:42 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.4.0
MIME-Version: 1.0
In-Reply-To: <56D61BE3.90505@suse.de>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 01/03/16 22:46, Andreas Färber wrote:
> Am 01.03.2016 um 13:43 schrieb Andre Przywara:
>> On 01/03/16 11:18, Andreas Färber wrote:
>>> Am 01.03.2016 um 12:01 schrieb Andre Przywara:
>>>> On 29/02/16 23:44, Andreas Färber wrote:
>>>>>  			reg = <0x0 0xc4301000 0 0x1000>,
>>>>> -			      <0x0 0xc4302000 0 0x0100>;
>>>>> +			      <0x0 0xc4302000 0 0x0100>,
>>>>
>>>> Please use 0x2000 for the size here. I guess this is really the GIC-400
>>>> from ARM, and in this case this is the right size, [1] is the reference
>>>> here. This will enable EOI mode 1 for KVM.
>>>
>>> Will test later.
>>>
>>> Is there any easy way to find out whether or not this is that GIC-400?
>>
>> If you can read registers: GICD_IIDR and PIDRx have some info:
>> http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.ddi0471b/CHDIFAEE.html
>> So if your U-Boot for instance supports md, a dump of:
>> md.l c4301008 1
>> md.l c4301fd0 30
>>
>> would help to identify the GIC.
> 
> gxb_p200_v1#md.l c4301008 1
> c4301008: 0200143b                               ;...
> gxb_p200_v1#md.l c4301fd0 30
> c4301fd0: 00000004 00000000 00000000 00000000    ................
> c4301fe0: 00000090 000000b4 0000002b 00000000    ........+.......
> c4301ff0: 0000000d 000000f0 00000005 000000b1    ................
> c4302000: 00000060 000000f0 00000003 000003ff    `...............
> c4302010: 00000000 000000ff 000003ff 00000000    ................
> c4302020: 00000000 00000000 00000000 00000000    ................
> c4302030: 00000000 00000000 00000000 00000000    ................
> c4302040: 00000000 00000000 00000000 00000000    ................
> c4302050: 00000000 00000000 00000000 00000000    ................
> c4302060: 00000000 00000000 00000000 00000000    ................
> c4302070: 00000000 00000000 00000000 00000000    ................
> c4302080: 00000000 00000000 00000000 00000000    ................

Yes, that matches exactly the values from the GIC-400 TRM.

Thanks!
Andre.