From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Laxman Dewangan <ldewangan@nvidia.com>,
alexandre.belloni@free-electrons.com, a.zummo@towertech.it
Cc: cw00.choi@samsung.com, rtc-linux@googlegroups.com,
linux-kernel@vger.kernel.org, javier@osg.samsung.com,
rklein@nvidia.com
Subject: Re: [PATCH V2 1/2] rtc: max77686: Add support for MAX20024/MAX77620 RTC IP
Date: Wed, 02 Mar 2016 17:54:36 +0900 [thread overview]
Message-ID: <56D6AA4C.10203@samsung.com> (raw)
In-Reply-To: <1456907785-11942-1-git-send-email-ldewangan@nvidia.com>
On 02.03.2016 17:36, Laxman Dewangan wrote:
> Maxim Semiconductor's PMIC MAX77686 has RTC IP which is
> reused in the MAX77620/MAX20024 PMICs.
>
> Add support for these devices in MAX77686 RTC driver. This
> device does not have RTC alarm pending status outside of
> RTC IP. The RTC IP is having separate I2C address for its
> register access.
>
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> ---
> Changes from V1:
> - Remove macro and use value directly.
> - Handle error returned from platform_get_irq()
> - Remove compatible for max77620.
> - Cleanup like indenting.
>
> drivers/rtc/Kconfig | 4 ++--
> drivers/rtc/rtc-max77686.c | 47 +++++++++++++++++++++++++++++++++++++++++++---
> 2 files changed, 46 insertions(+), 5 deletions(-)
>
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Best regards,
Krzysztof
next prev parent reply other threads:[~2016-03-02 8:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-02 8:36 [PATCH V2 1/2] rtc: max77686: Add support for MAX20024/MAX77620 RTC IP Laxman Dewangan
2016-03-02 8:36 ` [PATCH V2 2/2] rtc: max77686: Use REGMAP_IRQ_REG for regmap-rtc-irqs initialisation Laxman Dewangan
2016-03-02 8:55 ` Krzysztof Kozlowski
2016-03-02 8:54 ` Krzysztof Kozlowski [this message]
2016-03-02 23:33 ` [PATCH V2 1/2] rtc: max77686: Add support for MAX20024/MAX77620 RTC IP Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D6AA4C.10203@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=cw00.choi@samsung.com \
--cc=javier@osg.samsung.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rklein@nvidia.com \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox