From: Michal Simek <michal.simek@xilinx.com>
To: Arnd Bergmann <arnd@arndb.de>, Michal Simek <michal.simek@xilinx.com>
Cc: "Anurag Kumar Vulisha" <anuragku@xilinx.com>,
"Rob Herring" <robh@kernel.org>,
"Sören Brinkmann" <soren.brinkmann@xilinx.com>,
"pawel.moll@arm.com" <pawel.moll@arm.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>,
"galak@codeaurora.org" <galak@codeaurora.org>,
"tj@kernel.org" <tj@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
"Anirudha Sarangi" <anirudh@xilinx.com>,
"Srikanth Vemula" <svemula@xilinx.com>,
"Punnaiah Choudary Kalluri" <punnaia@xilinx.com>
Subject: Re: [RFC PATCH] drivers: ata: Read Rx water mark value from device-tree
Date: Wed, 2 Mar 2016 12:51:44 +0100 [thread overview]
Message-ID: <56D6D3D0.9030408@xilinx.com> (raw)
In-Reply-To: <1798710.nJonRpmlxx@wuerfel>
On 2.3.2016 12:42, Arnd Bergmann wrote:
> On Wednesday 02 March 2016 10:27:51 Michal Simek wrote:
>>
>> No problem with default value in driver. Something has to be setup.
>> Reset value based on reg spec I was checking is 0x20. Based on our
>> testing we saw some issues that's why 0x40 was setup as default value.
>> There is a need to be able to configure this value for example for
>> testing different values that's why I think module parameter should be
>> the right way to go.
>
> I don't object to the module parameter, but I don't understand how important
> that kind of testing is to normal users. Who would set it, aside from
> the person writing that driver to come up with the correct default?
>
>> If this should be DT parameters there should be different ceva IP which
>> allows different fifo size and different watermark level to be setup by
>> user.
>>
>> What do you think? Does it sound reasonable.
>
> Having a property for the actual hardware fifo size once you get
> different implementations seems like the correct approach, but it's
> moot as long as all implementations are hardwired to 128 entries.
yep right now and we don't know what can happen in future. I just wanted
to point to example where this property can be specified or wired to
particular compatible string.
Anurag: Please make it as module parameter instead of DT parameter.
Thanks,
Michal
prev parent reply other threads:[~2016-03-02 12:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-20 13:18 [RFC PATCH] drivers: ata: Read Rx water mark value from device-tree Anurag Kumar Vulisha
2016-02-20 22:34 ` Arnd Bergmann
2016-02-22 10:53 ` Anurag Kumar Vulisha
2016-02-22 15:19 ` Arnd Bergmann
2016-02-23 5:58 ` Anurag Kumar Vulisha
2016-02-23 10:20 ` Arnd Bergmann
2016-02-23 15:29 ` Anurag Kumar Vulisha
2016-02-23 19:29 ` Rob Herring
2016-02-26 13:48 ` Anurag Kumar Vulisha
2016-03-02 5:53 ` Anurag Kumar Vulisha
2016-03-02 8:05 ` Michal Simek
2016-03-02 9:11 ` Arnd Bergmann
2016-03-02 9:27 ` Michal Simek
2016-03-02 11:42 ` Arnd Bergmann
2016-03-02 11:51 ` Michal Simek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D6D3D0.9030408@xilinx.com \
--to=michal.simek@xilinx.com \
--cc=anirudh@xilinx.com \
--cc=anuragku@xilinx.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=punnaia@xilinx.com \
--cc=robh@kernel.org \
--cc=soren.brinkmann@xilinx.com \
--cc=svemula@xilinx.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox