public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Chanwoo Choi <cw00.choi@samsung.com>
To: Lu Baolu <baolu.lu@linux.intel.com>,
	Felipe Balbi <balbi@kernel.org>,
	Mathias Nyman <mathias.nyman@intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Lee Jones <lee.jones@linaro.org>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/7] extcon: usb-gpio: add device binding for platform device
Date: Thu, 03 Mar 2016 16:24:16 +0900	[thread overview]
Message-ID: <56D7E6A0.40103@samsung.com> (raw)
In-Reply-To: <1456987064-3365-2-git-send-email-baolu.lu@linux.intel.com>

Hell Lu,

On 2016년 03월 03일 15:37, Lu Baolu wrote:
> This is needed to handle the GPIO connected USB ID pin found on
> Intel Baytrail devices.
> 
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
> Reviewed-by: Felipe Balbi <balbi@kernel.org>
> ---
>  drivers/extcon/extcon-usb-gpio.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/extcon/extcon-usb-gpio.c b/drivers/extcon/extcon-usb-gpio.c
> index 2b2fecf..af9c8b0 100644
> --- a/drivers/extcon/extcon-usb-gpio.c
> +++ b/drivers/extcon/extcon-usb-gpio.c
> @@ -206,6 +206,12 @@ static const struct of_device_id usb_extcon_dt_match[] = {
>  };
>  MODULE_DEVICE_TABLE(of, usb_extcon_dt_match);
>  
> +static const struct platform_device_id usb_extcon_platform_ids[] = {
> +	{ .name = "extcon-usb-gpio", },
> +	{ /* sentinel */ }
> +};
> +MODULE_DEVICE_TABLE(platform, usb_extcon_platform_ids);
> +
>  static struct platform_driver usb_extcon_driver = {
>  	.probe		= usb_extcon_probe,
>  	.remove		= usb_extcon_remove,
> @@ -214,6 +220,7 @@ static struct platform_driver usb_extcon_driver = {
>  		.pm	= &usb_extcon_pm_ops,
>  		.of_match_table = usb_extcon_dt_match,
>  	},
> +	.id_table = usb_extcon_platform_ids,
>  };
>  
>  module_platform_driver(usb_extcon_driver);
> 

Looks good to me.

Acked-by: Chanwoo Choi <cw00.choi@samsung.com>

Best Regards,
Chanwoo Choi

  reply	other threads:[~2016-03-03  7:24 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-03  6:37 [PATCH 0/7] usb: add support for Intel dual role port mux Lu Baolu
2016-03-03  6:37 ` [PATCH 1/7] extcon: usb-gpio: add device binding for platform device Lu Baolu
2016-03-03  7:24   ` Chanwoo Choi [this message]
2016-03-03  7:35     ` Lu Baolu
2016-03-03  6:37 ` [PATCH 2/7] extcon: usb-gpio: add support for ACPI gpio interface Lu Baolu
2016-03-03  7:24   ` Chanwoo Choi
2016-03-03  7:35     ` Lu Baolu
2016-03-03  6:37 ` [PATCH 3/7] usb: misc: add common code for Intel dual role port mux Lu Baolu
2016-03-03 16:10   ` Greg Kroah-Hartman
2016-03-04  1:11     ` Lu Baolu
2016-03-03 16:15   ` Greg Kroah-Hartman
2016-03-04  1:25     ` Lu Baolu
2016-03-03  6:37 ` [PATCH 4/7] usb: misc: add driver for Intel gpio controlled " Lu Baolu
2016-03-03  8:16   ` [PATCH] usb: misc: fix platform_no_drv_owner.cocci warnings kbuild test robot
2016-03-03  8:16   ` [PATCH 4/7] usb: misc: add driver for Intel gpio controlled port mux kbuild test robot
2016-03-03  6:37 ` [PATCH 5/7] usb: misc: add driver for Intel drcfg " Lu Baolu
2016-03-03 15:20   ` kbuild test robot
2016-03-03 16:12   ` Greg Kroah-Hartman
2016-03-04  1:41     ` Lu Baolu
2016-03-03 16:14   ` Greg Kroah-Hartman
2016-03-04  1:38     ` Lu Baolu
2016-03-04  1:44       ` Greg Kroah-Hartman
2016-03-04  1:58         ` Lu Baolu
2016-03-03  6:37 ` [PATCH 6/7] usb: pci-quirks: add Intel USB drcfg mux device Lu Baolu
2016-03-03  6:37 ` [PATCH 7/7] mfd: intel_vuport: Add Intel virtual USB port MFD Driver Lu Baolu
2016-03-03  8:16   ` kbuild test robot
2016-03-03  8:16   ` [PATCH] mfd: intel_vuport: fix platform_no_drv_owner.cocci warnings kbuild test robot
2016-03-03 11:35   ` [PATCH 7/7] mfd: intel_vuport: Add Intel virtual USB port MFD Driver kbuild test robot
2016-03-03 17:26   ` kbuild test robot
2016-03-03 19:57   ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56D7E6A0.40103@samsung.com \
    --to=cw00.choi@samsung.com \
    --cc=balbi@kernel.org \
    --cc=baolu.lu@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    --cc=myungjoo.ham@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox