From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755178AbcCCHYU (ORCPT ); Thu, 3 Mar 2016 02:24:20 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:42839 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751390AbcCCHYS (ORCPT ); Thu, 3 Mar 2016 02:24:18 -0500 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee690-f79646d000001316-75-56d7e6a0cfa5 Content-transfer-encoding: 8BIT Message-id: <56D7E6A0.40103@samsung.com> Date: Thu, 03 Mar 2016 16:24:16 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Lu Baolu , Felipe Balbi , Mathias Nyman , Greg Kroah-Hartman , Lee Jones , Heikki Krogerus , MyungJoo Ham Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/7] extcon: usb-gpio: add device binding for platform device References: <1456987064-3365-1-git-send-email-baolu.lu@linux.intel.com> <1456987064-3365-2-git-send-email-baolu.lu@linux.intel.com> In-reply-to: <1456987064-3365-2-git-send-email-baolu.lu@linux.intel.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrIIsWRmVeSWpSXmKPExsWyRsSkQHfBs+thBqtuKloca3vCbrF54lY2 i+bF69ksulbvZLG4//Uoo8XlXXPYLBYta2W2aN40hdXiduMKNgdOj8V7XjJ5bFrVyeZx59oe No95JwM99s9dw+7Rt2UVo8fnTXIB7FFcNimpOZllqUX6dglcGd/mXmct+MFV0fWjkaWB8TdH FyMnh4SAicSnVQ0sELaYxIV769m6GLk4hARWMEo8v9IF5HCAFT24lggRX8ooMX36alaQBl4B QYkfk++xgNQwC8hLHLmUDRJmFlCXmDRvETOILSTwgFHiw3awEl4BDYmZ63RAwiwCqhLT3zex g9hsAloS+1/cANskKhAh0X2iEiQsIrCKSaJ9ET/EcGuJn/vyQcLCAsESRxvXskMc08oo0bH3 LCNIglPAQ+Lo24VgCQmBr+wSh38vY4PYJSDxbfIhFohPZCU2HWCG+FZS4uCKGywTGMVmIfll FsIvs5D8soCReRWjaGpBckFxUnqRiV5xYm5xaV66XnJ+7iZGYEye/vdswg7GewesDzEKcDAq 8fDeaLgeJsSaWFZcmXuI0RToiInMUqLJ+cDIzyuJNzQ2M7IwNTE1NjK3NFMS530t9TNYSCA9 sSQ1OzW1ILUovqg0J7X4ECMTB6dUA6PH30AZRtmYF2sjM096/L/0ITFq/ZfMibknHXISsiVr 9lyTP7rh58ndxdeY9p9fMl1yxge5d2GqBuEFCv9urnr86uBdgY0+nuVTXOJ0VQ3TJt248/ze /cm782f+lXSKDdnLERRY9FJcSLT0VvD0RK2lJpHmn5tabm95/tVgTVBUj9FDrqBHnx8psRRn JBpqMRcVJwIA3whauMQCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrHIsWRmVeSWpSXmKPExsVy+t9jAd0Fz66HGUzeKWNxrO0Ju8XmiVvZ LJoXr2ez6Fq9k8Xi/tejjBaXd81hs1i0rJXZonnTFFaL240r2Bw4PRbvecnksWlVJ5vHnWt7 2DzmnQz02D93DbtH35ZVjB6fN8kFsEc1MNpkpCampBYppOYl56dk5qXbKnkHxzvHm5oZGOoa WlqYKynkJeam2iq5+AToumXmAJ2mpFCWmFMKFApILC5W0rfDNCE0xE3XAqYxQtc3JAiux8gA DSSsYcz4Nvc6a8EProquH40sDYy/OboYOTgkBEwkHlxL7GLkBDLFJC7cW8/WxcjFISSwlFFi +vTVrCAJXgFBiR+T77GA1DMLyEscuZQNEmYWUJeYNG8RM4gtJPCAUeLDdrASXgENiZnrdEDC LAKqEtPfN7GD2GwCWhL7X9xgAykRFYiQ6D5RCRIWEVjFJNG+iB9iuLXEz335IGFhgWCJo41r 2SGOaWWU6Nh7lhEkwSngIXH07UL2CYwCs5DcNgvhtllIblvAyLyKUSK1ILmgOCk91ygvtVyv ODG3uDQvXS85P3cTIzjun0nvYDy8y/0QowAHoxIP742G62FCrIllxZW5hxglOJiVRHiPPwEK 8aYkVlalFuXHF5XmpBYfYjQFem8is5Rocj4wJeWVxBsam5gZWRqZG1oYGZsrifM+/r8uTEgg PbEkNTs1tSC1CKaPiYNTqoHR8k629GEdC93QZJfrIuqXNEPnTzxtJbgh3OVl6pttJvuPXFzj sSxuw7GQ6wLXvl+XkGrS4TQ6aLnfi+NOo3b0d3bLStbdnZkv39z+PPm1QU+hXfb7t6vcWBj3 6U9YyNwbO73GLKk2b7r7h0O2wh1H5ld3P1/YfcF3Rsvjb2e9BPK7XTzKG1qVWIozEg21mIuK EwGkKOZlEQMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hell Lu, On 2016년 03월 03일 15:37, Lu Baolu wrote: > This is needed to handle the GPIO connected USB ID pin found on > Intel Baytrail devices. > > Signed-off-by: Lu Baolu > Reviewed-by: Felipe Balbi > --- > drivers/extcon/extcon-usb-gpio.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/extcon/extcon-usb-gpio.c b/drivers/extcon/extcon-usb-gpio.c > index 2b2fecf..af9c8b0 100644 > --- a/drivers/extcon/extcon-usb-gpio.c > +++ b/drivers/extcon/extcon-usb-gpio.c > @@ -206,6 +206,12 @@ static const struct of_device_id usb_extcon_dt_match[] = { > }; > MODULE_DEVICE_TABLE(of, usb_extcon_dt_match); > > +static const struct platform_device_id usb_extcon_platform_ids[] = { > + { .name = "extcon-usb-gpio", }, > + { /* sentinel */ } > +}; > +MODULE_DEVICE_TABLE(platform, usb_extcon_platform_ids); > + > static struct platform_driver usb_extcon_driver = { > .probe = usb_extcon_probe, > .remove = usb_extcon_remove, > @@ -214,6 +220,7 @@ static struct platform_driver usb_extcon_driver = { > .pm = &usb_extcon_pm_ops, > .of_match_table = usb_extcon_dt_match, > }, > + .id_table = usb_extcon_platform_ids, > }; > > module_platform_driver(usb_extcon_driver); > Looks good to me. Acked-by: Chanwoo Choi Best Regards, Chanwoo Choi