From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756257AbcCCHYp (ORCPT ); Thu, 3 Mar 2016 02:24:45 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:34806 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756051AbcCCHYm (ORCPT ); Thu, 3 Mar 2016 02:24:42 -0500 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee68d-f79646d000001355-e9-56d7e6b3f8fd Content-transfer-encoding: 8BIT Message-id: <56D7E6B3.20004@samsung.com> Date: Thu, 03 Mar 2016 16:24:35 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Lu Baolu , Felipe Balbi , Mathias Nyman , Greg Kroah-Hartman , Lee Jones , Heikki Krogerus , MyungJoo Ham Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/7] extcon: usb-gpio: add support for ACPI gpio interface References: <1456987064-3365-1-git-send-email-baolu.lu@linux.intel.com> <1456987064-3365-3-git-send-email-baolu.lu@linux.intel.com> In-reply-to: <1456987064-3365-3-git-send-email-baolu.lu@linux.intel.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrMIsWRmVeSWpSXmKPExsWyRsSkWHfzs+thBg1vbCyOtT1ht9g8cSub RfPi9WwWXat3sljc/3qU0eLyrjlsFouWtTJbNG+awmpxu3EFmwOnx+I9L5k8Nq3qZPO4c20P m8e8k4Ee++euYffo27KK0ePzJrkA9igum5TUnMyy1CJ9uwSujAlzLjEX3OSoOPDgEksDYwd7 FyMHh4SAicSJrZpdjJxAppjEhXvr2boYuTiEBFYwSryZ8ZYJImEisfr6P1aIxFJGid/znoMl eAUEJX5MvscCMohZQF7iyKVskDCzgLrEpHmLmCHqHzBKHL/cxwJRryEx51s/K4jNIqAq0bpx FVicTUBLYv+LG2wgc0QFIiS6T1SChEUEVjFJtC/ihxhvLfFzXz5IWFjAT6Jp6yImiPGtjBK9 O/rAzuEU8JA4snAB2AMSAh/ZJTruHGaG2CUg8W3yIRaIh2UlNh1ghvhLUuLgihssExjFZiH5 ZhbCN7OQfLOAkXkVo2hqQXJBcVJ6kaFecWJucWleul5yfu4mRmBcnv73rHcH4+0D1ocYBTgY lXh4bzRcDxNiTSwrrsw9xGgKdMREZinR5Hxg9OeVxBsamxlZmJqYGhuZW5opifMqSv0MFhJI TyxJzU5NLUgtii8qzUktPsTIxMEp1cA4wXxJ1C+/P4rcFQwlJetdJB+7Ps+xXM10UP930tdv Lkkqq012bLxh23HD6XbDWo2FWSLz3v7fvuLthPkcsdP4Zlr1NrLey7ZMeHFuQvDD1+8r1X7N 0nXgkehoUZse4J4ReWT+k2+7b9cZ3yt5fe9O550t++98E3y58rbN30v/64VOlN89o3R3oxJL cUaioRZzUXEiANxydA7GAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpkleLIzCtJLcpLzFFi42I5/e+xgO7mZ9fDDN5MMLM41vaE3WLzxK1s Fs2L17NZdK3eyWJx/+tRRovLu+awWSxa1sps0bxpCqvF7cYVbA6cHov3vGTy2LSqk83jzrU9 bB7zTgZ67J+7ht2jb8sqRo/Pm+QC2KMaGG0yUhNTUosUUvOS81My89JtlbyD453jTc0MDHUN LS3MlRTyEnNTbZVcfAJ03TJzgE5TUihLzCkFCgUkFhcr6dthmhAa4qZrAdMYoesbEgTXY2SA BhLWMGZMmHOJueAmR8WBB5dYGhg72LsYOTkkBEwkVl//xwphi0lcuLeerYuRi0NIYCmjxO95 z5lAErwCghI/Jt9j6WLk4GAWkJc4cikbJMwsoC4xad4iZoj6B4wSxy/3sUDUa0jM+dYPNpRF QFWideMqsDibgJbE/hc32EDmiApESHSfqAQJiwisYpJoX8QPMd5a4ue+fJCwsICfRNPWRUwQ 41sZJXp39IGdwyngIXFk4QK2CYwCs5BcNwvhullIrlvAyLyKUSK1ILmgOCk91zAvtVyvODG3 uDQvXS85P3cTIzj6n0ntYDy4y/0QowAHoxIP742G62FCrIllxZW5hxglOJiVRHiPPwEK8aYk VlalFuXHF5XmpBYfYjQFem8is5Rocj4wMeWVxBsam5gZWRqZG1oYGZsrifM+/r8uTEggPbEk NTs1tSC1CKaPiYNTqoFxrvxfTcaQrccsmIy43qxdoTXvJaudXUeeV/O3eVv1uVYd7au06s3n 10mM+O3HsTKkYuPKM+ELFasrg1T+tIsGcYRO3XVXY8K+6X3pvMXzf7WF7V7+4QOfzXl+1buL Pk3qOOwxeee+nosuCULvQ43mN8379l+5fULVurXWX9Q3/JuwJ2hN/iUeJZbijERDLeai4kQA C8GashQDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Lu, On 2016년 03월 03일 15:37, Lu Baolu wrote: > GPIO resource could be retrieved through APCI as well. > > Signed-off-by: Lu Baolu > Reviewed-by: Felipe Balbi > --- > drivers/extcon/extcon-usb-gpio.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/extcon/extcon-usb-gpio.c b/drivers/extcon/extcon-usb-gpio.c > index af9c8b0..472c431 100644 > --- a/drivers/extcon/extcon-usb-gpio.c > +++ b/drivers/extcon/extcon-usb-gpio.c > @@ -26,6 +26,7 @@ > #include > #include > #include > +#include > > #define USB_GPIO_DEBOUNCE_MS 20 /* ms */ > > @@ -91,7 +92,7 @@ static int usb_extcon_probe(struct platform_device *pdev) > struct usb_extcon_info *info; > int ret; > > - if (!np) > + if (!np && !ACPI_HANDLE(dev)) > return -EINVAL; > > info = devm_kzalloc(&pdev->dev, sizeof(*info), GFP_KERNEL); > Looks good to me. Acked-by: Chanwoo Choi Best Regards, Chanwoo Choi