* [PATCH] nvmem: Fix build error of missing devm_ioremap_resource on UM
@ 2016-03-03 8:33 Krzysztof Kozlowski
2016-03-03 9:09 ` Srinivas Kandagatla
0 siblings, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2016-03-03 8:33 UTC (permalink / raw)
To: Srinivas Kandagatla, Maxime Ripard, linux-kernel; +Cc: Krzysztof Kozlowski
The devres.o gets linked if HAS_IOMEM is present so on ARCH=um
allyesconfig (COMPILE_TEST) failed on many files with:
drivers/built-in.o: In function `qfprom_probe':
qfprom.c:(.text+0x4c5bcb): undefined reference to `devm_ioremap_resource'
The users of devm_ioremap_resource() which are compile-testable should
depend on HAS_IOMEM.
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
drivers/nvmem/Kconfig | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/nvmem/Kconfig b/drivers/nvmem/Kconfig
index 5bd18cc1a69c..0843e4fd7e7a 100644
--- a/drivers/nvmem/Kconfig
+++ b/drivers/nvmem/Kconfig
@@ -27,7 +27,7 @@ config NVMEM_IMX_OCOTP
config NVMEM_LPC18XX_EEPROM
tristate "NXP LPC18XX EEPROM Memory Support"
- depends on ARCH_LPC18XX || COMPILE_TEST
+ depends on ARCH_LPC18XX || COMPILE_TEST && HAS_IOMEM
help
Say Y here to include support for NXP LPC18xx EEPROM memory found in
NXP LPC185x/3x and LPC435x/3x/2x/1x devices.
@@ -36,7 +36,7 @@ config NVMEM_LPC18XX_EEPROM
config NVMEM_MXS_OCOTP
tristate "Freescale MXS On-Chip OTP Memory Support"
- depends on ARCH_MXS || COMPILE_TEST
+ depends on ARCH_MXS || COMPILE_TEST && HAS_IOMEM
help
If you say Y here, you will get readonly access to the
One Time Programmable memory pages that are stored
@@ -47,7 +47,7 @@ config NVMEM_MXS_OCOTP
config MTK_EFUSE
tristate "Mediatek SoCs EFUSE support"
- depends on ARCH_MEDIATEK || COMPILE_TEST
+ depends on ARCH_MEDIATEK || COMPILE_TEST && HAS_IOMEM
select REGMAP_MMIO
help
This is a driver to access hardware related data like sensor
@@ -58,7 +58,7 @@ config MTK_EFUSE
config QCOM_QFPROM
tristate "QCOM QFPROM Support"
- depends on ARCH_QCOM || COMPILE_TEST
+ depends on ARCH_QCOM || COMPILE_TEST && HAS_IOMEM
select REGMAP_MMIO
help
Say y here to enable QFPROM support. The QFPROM provides access
@@ -69,7 +69,7 @@ config QCOM_QFPROM
config ROCKCHIP_EFUSE
tristate "Rockchip eFuse Support"
- depends on ARCH_ROCKCHIP || COMPILE_TEST
+ depends on ARCH_ROCKCHIP || COMPILE_TEST && HAS_IOMEM
help
This is a simple drive to dump specified values of Rockchip SoC
from eFuse, such as cpu-leakage.
@@ -90,7 +90,7 @@ config NVMEM_SUNXI_SID
config NVMEM_VF610_OCOTP
tristate "VF610 SoC OCOTP support"
- depends on SOC_VF610 || COMPILE_TEST
+ depends on SOC_VF610 || COMPILE_TEST && HAS_IOMEM
help
This is a driver for the 'OCOTP' peripheral available on Vybrid
devices like VF5xx and VF6xx.
--
2.5.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] nvmem: Fix build error of missing devm_ioremap_resource on UM
2016-03-03 8:33 [PATCH] nvmem: Fix build error of missing devm_ioremap_resource on UM Krzysztof Kozlowski
@ 2016-03-03 9:09 ` Srinivas Kandagatla
2016-03-03 11:51 ` Krzysztof Kozlowski
0 siblings, 1 reply; 4+ messages in thread
From: Srinivas Kandagatla @ 2016-03-03 9:09 UTC (permalink / raw)
To: Krzysztof Kozlowski, Maxime Ripard, linux-kernel
On 03/03/16 08:33, Krzysztof Kozlowski wrote:
> The devres.o gets linked if HAS_IOMEM is present so on ARCH=um
> allyesconfig (COMPILE_TEST) failed on many files with:
>
> drivers/built-in.o: In function `qfprom_probe':
> qfprom.c:(.text+0x4c5bcb): undefined reference to `devm_ioremap_resource'
>
> The users of devm_ioremap_resource() which are compile-testable should
> depend on HAS_IOMEM.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
> drivers/nvmem/Kconfig | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
There is exactly same patch in the queue [1]
Could you send a patch just for MTK, others are taken care by [1]
[1]: http://lkml.iu.edu/hypermail/linux/kernel/1601.3/01577.html
thanks,
srini
> diff --git a/drivers/nvmem/Kconfig b/drivers/nvmem/Kconfig
> index 5bd18cc1a69c..0843e4fd7e7a 100644
> --- a/drivers/nvmem/Kconfig
> +++ b/drivers/nvmem/Kconfig
> @@ -27,7 +27,7 @@ config NVMEM_IMX_OCOTP
>
> config NVMEM_LPC18XX_EEPROM
> tristate "NXP LPC18XX EEPROM Memory Support"
> - depends on ARCH_LPC18XX || COMPILE_TEST
> + depends on ARCH_LPC18XX || COMPILE_TEST && HAS_IOMEM
> help
> Say Y here to include support for NXP LPC18xx EEPROM memory found in
> NXP LPC185x/3x and LPC435x/3x/2x/1x devices.
> @@ -36,7 +36,7 @@ config NVMEM_LPC18XX_EEPROM
>
> config NVMEM_MXS_OCOTP
> tristate "Freescale MXS On-Chip OTP Memory Support"
> - depends on ARCH_MXS || COMPILE_TEST
> + depends on ARCH_MXS || COMPILE_TEST && HAS_IOMEM
> help
> If you say Y here, you will get readonly access to the
> One Time Programmable memory pages that are stored
> @@ -47,7 +47,7 @@ config NVMEM_MXS_OCOTP
>
> config MTK_EFUSE
> tristate "Mediatek SoCs EFUSE support"
> - depends on ARCH_MEDIATEK || COMPILE_TEST
> + depends on ARCH_MEDIATEK || COMPILE_TEST && HAS_IOMEM
> select REGMAP_MMIO
> help
> This is a driver to access hardware related data like sensor
> @@ -58,7 +58,7 @@ config MTK_EFUSE
>
> config QCOM_QFPROM
> tristate "QCOM QFPROM Support"
> - depends on ARCH_QCOM || COMPILE_TEST
> + depends on ARCH_QCOM || COMPILE_TEST && HAS_IOMEM
> select REGMAP_MMIO
> help
> Say y here to enable QFPROM support. The QFPROM provides access
> @@ -69,7 +69,7 @@ config QCOM_QFPROM
>
> config ROCKCHIP_EFUSE
> tristate "Rockchip eFuse Support"
> - depends on ARCH_ROCKCHIP || COMPILE_TEST
> + depends on ARCH_ROCKCHIP || COMPILE_TEST && HAS_IOMEM
> help
> This is a simple drive to dump specified values of Rockchip SoC
> from eFuse, such as cpu-leakage.
> @@ -90,7 +90,7 @@ config NVMEM_SUNXI_SID
>
> config NVMEM_VF610_OCOTP
> tristate "VF610 SoC OCOTP support"
> - depends on SOC_VF610 || COMPILE_TEST
> + depends on SOC_VF610 || COMPILE_TEST && HAS_IOMEM
> help
> This is a driver for the 'OCOTP' peripheral available on Vybrid
> devices like VF5xx and VF6xx.
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] nvmem: Fix build error of missing devm_ioremap_resource on UM
2016-03-03 9:09 ` Srinivas Kandagatla
@ 2016-03-03 11:51 ` Krzysztof Kozlowski
0 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2016-03-03 11:51 UTC (permalink / raw)
To: Srinivas Kandagatla; +Cc: Maxime Ripard, linux-kernel, Krzysztof Kozlowski
2016-03-03 18:09 GMT+09:00 Srinivas Kandagatla <srinivas.kandagatla@linaro.org>:
>
>
> On 03/03/16 08:33, Krzysztof Kozlowski wrote:
>>
>> The devres.o gets linked if HAS_IOMEM is present so on ARCH=um
>> allyesconfig (COMPILE_TEST) failed on many files with:
>>
>> drivers/built-in.o: In function `qfprom_probe':
>> qfprom.c:(.text+0x4c5bcb): undefined reference to `devm_ioremap_resource'
>>
>> The users of devm_ioremap_resource() which are compile-testable should
>> depend on HAS_IOMEM.
>>
>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>> ---
>> drivers/nvmem/Kconfig | 12 ++++++------
>> 1 file changed, 6 insertions(+), 6 deletions(-)
>>
> There is exactly same patch in the queue [1]
>
>
> Could you send a patch just for MTK, others are taken care by [1]
>
> [1]: http://lkml.iu.edu/hypermail/linux/kernel/1601.3/01577.html
>
Of course, I will send updated patchset.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] nvmem: Fix build error of missing devm_ioremap_resource on UM
@ 2016-03-31 10:07 Srinivas Kandagatla
0 siblings, 0 replies; 4+ messages in thread
From: Srinivas Kandagatla @ 2016-03-31 10:07 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Maxime Ripard, linux-kernel, Srinivas Kandagatla, k.kozlowski
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
The devres.o gets linked if HAS_IOMEM is present so on ARCH=um
allyesconfig (COMPILE_TEST) failed on many files with:
drivers/built-in.o: In function `mtk_thermal_probe':
mtk_thermal.c:(.text+0x394618): undefined reference to `devm_ioremap_resource'
The users of devm_ioremap_resource() which are compile-testable should
depend on HAS_IOMEM.
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
Hi Greg,
Can you please take this fix in next possible rc.
Thanks,
srini
drivers/nvmem/Kconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/nvmem/Kconfig b/drivers/nvmem/Kconfig
index ca52952..9c0c59d 100644
--- a/drivers/nvmem/Kconfig
+++ b/drivers/nvmem/Kconfig
@@ -28,6 +28,7 @@ config NVMEM_IMX_OCOTP
config NVMEM_LPC18XX_EEPROM
tristate "NXP LPC18XX EEPROM Memory Support"
depends on ARCH_LPC18XX || COMPILE_TEST
+ depends on HAS_IOMEM
help
Say Y here to include support for NXP LPC18xx EEPROM memory found in
NXP LPC185x/3x and LPC435x/3x/2x/1x devices.
@@ -49,6 +50,7 @@ config NVMEM_MXS_OCOTP
config MTK_EFUSE
tristate "Mediatek SoCs EFUSE support"
depends on ARCH_MEDIATEK || COMPILE_TEST
+ depends on HAS_IOMEM
select REGMAP_MMIO
help
This is a driver to access hardware related data like sensor
--
2.5.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-03-31 10:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-03 8:33 [PATCH] nvmem: Fix build error of missing devm_ioremap_resource on UM Krzysztof Kozlowski
2016-03-03 9:09 ` Srinivas Kandagatla
2016-03-03 11:51 ` Krzysztof Kozlowski
-- strict thread matches above, loose matches on Subject: below --
2016-03-31 10:07 Srinivas Kandagatla
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox