From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932469AbcCCO5Y (ORCPT ); Thu, 3 Mar 2016 09:57:24 -0500 Received: from mail-wm0-f41.google.com ([74.125.82.41]:33148 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757017AbcCCO5U (ORCPT ); Thu, 3 Mar 2016 09:57:20 -0500 Subject: Re: [PATCH 03/17] dt-bindings: Add PLX Technology RPS IRQ Controller bindings To: Andrew Lunn References: <1457005210-18485-1-git-send-email-narmstrong@baylibre.com> <1457005210-18485-4-git-send-email-narmstrong@baylibre.com> <20160303145348.GI15541@lunn.ch> Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org From: Neil Armstrong Organization: Baylibre Message-ID: <56D850C6.1010404@baylibre.com> Date: Thu, 3 Mar 2016 15:57:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20160303145348.GI15541@lunn.ch> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andrew, On 03/03/2016 03:53 PM, Andrew Lunn wrote: > >> +- compatible: Should be "plxtech,nas782x-rps" > > Hi Neil > > It would be nice to be consistent with the naming. The compatible is now oxsemi,os810se-rps-irq which is consistent with the timer. > > Maybe also the filename of the driver itself should be changed. You > had an interesting sorting problem in the Makefile, which a consistent > name would help with. Yes, I will add -irq to the driver name and _IRQ to the config name. > > Andrew > Thanks, Neil