From: David Daney <ddaney@caviumnetworks.com>
To: Rob Herring <robh+dt@kernel.org>
Cc: David Daney <ddaney.cavm@gmail.com>,
Will Deacon <will.deacon@arm.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Frank Rowand <frowand.list@gmail.com>,
Grant Likely <grant.likely@linaro.org>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Ganapatrao Kulkarni <gkulkarni@caviumnetworks.com>,
Robert Richter <rrichter@cavium.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Matt Fleming <matt@codeblueprint.co.uk>,
Mark Rutland <mark.rutland@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
"linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
David Daney <david.daney@cavium.com>
Subject: Re: [PATCH v13 4/6] arm64: Move unflatten_device_tree() call earlier.
Date: Thu, 3 Mar 2016 08:33:37 -0800 [thread overview]
Message-ID: <56D86761.9060905@caviumnetworks.com> (raw)
In-Reply-To: <CAL_JsqL0Mzgp_SkycmiZBbt2OoGtE7_rFgD41Jex4nDS7xXrHA@mail.gmail.com>
On 03/03/2016 05:47 AM, Rob Herring wrote:
> On Wed, Mar 2, 2016 at 4:56 PM, David Daney <ddaney.cavm@gmail.com> wrote:
>> From: David Daney <david.daney@cavium.com>
>>
>> In order to extract NUMA information from the device tree, we need to
>> have the tree in its unflattened form.
>>
>> Move the call to unflatten_device_tree() into paging_init(). This
>> puts it before the call to bootmem_init(), which is where the NUMA
>> information is extracted.
>
> Can't you just move up unflatten_device_tree in setup_arch rather than
> hiding in paging_init?
No.
It must come *after* map_mem() and *before* bootmem_init(), both of
which are done within paging_init().
One option would be to split the things in paging_init() into two
functions, and then do:
.
.
.
paging_init_first_part();
if (acpi_disabled)
unflatten_device_tree();
paging_init_second_part();
.
.
.
>
>> Signed-off-by: David Daney <david.daney@cavium.com>
>> ---
>> arch/arm64/kernel/setup.c | 7 +++----
>> arch/arm64/mm/mmu.c | 5 +++++
>> 2 files changed, 8 insertions(+), 4 deletions(-)
next prev parent reply other threads:[~2016-03-03 16:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-02 22:55 [PATCH v13 0/6] arm64, numa: Add numa support for arm64 platforms David Daney
2016-03-02 22:55 ` [PATCH v13 1/6] efi: ARM/arm64: ignore DT memory nodes instead of removing them David Daney
2016-03-02 22:55 ` [PATCH v13 2/6] Documentation, dt, numa: dt bindings for NUMA David Daney
2016-03-02 22:55 ` [PATCH v13 3/6] of, numa: Add NUMA of binding implementation David Daney
2016-03-03 3:34 ` Rob Herring
2016-03-03 4:25 ` Ganapatrao Kulkarni
2016-03-03 5:13 ` Ganapatrao Kulkarni
2016-03-03 17:33 ` David Daney
2016-03-04 0:21 ` Rob Herring
2016-03-02 22:56 ` [PATCH v13 4/6] arm64: Move unflatten_device_tree() call earlier David Daney
2016-03-03 13:47 ` Rob Herring
2016-03-03 16:33 ` David Daney [this message]
2016-03-03 16:36 ` Ard Biesheuvel
2016-03-02 22:56 ` [PATCH v13 5/6] arm64, numa: Add NUMA support for arm64 platforms David Daney
2016-03-02 22:56 ` [PATCH v13 6/6] arm64, mm, numa: Add NUMA balancing support for arm64 David Daney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D86761.9060905@caviumnetworks.com \
--to=ddaney@caviumnetworks.com \
--cc=ard.biesheuvel@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=david.daney@cavium.com \
--cc=ddaney.cavm@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=galak@codeaurora.org \
--cc=gkulkarni@caviumnetworks.com \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matt@codeblueprint.co.uk \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=rrichter@cavium.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox