From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757351AbcCCQdt (ORCPT ); Thu, 3 Mar 2016 11:33:49 -0500 Received: from mail-bl2on0099.outbound.protection.outlook.com ([65.55.169.99]:47126 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751923AbcCCQdq (ORCPT ); Thu, 3 Mar 2016 11:33:46 -0500 Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=caviumnetworks.com; Message-ID: <56D86761.9060905@caviumnetworks.com> Date: Thu, 3 Mar 2016 08:33:37 -0800 From: David Daney User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Rob Herring CC: David Daney , Will Deacon , "linux-arm-kernel@lists.infradead.org" , Frank Rowand , Grant Likely , Pawel Moll , Ian Campbell , Kumar Gala , Ganapatrao Kulkarni , Robert Richter , Ard Biesheuvel , Matt Fleming , Mark Rutland , Catalin Marinas , "linux-efi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , David Daney Subject: Re: [PATCH v13 4/6] arm64: Move unflatten_device_tree() call earlier. References: <1456959362-2036-1-git-send-email-ddaney.cavm@gmail.com> <1456959362-2036-5-git-send-email-ddaney.cavm@gmail.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [64.2.3.194] X-ClientProxiedBy: BLUPR07CA089.namprd07.prod.outlook.com (25.160.24.44) To BN4PR07MB2130.namprd07.prod.outlook.com (25.164.63.12) X-MS-Office365-Filtering-Correlation-Id: 66694270-fb66-4a73-219c-08d3438195d9 X-Microsoft-Exchange-Diagnostics: 1;BN4PR07MB2130;2:z3WAIGcZmivVMmJLlf/oQ+ibG5gmdTVDeBnklSoI8C2DdfFChN329kBll7o/ZQndMaavGeq/ln8V8Zr0KJ0sWBnrHeH0t4uw0SmDopIJYYgV23wApwq0zHra5cbePWBuaWOn5Qcjk+ICiS+HLc+1S8qTsP9kFzo6bW4tCigioJztz+f/nAKjxm4X+4HHgZY9;3:8nANpq96OenHwoUol0wYhP0cq6ErGOfYPmd1h7Mqyxk6HWuKs6d/ShCvjXn+uksI5h8WNO02IFYdJiybXdTsissjPWAbUZ9Eo0TTR3yzdX/q8o/XrnSeK1qG+uhbvTwo;25:qtYEZe+B69tiOJxg5Qphk88H95vQPs9pyU+GmUTeVM+lG9BghhhA5+eqTt/Iy/hodxenHFlF6ow1HkC61TVjCmncReQEXApQV1vg8LCsypG6Wtn4un8FQ9czBaIDIriEnXpXNPWf3X1bHf/VkKnqm4QxeGkEGvDoYMVl4SE1ev1eFmolUSAUpMFJI8bqSFgOIJgYCZML8xdhtiAPEEhchjERm2v27sLvK+E1W6Q5PtwgObjrdCVPoNTjpRKsoeQoCCQVgaXX61FCjusQZeyJ7eJ/WC3ML1fjfJcuISAZTR8qeSZevG+lIGOyEBoC9IQPbDiHCKW84bN+bTgE5q5hFw== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN4PR07MB2130; X-Microsoft-Exchange-Diagnostics: 1;BN4PR07MB2130;20:qWTUyC0CY/jdRYTa9TgY0RQ7UpqL3iKrptoRRliznsdw2KT2rMvpYmAoPP2lgyI73RDqaDqmYOGXNhDm2rTtzHFzBcy9vYcIFhTDZ8N0+mC0kkkKd1W4pdNZSZa0+R4eA2ke1iYmW3qr/5KHPWls8EbVhxVTEitiZ6ZlrE5QB2SetQ88RQdeTHh9eD9p22m4n2xLMqXaj3IjnftMB1wJSq6MYlA1u+Ed/2neZoZZ9fwmql0j+1WSq+WFsIRxsLPMJmM7ufqm1hOx3s6kRAuRRD9rxGP/ZNkzadVK7FxDYueGLK3DHmfWT7Yn32j0HcDcqLdWJmYBg2ap/fmQBZa2wj2k/lV6u45msHF48O6h14eELnMUDK6yTFtLEieKnqOEZYjTCI1Tq+n3O/f5pFjQi09A5jsvs8aRW0zH4aVcy6aSZgsMbJb7lSyinqmchM4T2LV/3yQLfTgFA8iPxgyeJPyzz1LqLIJ2CGLdZRMg2+y9aUljca0mUMfAauanflhZUPx/OkzWMVzcAiji++sXrLzkcbchAx6oD+eQEOl7i4niTD1AzvAuszY1Dnq6uBUhaRT7wd5bpso+KcPdRba/kaY0aKgTeYqbAv50bAhY7uI= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046);SRVR:BN4PR07MB2130;BCL:0;PCL:0;RULEID:;SRVR:BN4PR07MB2130; X-Microsoft-Exchange-Diagnostics: 1;BN4PR07MB2130;4:6qVuyKezUJv9pZdMue372kiQaC7N6JeTEm3+q/4l4T5z8pCyVBBw+xzAVg5099NWt0H4CsgHpoiz69G/bpUedJJGKDniwiChvCwMy7MiGx4tv9WT6y87eYvOzodMfJ8oDIFufqdkNKdYijsEiQIrXvPi+9rxlHa8PqLS7TmAGU9I57M1lnKyqv10iK5DUR0jymdp4nMN6xuIFDyN6o3hOSaP3urGxFzlC9CpRqMsV3CCkxhsYBAEdaYkjt8YOmNMw5wc45KI1+vdDf3tCok0E8Jgf9ngfw2l8GRH134hL08TTzsYsblsoN4vCH1sfAgWeSB3+PjzVfKxlUz3RoJ+fkEk9nLuE1NnIRqRofnDsHlLMJvnQ3bKZ8r4ryMKrkx8 X-Forefront-PRVS: 0870212862 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(377454003)(479174004)(24454002)(23676002)(64126003)(1096002)(230700001)(87976001)(19580405001)(5008740100001)(92566002)(189998001)(80316001)(65806001)(77096005)(2950100001)(19580395003)(40100003)(66066001)(81166005)(6116002)(5004730100002)(4326007)(36756003)(586003)(50466002)(110136002)(53416004)(50986999)(54356999)(33656002)(76176999)(87266999)(42186005)(4001350100001)(122386002)(47776003)(2906002)(65816999);DIR:OUT;SFP:1101;SCL:1;SRVR:BN4PR07MB2130;H:dl.caveonetworks.com;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjRQUjA3TUIyMTMwOzIzOjF6NTBSMDc2R3RMQXl5cmJDYWw0a0hLb0JB?= =?utf-8?B?ZkdmdEFDMXYwR2xFRHpnR0cvOEU4Rjk4Z0hXalZNVUJWVlFGRzJGQU5mclkv?= =?utf-8?B?TzNCRHdGZE1GY1ZkVW1YazZvZ3hUcEFMbk5zYXhyRmdWSWxFOHcxb0dTTExs?= =?utf-8?B?enZKWHhMK2lLS2xTenFXUzM5ZGNxbEM2MmJEYlpmaVYyNzRYa0YzWUo5Qk1t?= =?utf-8?B?cEJ3S3V5NWhRTkZSZy9kUGdRMm5lalhIZThwVXluTUpTOUd2Y05pcUQ5RFdC?= =?utf-8?B?Ui9Kekx6V1dXY2pZaUg3MzQ5aU1xQUIvcmI3alJRZERUQkZIQ1pFUXB5MFpB?= =?utf-8?B?YVlnaW5kOHBhNXgzRjNEQm9ndlpialJkeTNncXFHZzE2T1BveUhDYTl5Wllk?= =?utf-8?B?Z3V2d2pSaGZONEtleTdaZEg3V28wSFNBYTgxUUFKaXB2aDZ5ZmQ2QVE3Zzc0?= =?utf-8?B?QVJRQmNWdG1WZ3dyNGJqRGxoZTVDR3VibnBvclBlSXBUUEUvbFIwbFA4UFcx?= =?utf-8?B?eVZYOXN0K1l3enB6SFQ3c09pR1ZMYWV6R21ueXpKR0dnWGZJSGh1SWFReWto?= =?utf-8?B?dUZPUW92ZkFFc0llNUJtKzZkbkJzK1dMRU1PSm1RY1plMEtpb01WOXg2Q05m?= =?utf-8?B?ZG94TXFETWZxQUNOYVN3Zk1jREdhVHArd3ZPem1uUHBoUnJWZ3pmaXMrWlZI?= =?utf-8?B?WC9DSVA1ZlVvTmxDanZ5eDNuM2FIM1hNUmRQY29DL29IQ3cyY09pOFcyTGpS?= =?utf-8?B?U0Via28yeUVmb0dmeW84K3YzYU9DUFcvWFVCOUpGaXNPL2VvNmxCQkVJcksx?= =?utf-8?B?NGJIbytiTzllVktaS2RjK2lzQ1NIWExDWU9TRjVkWTVNMHJiQTg1WGoxdFF1?= =?utf-8?B?bmpwR1hYcDh4Vlh2NWpsTDZIN1RCM2QySkdtaWZKRThJYUVlWkM4SlUwYjJh?= =?utf-8?B?Q2JtNk9jZ2ZYWVZnTXBVa2ZHZGlSQVljRENsak1mbVVSdGpJamZhdENaaVVk?= =?utf-8?B?VzUxYW9oTVc2WVNTTU9ySHk5d3FwYmxIZVJBNi9vM091ZDE1d21QcGh0UWhU?= =?utf-8?B?REdLMGVMSUluRFVESUdLOXpJVjJSeVNndkVaVzZISFJpQTNNeU9oUUlUNS9V?= =?utf-8?B?ZUZmcFZHNTZZeDgzdjdybXU5NDE3SE43MUM3M25YaUIxZ00zTE5ONTB0UmJq?= =?utf-8?B?ZE1HTE44RlQvSnd6RDl2cW92R29oNnFmMWFRUWRyUW8xdVkxVjVySm8wSWVG?= =?utf-8?B?Wjk0VzFSNDYxSWhzNUU5UjIyWml3Zk5Vb1loN1llSjl6QlJRVm1qSlFCYlE0?= =?utf-8?B?VWs5VDQ1YkRqckExMkZJVnFJTDJGK3lVQXc5dW05YWs5eU4vZllvRlNXalpi?= =?utf-8?B?Q2dYRktMVlRyUHJacVlVS2xtYllOV1psL2d4VzJzVmJxQU8wTEJHMmZRWlBT?= =?utf-8?B?aUVkMzhLeHJmNzgwMUtEZlB6U3NTUmpKeUpaK3R1cmw4VWNEd21PNVFwSGc4?= =?utf-8?B?M3cyUT09?= X-Microsoft-Exchange-Diagnostics: 1;BN4PR07MB2130;5:HZVEDRQeR98l8otAVGIVtwkcH7NzNwQR7qFDq67lnUWNhFuT4bdyw6Xvf8xExrtBqr38PO+U4fOG70HvfKET9LMRXikIRPmlI+bTtiDnCE4Ck2z5ICLWjYji2+LUnQ1TV5l6Nt1LmbA87IGSbL3few==;24:lM0f9VkNIP/+H3NIb+CDTkRhsA642JpmEA+gZZd6kDRKWRl2S8YodD1wRDgkabrQNC1E9cmP+/E8KQnS8J4HER+AnB6tzzbxCrkZ53qeezw= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2016 16:33:40.9967 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN4PR07MB2130 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/03/2016 05:47 AM, Rob Herring wrote: > On Wed, Mar 2, 2016 at 4:56 PM, David Daney wrote: >> From: David Daney >> >> In order to extract NUMA information from the device tree, we need to >> have the tree in its unflattened form. >> >> Move the call to unflatten_device_tree() into paging_init(). This >> puts it before the call to bootmem_init(), which is where the NUMA >> information is extracted. > > Can't you just move up unflatten_device_tree in setup_arch rather than > hiding in paging_init? No. It must come *after* map_mem() and *before* bootmem_init(), both of which are done within paging_init(). One option would be to split the things in paging_init() into two functions, and then do: . . . paging_init_first_part(); if (acpi_disabled) unflatten_device_tree(); paging_init_second_part(); . . . > >> Signed-off-by: David Daney >> --- >> arch/arm64/kernel/setup.c | 7 +++---- >> arch/arm64/mm/mmu.c | 5 +++++ >> 2 files changed, 8 insertions(+), 4 deletions(-)