From: Florian Fainelli <f.fainelli@gmail.com>
To: "Álvaro Fernández Rojas" <noltari@gmail.com>,
linux-mips@linux-mips.org, ralf@linux-mips.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
jogo@openwrt.org, cernekee@gmail.com
Subject: Re: [PATCH v2 2/2] bmips: add device tree example for BCM6358
Date: Thu, 3 Mar 2016 12:07:32 -0800 [thread overview]
Message-ID: <56D89984.8020805@gmail.com> (raw)
In-Reply-To: <1456054881-26787-2-git-send-email-noltari@gmail.com>
On 21/02/16 03:41, Álvaro Fernández Rojas wrote:
> This adds a device tree example for SFR Neufbox4 (Sercomm version), which
> also serves as a real example for brcm,bcm6358-leds.
>
> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
> ---
[snip]
> + periph_intc: periph_intc@fffe000c {
Other examples are not doing this, but this should be: periph_intc:
interrupt-controller@fffe000c to follow the ePAPR recommendations on
naming nodes by function types.
Everything else looks good, thanks!
--
Florian
prev parent reply other threads:[~2016-03-03 20:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-21 11:41 [PATCH v2 2/2] bmips: add device tree example for BCM6358 Álvaro Fernández Rojas
2016-02-22 19:09 ` Rob Herring
2016-03-03 20:07 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D89984.8020805@gmail.com \
--to=f.fainelli@gmail.com \
--cc=cernekee@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jogo@openwrt.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=noltari@gmail.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox