From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755141AbcCCUJA (ORCPT ); Thu, 3 Mar 2016 15:09:00 -0500 Received: from mail-pf0-f193.google.com ([209.85.192.193]:33614 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752873AbcCCUI6 (ORCPT ); Thu, 3 Mar 2016 15:08:58 -0500 Subject: Re: [PATCH v2 2/2] bmips: add device tree example for BCM6358 To: =?UTF-8?Q?=c3=81lvaro_Fern=c3=a1ndez_Rojas?= , linux-mips@linux-mips.org, ralf@linux-mips.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, jogo@openwrt.org, cernekee@gmail.com References: <1456054881-26787-2-git-send-email-noltari@gmail.com> From: Florian Fainelli Message-ID: <56D89984.8020805@gmail.com> Date: Thu, 3 Mar 2016 12:07:32 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1456054881-26787-2-git-send-email-noltari@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/02/16 03:41, Álvaro Fernández Rojas wrote: > This adds a device tree example for SFR Neufbox4 (Sercomm version), which > also serves as a real example for brcm,bcm6358-leds. > > Signed-off-by: Álvaro Fernández Rojas > --- [snip] > + periph_intc: periph_intc@fffe000c { Other examples are not doing this, but this should be: periph_intc: interrupt-controller@fffe000c to follow the ePAPR recommendations on naming nodes by function types. Everything else looks good, thanks! -- Florian