From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752728AbcCDB0h (ORCPT ); Thu, 3 Mar 2016 20:26:37 -0500 Received: from mga14.intel.com ([192.55.52.115]:11758 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750751AbcCDB0f (ORCPT ); Thu, 3 Mar 2016 20:26:35 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,533,1449561600"; d="scan'208";a="663513264" Subject: Re: [PATCH 3/7] usb: misc: add common code for Intel dual role port mux To: Greg Kroah-Hartman References: <1456987064-3365-1-git-send-email-baolu.lu@linux.intel.com> <1456987064-3365-4-git-send-email-baolu.lu@linux.intel.com> <20160303161556.GE3743@kroah.com> Cc: Felipe Balbi , Mathias Nyman , Lee Jones , Heikki Krogerus , MyungJoo Ham , Chanwoo Choi , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org From: Lu Baolu Message-ID: <56D8E40D.20202@linux.intel.com> Date: Fri, 4 Mar 2016 09:25:33 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160303161556.GE3743@kroah.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/04/2016 12:15 AM, Greg Kroah-Hartman wrote: > On Thu, Mar 03, 2016 at 02:37:40PM +0800, Lu Baolu wrote: >> +#if IS_ENABLED(CONFIG_USB_MUX) >> +extern int usb_mux_register(struct usb_mux_dev *mux); >> +extern int usb_mux_unregister(struct device *dev); >> +extern struct usb_mux_dev *usb_mux_get_dev(struct device *dev); > This api needs a lot of work, for such a "tiny" api, it's obviously > pretty incorrect. Please fix it up to be sane... Sure. > > >