From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759014AbcCDPil (ORCPT ); Fri, 4 Mar 2016 10:38:41 -0500 Received: from mail-bl2on0093.outbound.protection.outlook.com ([65.55.169.93]:29664 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757509AbcCDPiI (ORCPT ); Fri, 4 Mar 2016 10:38:08 -0500 Authentication-Results: spf=fail (sender IP is 66.35.236.236) smtp.mailfrom=opensource.altera.com; arm.com; dkim=pass (signature was verified) header.d=altera.onmicrosoft.com;arm.com; dmarc=none action=none header.from=opensource.altera.com; Authentication-Results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=opensource.altera.com; Reply-To: Subject: Re: [PATCH 3/5] EDAC, altera: Addition of Arria10 L2 Cache ECC References: <1456850301-22066-1-git-send-email-tthayer@opensource.altera.com> <1456850301-22066-3-git-send-email-tthayer@opensource.altera.com> <20160304103844.GC16291@pd.tnic> To: Borislav Petkov CC: , , , , , , , , , , , , , , , From: Thor Thayer Message-ID: <56D9ACDC.5070607@opensource.altera.com> Date: Fri, 4 Mar 2016 09:42:20 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160304103844.GC16291@pd.tnic> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [64.129.157.38] X-ClientProxiedBy: SN1PR15CA0031.namprd15.prod.outlook.com (25.163.200.41) To BN3PR03MB1477.namprd03.prod.outlook.com (25.163.35.140) X-MS-Office365-Filtering-Correlation-Id: efd64fc6-5692-4d83-75d9-08d34442f8ce X-Microsoft-Exchange-Diagnostics-untrusted: 1;BN3PR03MB1477;2:BudM78HCqtri7QVQaKZext/vreg5xRpITKUx/xT7x8lKvNIsSQyjtedY10/ncEsunul6T1sQWWPzg4fir12KiHroQTj/iH2fQ0PFjpv2+CUOfQkNdNKR7gzFybtEzot18GNf2TFJGve1FKcwSlFsM40UTxzBSOLib29a5XykWh9QennvmMfxD5HJtYR6WQ93;3:+T7OcfBSuf4k8oOZT07hc3xW2lRxa/vbt2QaYTVuszG+TjQzGCANvDqHH9GahQ6DT76wRJADahXsd4LGFPJxTHuZns4abRvyqMKt5e12m6olmL0Y45o1eLu9MOvJ7G6x;25:Y6G+2SJtFa+LXwXwoC33NhtUfUIuEeOw7YTheqGS0Qo7qRXFzMlf091hxMfLkFoWQxwCbk21lErI95x/M4HcJCeup2WesJpJ33ShXmdUt8wc7NylCs5TO7McOhRjwAFBXF9Yaqg6BxKD8FaIUI/Pj0f5ts/wsX+5jueXJlWOmYTfVFZxiNlRpURtntshBwcTsEWVsqejforv3azMbfceH0gf2ExjkxTkFvCHFjW9r1BdGE+7U6LD6doNKHIN6yOblgAh/KdjpF2R/ZqyWUUTH4Q56MpyOfWjcViqre4Vt3UQq7pdgP1BfQylSQvJEV5kuEIfO5yx0jAhzVqv2z/3pw==;20:5OXebc0zM9TyAazOvKQao89H0KmkO7plp8uXMa9FwKlSG42/M3RR3npO+oX+n8Iz+eH6p8zUEvpFn/Pqg8en45Ukf/vDlOR4Cjxdv5selrqw3Ew10NV/ywgR62hpCEqPYZVkogNSKn0Ha5ZlqcMGFH8dbXRSOWcroWjjypz05WA= X-Microsoft-Antispam-Untrusted: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1477; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:;UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046);SRVR:BN3PR03MB1477;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1477;BCL:0;PCL:0;RULEID:(601004)(2401047)(13015025)(13017025)(13023025)(13024025)(5005006)(8121501046)(13018025)(3002001)(10201501046);SRVR:CY1PR0301MB2027;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0301MB2027; X-Microsoft-Exchange-Diagnostics-untrusted: 1;BN3PR03MB1477;4:aIE98f09Iilrzqzwrq6p6zthHcBq7wLEn9TI6hVGSP/UPPpyx4BejdkGBnZe+o9BadIm0Xe8cVrkKFQG8irLKbBMlJbOsqeN4PxA5Gibcal3bgYRXGV/t/Qc1rorHJzc8OY6HGG/LLRrEglk4IxEpvpa0uDhYqAY9hSeQyGs4Ulefd17RkOyhQLZSvt1bujNk7s0FCvCiCwdgPEfDN9jiGmfE2vLJ3+DyZYpOYsyXVrubpGHWEBAC42MQ27KP1cuNDWromsaRiLSHiaMalpXFNSSijNu6tmvx4COc75fQHDLp/AXL9Gn5P/mMFzEavCMWKdsYKhfZO69BZthH7G6AJn94LEZHPO1dief4jKibKh1EUo5UurWDKP/ZMntdnzM X-Forefront-PRVS: 0871917CDA X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(4630300001)(6049001)(6009001)(377454003)(479174004)(24454002)(87976001)(3846002)(6116002)(33656002)(586003)(42186005)(189998001)(65956001)(43066003)(66066001)(50986999)(65806001)(50466002)(4001350100001)(40100003)(122386002)(230700001)(1096002)(86362001)(65816999)(110136002)(47776003)(54356999)(87266999)(76176999)(53806999)(5008740100001)(2950100001)(77096005)(19580395003)(19580405001)(4326007)(83506001)(81166005)(23676002)(2906002)(3450700001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN3PR03MB1477;H:[137.57.160.203];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics-untrusted: =?utf-8?B?MTtCTjNQUjAzTUIxNDc3OzIzOjdTWnFsRjJGcDlBK2o0WnNpb2tSQzJ1d0d3?= =?utf-8?B?czQ0U0xzUnlUc0lEQmVCUmlwalcybkl0T3VyMllLRFdyQ0RoSGtocFBXeHgr?= =?utf-8?B?d2FkTDRjVEMwYUxlTC9KVFBycUdmZWpRTnJuZHBzV2VTekpxQ1hUSTdPeFh6?= =?utf-8?B?OXBib2szT2l5L2dIZ0RXb3ZENDJ5RnA1a21xRnlUaXdlOGh0WFZrUDA2eFJC?= =?utf-8?B?Y2NTQTdKUWpQQ2lROHpqbEl4Yjd3dWV1bFlRSlF0TGJqbFRxM0NIazVMeWEy?= =?utf-8?B?M3ZwRk1vTkFNYTUzQkd3bmpyR0J1anRKSVA0RUhqMFl0YkhwN1k2WFZVR3d4?= =?utf-8?B?OVpxL3hQS1IrZGd6T1hNS0xnWjYwYWpsUUEzYkVZM2oxMmtINHVJRHdZT3Rj?= =?utf-8?B?M3hoYm4yS1ZQTXhSRFFxaFJnUU5Dd3N5cDk3MzN0K2JNRERFTmxNckRJLzZB?= =?utf-8?B?Nmk2RFZQd1dxbTk1RWlRd3BRN1d5eU9RNXhxVmRCYWxJRWlWbExDUEtlV1lX?= =?utf-8?B?MVI4MHp0QXZUbHJlYTNJUGdBbUwzYnJFL2dtUlVuS1dkQjBQVTZuaU1yTVZm?= =?utf-8?B?bGI2WnlJWFNtQmpSTSt6bTVSVzFiQXpGV01RNXdKb0orT29NR25mSDhDVG5B?= =?utf-8?B?MzN2WDhmSk5Uc0I3eU50QlVpME9zNEpXcmx5cktTZWpQamhMYldKbDdYQmRT?= =?utf-8?B?bVJlbGNhTG5EVHo2clRPZnFiTExNSDRnQlhvS2M2YVV2OEpEeVQwRTJwSjhj?= =?utf-8?B?UzdQYnlFczFzWXh0OGw1OUZsaFlyem1FUVc2b2t5RmVpQm1Ick42SVZrZmlo?= =?utf-8?B?bmZldDZyOXlEbktPaFVFeFRkTkFpK0hzdzk5LzJwTHZxT3c2VFBrdjU3T3VM?= =?utf-8?B?YnFxa2RmWGRPYVZtVytOeFFZVk8rdkdPOGRkRldmWDRnZGg3ejA3bER5OGlE?= =?utf-8?B?YzU0VUdQYzFOSG5YdUdZd0FvNU92elh0VWtCV3ExQll2K0I2bWdaUi9OdGMv?= =?utf-8?B?NFZ1ejlZbkZ0RjRBTWZhM3VJaHJaTWVLMUVQZHNpeCtoRGNJeTFheWpQT0Nj?= =?utf-8?B?aXFTTmRwN09UYU9SOGE3cUVGWDlHZU1mZ2dwdm5Xa3VCZkRxOGx3b1preGhh?= =?utf-8?B?Q3V5MjlwbzRzcFhpSHN0ZEhhS0pVN01rM1pUNFNDZVhkK0g0TzZVdjRqVCtM?= =?utf-8?B?UG1SbCtiVjJGbTVieFZUalpCTkFqZHMwcmlsZzlUZGttdCtRZDVTMHpFSE5C?= =?utf-8?B?VkkvbC9HQ2Z6UktRdVkrY0FlTjhzVXgwa2xISFVBb2Z2NE9hU1hEQUt3OW5B?= =?utf-8?B?cU1EbkRCUUpBQWxxVTIzenl2MTltSWFiRlhUZjFDNEpWa2tvRk9kL3VuVkMx?= =?utf-8?B?MzhpY1FxakM3RHgxTHVyd3lJd1ZDUldIYmZXMnJjdW4rdnM4ekVCcFZ1c2VI?= =?utf-8?B?dGY1dnpxMW04c2U0TmFmaVFUTlY2VER3U1htSklqekhwTnlKVVdTRTF0dmVF?= =?utf-8?Q?i3Cc2u81abgQNITvn4/1eBkDQ=3D?= X-Microsoft-Exchange-Diagnostics-untrusted: 1;BN3PR03MB1477;5:RwGVBMeJ8Reo433bByq2nUNrW6L0zdH+2LyzECRyc9t9TnrVZ48bJRFIKMYb6jxxtGR7oAd1K0uZ+37NG2yyzRKBWgT76QhEq0buJOnGXkI9OAZWUPAz/g6BSyXoaHvmcl/VFqnidVqJSqW8X6rq1A==;24:cgnwawdnJr2iMQl11SV2SPlyRn3+qLAOqwRdxWn13xPUjGMPbVn/XlzqZFM9ONwn7VxDUBd/AWBuah8EcW9BZO5y4KeKFHGpczHUF+DhWGw=;20:JkCvRUpCCekx+PC0b+5brqRIWeNnq5ChNlzPWXQaSFuEmx3IS2/49kI+JsFUGiDJjlWf4eGUOwzotQEiwXypRws5ePw19dUiuURXHBHJih481Q8LzL3r5LxXrBlk3VflvMg4jcF0KR+ROJ5DwblyhUQfLroeJFEyQq2Gbzu4MKs= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB1477 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: BY2FFO11FD018.protection.gbl X-Forefront-Antispam-Report: CIP:66.35.236.236;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(1109001)(1110001)(339900001)(3190300001)(377454003)(479174004)(199003)(189002)(24454002)(87936001)(16796002)(65806001)(65956001)(66066001)(106466001)(105606002)(47776003)(110136002)(956001)(76176999)(54356999)(50986999)(87266999)(53806999)(65816999)(86362001)(4001350100001)(189998001)(50466002)(85426001)(1096002)(5008740100001)(6806005)(1220700001)(6116002)(3846002)(2950100001)(43066003)(2906002)(4326007)(21840400001)(40100003)(230700001)(19580395003)(586003)(19580405001)(83506001)(77096005)(122386002)(3720700001)(3450700001)(33656002)(23676002)(81166005)(7099028);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR0301MB2027;H:sj-itexedge04.altera.priv.altera.com;FPR:;SPF:Fail;MLV:sfv;A:0;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11FD018;1:RBB9OBEdUV8yQj3hw+43YzXEUbIfLrx6oStZCeJb2taAbLqGD29/tOgwTTcIOi15q2A1rp2spQgRZ8jRxJG/up6n5O8i6vGukq564GcdrKi12/KG2qwg51cZrFRCj4DGI/Pb09+NOFmhA90c7rwBHpZgGiz2ivwC96rK9kKwGG0rRC9amhVZ0Z2YMuv1EtDRkDQaI/KNT/oPHxEWnrHhr7p0ozSae2OXAxidxyNqkXy9fNlRLJfC4GoAJGWaD2+r4ui63r8sPuxQvJLEKTuc7Mid9Wrv2KJYYz8BKvtxQCEnatCXOxymozQJ4IdfdDotICGzc7xedNSEW6Sd6CjiJZNMIF3cMmBCwKVCA5a+jDIPz6pWjktIEXO8ZHSKz733v1+S73tOzFqaI7QpVpuPjaTRp9Yu1h6TC85nYFx2xpmnQLWhz3os1PCciZQD0rTc8C9+u7m5qTcPZsiFHnBPiTRl+RDdWPiSdKJlKXYmyCtouzkkOdIfepG/MBbc5riY X-Microsoft-Exchange-Diagnostics: 1;CY1PR0301MB2027;2:feo0RQsh0u13rl9mtIMBYUGT6L0ybI8dIAtNI3960qBznZzk8LObwZJCPBZomqErSNAA+onu6hjOTauk52YDEsxgehLdZH/LuXT18PbNInEb3Ud72kyAOX/UqUCBrthY9n0x1Bw8c8vEz+gUh4EalP/rMJL/kXN/k1pmCzyna5eP7RbkciD93yBdoFeebZWG;3:rHQEMkGNbPExuKg2ie6dq6/Xfk0Xyf4qlPWBncTipT20YsgPAzw0bGyhaZ6RbCnBnfULv7WQZBx6B9ey3At4u+jDtmIWT2WXBpE9SfXJ5Orvwxxbm6ZvL7GTaYjFNSUbvhmOW4WXnfdSBe6C5mQtyDf+MmLjdWlsPo/qC5TDTNl4Uy0qeXC8nOY3pJOxWC3xPuc+2T2OJWFmST2gYjWHwmtGEkqq8xYIXrT1M2xpNp1ZDZAnob2Gd6/+P/Qo7RNV;25:GCvN1ikECqKG1KZd7m9y++UMjoHBEZS3DFYfTse9kMj2l4MH/YbeVmFSImeWTOkTJYRRAR+2RdNCKk3NGAbY/IuV2KgxzdaiyO5+8qPHmyuPdWnH0rUJji0wxN+vYLdtvOuIB3MJVRViZoKLFD/G5+9k0UGVo+gFf27XQB1zxL6mNLngcutXNGnOEIq3Ll6g7IM778VWEtkXk383wDtQ0T7v2xTkiVjZc/lwW55UOiLknPwc8pPP5vBUXNP+B5dxoTSgWNLDnViHqbu18RQiSWruViMIjd5qzP7C0ozpjhGBcybGoEIPWGaRWtAojIsrx3QuOwSPHNbJMYTfV2wMsg== X-DkimResult-Test: Passed X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(3001016);SRVR:CY1PR0301MB2027; X-Microsoft-Exchange-Diagnostics: 1;CY1PR0301MB2027;20:sfOxZ1ZHiod99hJQ4ImzN8+L/B/GEoVicLuFiqAu1/BwhzABlfpqqn8jr5E0dy9W8cLjWT+Vumux6JLLWSc+oiCsGYzJ2waaetrWeZnQZK49d62Vw2cCkz3YDbGy5l+t9cwgrTSlNEzjcLznT/30qjVwGloS6BBS33bEPltRh74=;4:vnDI0jSR4TISuoNnpadOUu5YGGqZ/dDYKqo96inh5gWwzXUkyT7w5D3Rn0FXfOncVLDt8dZcrEhsZcpJ3uJEv616VqnxRpsopVepRuNUAvvePUQHvf3tmpifs7rX4GujTogst0hUy5sSvUQ9HgKkAj/LMnEYAYSbV/gQT3lhC9EOPQLfDR1yNZUtbE5ArkIfJX+rd1i6QEMbnpLHwqu3UDAOY0dXLutv+nH4i6X60tA3FM0Mg8MUX5qvWGaQmhUvfqFgbCkYW+7YSymLYijNhojUnk3ARorwnd5kHXc5rezbZM8c/aqwvw5D01kNSRRtTZ9o+B7orjKRLiOB7L9dGlkhIn9EuQaJpy7jWPVDoU+47DWLhzDOpY87pWKLvFLdvxPJQ8V3CxLvAsFDHWFWnMKaN4leUH/ONHU8ZGAU2EuCNOZ/J7MqT934q1rMumylEFo3tzuxlVj2OAydBPSKFQ== X-Forefront-PRVS: 0871917CDA X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjAzMDFNQjIwMjc7MjM6STBPMUY2ZUduK0hqV2ppTzhPdmltWGRP?= =?utf-8?B?RXk2RjEvRmlRUytKK0JubG0zVWk5NVhNeENIbG5yRjJneG94RWdFWkdlNE9L?= =?utf-8?B?aFNRemVIdGhDNndHeUdKZmZ2eG5yclpKVm9NWU0wU3E4aDF4SEtMODNEa0FC?= =?utf-8?B?MXlGZVcxMnl5WDZUVklwUGJUa3pjcEtGRUlROUdCU3hxRmFyRmxVb2tYNFJx?= =?utf-8?B?UWNoeU1QM1dtUnRnR2kyNFdxR1VxUnB5eExvSFM0UFVXWUJ2elh3T1NZY2dG?= =?utf-8?B?MnJBcThxMDRsckRqRlMyUXEvendxMlVORjNPaGs0TUNqVjdnZnk3OU5IZ3NT?= =?utf-8?B?TWgrSTlDZVFsK1BocTR6ZXZqRXhFQTh1S1dPWm1ERThLVnF4Q0tpOWVXV1la?= =?utf-8?B?bWw4UkY0M0JCYVVSY0lEMWRuVHV4c0lwLzZjMSs4V3E3aTlzck1WVWYyYXBW?= =?utf-8?B?NHJKejVKQ3k3M1BHcndSdkg3WUhjcW9rTFpQNTlYRjJiVW1BV0VxcG0zRHRs?= =?utf-8?B?WGYyQzcxbnphMDMwMitjdDkzckhWRVBLUUZiM2xBY2hrd2RYNXhBemZVUWp4?= =?utf-8?B?Q3VDRkt1d05tZ055UzZCcU9weHlJUFpEaXFXT2F2bUNlTHJJR0N1NkQ0RzND?= =?utf-8?B?RmU5TmJKOFliamdoZkc3Q0NRUHpIQmRoK00rS3NqN3lBYjZ5cmtpcHZBS21w?= =?utf-8?B?ZzNwY2VSMVB6NkhpMU1Za3pzSmpWMUJnQWhvaWE4S0NpKzd5OW9SZk9INHJj?= =?utf-8?B?azdYeDFrdWlVWGZ6TlJadzlYM0I1NDZKVmVFQmlqbjRUdWNkb1A1MDFtcjNB?= =?utf-8?B?VzdLSmlXMjFmRGpUMXU4dmtjMGlVVnBCRUlRbjNJVU1xY1ZMUHZWTlZ4QUFX?= =?utf-8?B?c0hhUVg1elp1MTEwUjdrY1JiQTVrczNVV3VEZ3RvVU1ERm96TS9VQVo3N3Fo?= =?utf-8?B?RnhabXFQUmw5ckdLTFJZMHFRMEcvWGZuczVyYWJvMCszeW1EK1JiV0dXUGJW?= =?utf-8?B?UEVoUXFIeUN0MU1kWVBWeEdMOTM2Z3FHNzVQb050T01xdXZrc3ZOTnZiN1B0?= =?utf-8?B?NDMyeGtQaHFna3dBbkFsTDJBcGVuT2hjdllMZGZ3cXFJbEkxSXBVOVFSRzg4?= =?utf-8?B?bEs4Mm82aHRCcU1hc1VPcjRSV1RtZ1o0ZEc1ZlZ0Q0ZIVGRtaHlaalpLYzIz?= =?utf-8?B?THRadjVQSTMyb0liNWFhODh3YUE2Yms5TlIxL2t6SVpkQW12eTVKdnJBYVky?= =?utf-8?B?c1AwNDFtYUF3b2ZZSFRJYmlMTmVzTWFlZGU1UVFiQ05WZE55d29CLy9MMjdH?= =?utf-8?B?SmhKL2tkWUF6RXFNSllnNDRHRWxPWlRSd0tDNTNvRUp2by8xRDZ5RWdDeU1o?= =?utf-8?B?Nnl0eGZlN1RIRVVSSmU4NUc2aVZwckJJVENybnZNSkhCbFhiYXJJOXM4Vk9z?= =?utf-8?B?SGIwbC93QXhocGlYNHNPZXJ1SDdyTHlHeVY2K3pQQ1NBZHRvNzhobG8zZmZz?= =?utf-8?B?ZFFBTTR6anJDMkhLd2c5QmhFNmtjQWxLZFA3S3c3TURFY2QxZXBmMkh4azNn?= =?utf-8?B?ZjVvY3dsWmdxUDNiRTZLMFNtWEl2K3NJd2RsejFoQ0JwdEduTitKNjVsZVVw?= =?utf-8?B?ODVYejZqWDFUNS96elF0YXpybW5KWUY4WUhPbFZrMUpPM1RMUGZYdHhjOW5k?= =?utf-8?B?ZUJtN3g4ak5uN2dNamhlc0czTSs1RHhOZndzbFNHYTJpN09ZeTZsWWx3WFZo?= =?utf-8?B?OEZyRm1WY1M5ZWtWcnp0ZmhuM3VmV3FiZ2s0Z25zTWxHWjI1WjJyOUJFU1or?= =?utf-8?B?RFd5MnQ1MitIWkJRY3hEUERmQ1hrZWN6d2NkbFg3WjlkMGloeGlrNmlYcyt0?= =?utf-8?B?bWsxU29KdEdHdXVXeVh3cFNuWm80WVNVREFHNlJReEdTY29oRHN5QVRhWFRx?= =?utf-8?B?Y2RLVzZwbHMwMGc9PQ==?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR0301MB2027;5:z9Gn+7PksbDUGAgtfjBDEFQZUuQaaal5lpHU9onY7uUChHsa78+EIEKHpXrpI4t7fHZXaQLYs41fVMJDVX0bB769T2SQZE2Go2XMaQ7YjP+yXBD0l4bbtwrc7mLS4+LGaDdQr0Su2ntB9aW+DYdi/A==;24:t5tkCBus/XuzU8cvfYvyOFLc8QEf03N1l235R07poG2+jgejMjyuBYRBozk1wC8L2ste8AM1tOweV+SfqP0jtz6P2AUVVKNi6rl6qbGIiy8=;20:tsBDj0tTpr1NlLFPNODMVFHECU3E9LjfKFrRcwL0qGOa9NEYPplfrOxrLNe1EGBKBho+NjGtobOR5DiVuRSo17TVIZPtfYCErp/zYoHqZ3t8L7zvx2pELlWGj4IgHtqwWXHhSGl2D4KoPb6NjsW3jyxqTzzd5DI7o6vfjCcm+KM= X-OriginatorOrg: opensource.altera.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2016 15:37:56.4149 (UTC) X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fbd72e03-d4a5-4110-adce-614d51f2077a;Ip=[66.35.236.236];Helo=[sj-itexedge04.altera.priv.altera.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0301MB2027 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Boris, On 03/04/2016 04:38 AM, Borislav Petkov wrote: > On Tue, Mar 01, 2016 at 10:38:19AM -0600, tthayer@opensource.altera.com wrote: >> From: Thor Thayer >> >> Addition of the Arria10 L2 Cache ECC handling. The major >> changes affect the L2 ECC registers not being grouped >> together. The Arria10 IRQ status needs to be mapped into >> a different region. The mapping occurs in the L2 specific >> function. >> Important changes include: > >> 1) Move private data structure definition to altera_edac.h >> 2) Move Cyclone5 device defines to altera_edac.h > > This should be a separate patch. > >> 3) Split IRQ status and ECC enable/control into separate >> memory areas. > > Ditto. > >> 4) Add IRQ status mapping in L2 ECC dependency checks >> function. > > Ditto... > >> 5) Addition of register offsets in private data structure. >> 6) Changes to code to use register offset define. >> 7) Addition of Arria10 L2 cache private data. >> 8) Add IRQ flags to indicate Exclusive/Shared. > > Do you see where I'm going with this? > > Each patch should countain one logical change: add defines and move > struct, change functionality A, change functionality B, ... > > The fact that you have to make a list of 8 important changes should > already give you a hint that it needs to be split. > > As always, I'm going to need ACKs for the ARM stuff. > OK. I'll split up the changes and resubmit. Thanks!