public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@fb.com>
To: Wenwei Tao <ww.tao0320@gmail.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-block@vger.kernel.org>,
	Matias Bjorling <m@bjorling.me>
Subject: Re: [PATCH] null_blk: add lightnvm null_blk device to the nullb_list
Date: Fri, 4 Mar 2016 09:33:09 -0700	[thread overview]
Message-ID: <56D9B8C5.2090801@fb.com> (raw)
In-Reply-To: <1457108824-3792-1-git-send-email-ww.tao0320@gmail.com>

On 03/04/2016 09:27 AM, Wenwei Tao wrote:
> After register null_blk devices into lightnvm, we forget
> to add these devices to the the nullb_list, makes them
> invisible to the null_blk driver.
>
> Signed-off-by: Wenwei Tao <ww.tao0320@gmail.com>
> ---
>   drivers/block/null_blk.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/block/null_blk.c b/drivers/block/null_blk.c
> index 64a7b59..cab9759 100644
> --- a/drivers/block/null_blk.c
> +++ b/drivers/block/null_blk.c
> @@ -742,10 +742,11 @@ static int null_add_dev(void)
>
>   	add_disk(disk);
>
> +done:
>   	mutex_lock(&lock);
>   	list_add_tail(&nullb->list, &nullb_list);
>   	mutex_unlock(&lock);
> -done:
> +
>   	return 0;
>
>   out_cleanup_lightnvm:

Thanks, that looks like a regression caused by a514379b0c77, I'll add a 
Fixes tag.

-- 
Jens Axboe

      reply	other threads:[~2016-03-04 16:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-04 16:27 [PATCH] null_blk: add lightnvm null_blk device to the nullb_list Wenwei Tao
2016-03-04 16:33 ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56D9B8C5.2090801@fb.com \
    --to=axboe@fb.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m@bjorling.me \
    --cc=ww.tao0320@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox