* [PATCH] null_blk: add lightnvm null_blk device to the nullb_list
@ 2016-03-04 16:27 Wenwei Tao
2016-03-04 16:33 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Wenwei Tao @ 2016-03-04 16:27 UTC (permalink / raw)
To: axboe; +Cc: linux-kernel, linux-block
After register null_blk devices into lightnvm, we forget
to add these devices to the the nullb_list, makes them
invisible to the null_blk driver.
Signed-off-by: Wenwei Tao <ww.tao0320@gmail.com>
---
drivers/block/null_blk.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/block/null_blk.c b/drivers/block/null_blk.c
index 64a7b59..cab9759 100644
--- a/drivers/block/null_blk.c
+++ b/drivers/block/null_blk.c
@@ -742,10 +742,11 @@ static int null_add_dev(void)
add_disk(disk);
+done:
mutex_lock(&lock);
list_add_tail(&nullb->list, &nullb_list);
mutex_unlock(&lock);
-done:
+
return 0;
out_cleanup_lightnvm:
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] null_blk: add lightnvm null_blk device to the nullb_list
2016-03-04 16:27 [PATCH] null_blk: add lightnvm null_blk device to the nullb_list Wenwei Tao
@ 2016-03-04 16:33 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2016-03-04 16:33 UTC (permalink / raw)
To: Wenwei Tao; +Cc: linux-kernel, linux-block, Matias Bjorling
On 03/04/2016 09:27 AM, Wenwei Tao wrote:
> After register null_blk devices into lightnvm, we forget
> to add these devices to the the nullb_list, makes them
> invisible to the null_blk driver.
>
> Signed-off-by: Wenwei Tao <ww.tao0320@gmail.com>
> ---
> drivers/block/null_blk.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/block/null_blk.c b/drivers/block/null_blk.c
> index 64a7b59..cab9759 100644
> --- a/drivers/block/null_blk.c
> +++ b/drivers/block/null_blk.c
> @@ -742,10 +742,11 @@ static int null_add_dev(void)
>
> add_disk(disk);
>
> +done:
> mutex_lock(&lock);
> list_add_tail(&nullb->list, &nullb_list);
> mutex_unlock(&lock);
> -done:
> +
> return 0;
>
> out_cleanup_lightnvm:
Thanks, that looks like a regression caused by a514379b0c77, I'll add a
Fixes tag.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-03-04 16:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-04 16:27 [PATCH] null_blk: add lightnvm null_blk device to the nullb_list Wenwei Tao
2016-03-04 16:33 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox