From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Jacek Anaszewski <j.anaszewski@samsung.com>,
Evan McClain <aeroevan@gmail.com>,
Richard Purdie <rpurdie@rpsys.net>, Bryan Wu <cooloney@gmail.com>,
Simon Que <sque@chromium.org>,
Olof Johansson <olofj@chromium.org>,
Duncan Laurie <dlaurie@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH] leds: Add Chrome OS keyboard backlight LEDs driver
Date: Fri, 4 Mar 2016 22:48:42 +0100 [thread overview]
Message-ID: <56DA02BA.4020603@gmail.com> (raw)
In-Reply-To: <20160304205955.GG17145@dtor-ws>
On 03/04/2016 09:59 PM, Dmitry Torokhov wrote:
> On Fri, Mar 04, 2016 at 09:55:24PM +0100, Jacek Anaszewski wrote:
>> On 03/04/2016 08:13 PM, Dmitry Torokhov wrote:
>>> On Fri, Mar 04, 2016 at 10:38:40AM +0100, Jacek Anaszewski wrote:
>>>> Hi Evan,
>>>>
>>>> On 03/04/2016 09:38 AM, Evan McClain wrote:
>>>>> On Thu, 2016-03-03 at 15:46 -0800, Dmitry Torokhov wrote:
>>>>>> From: Simon Que <sque@chromium.org>
>>>>>>
>>>>>> This is a driver for ACPI-based keyboard backlight LEDs found on
>>>>>> Chromebooks. The driver locates \\_SB.KBLT ACPI device and exports
>>>>>> backlight as "chromeos::kbd_backlight" LED class device in sysfs.
>>>>>
>>>>> Was it ever decided where this driver should live? I was planning on
>>>>> submitting to platform/chrome since most keyboard backlights seem to
>>>>> live over there but I don't think I got a response.
>>>>>
>>>>
>>>> It hasn't been decided yet. I can take it, but could you submit one more
>>>> version, without
>>>>
>>>> 'owner = THIS_MODULE' in struct platform_driver keyboard_led_driver ?
>>>>
>>>> It is redundant, because the core will do it.
>>>>
>>>> Also the line with devm_kzalloc has over 80 characters.
>>>
>>> Also:
>>>
>>> - preferably use sizeof(*cdev) instead of sizeof(struct ...)
>>> - do not check cdev->flags & LED_SUSPENDED in
>>> keyboard_led_set_brightness() as it is not going to be called when led
>>> device is suspended anyway
>>> - change the MODULE_LICENSE from "GPL v2" to "GPL" as to match the
>>
>> I can see "either version 2 of the License" in the license notice.
>
>>From module.h:
>
> * "GPL" [GNU Public License v2 or later]
> * "GPL v2" [GNU Public License v2]
>
> leds-chromeos-keyboard is GPL v2+ so module license should be "GPL".
That's surprising. Thanks for spotting this.
--
Best Regards,
Jacek Anaszewski
next prev parent reply other threads:[~2016-03-04 21:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-03 23:46 [PATCH] leds: Add Chrome OS keyboard backlight LEDs driver Dmitry Torokhov
2016-03-04 8:38 ` Evan McClain
2016-03-04 9:38 ` Jacek Anaszewski
2016-03-04 19:13 ` Dmitry Torokhov
2016-03-04 20:41 ` Evan McClain
2016-03-04 20:56 ` Dmitry Torokhov
2016-03-04 22:09 ` Olof Johansson
2016-03-04 20:55 ` Jacek Anaszewski
2016-03-04 20:59 ` Dmitry Torokhov
2016-03-04 21:48 ` Jacek Anaszewski [this message]
2016-03-04 9:38 ` Jacek Anaszewski
2016-03-04 19:19 ` Dmitry Torokhov
2016-03-04 19:22 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56DA02BA.4020603@gmail.com \
--to=jacek.anaszewski@gmail.com \
--cc=aeroevan@gmail.com \
--cc=cooloney@gmail.com \
--cc=dlaurie@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=groeck@chromium.org \
--cc=j.anaszewski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=olofj@chromium.org \
--cc=rpurdie@rpsys.net \
--cc=sque@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).