* [PATCH] kbuild/mkspec: clean boot loader configuration on rpm removal
@ 2016-03-02 14:28 Paolo Abeni
2016-03-02 14:38 ` Hannes Frederic Sowa
2016-03-04 21:59 ` Michal Marek
0 siblings, 2 replies; 6+ messages in thread
From: Paolo Abeni @ 2016-03-02 14:28 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-kbuild, Michal Marek, Hannes Frederic Sowa
This patch add a rpm preuninstall scriptlet to cleanup the
boot loader configuration on kernel package uninstall.
The initrd for the to-be-removed kernel is deleted, too.
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
---
scripts/package/mkspec | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/scripts/package/mkspec b/scripts/package/mkspec
index fe44d68..b6de63c 100755
--- a/scripts/package/mkspec
+++ b/scripts/package/mkspec
@@ -138,6 +138,11 @@ echo "/sbin/installkernel $KERNELRELEASE /boot/.vmlinuz-$KERNELRELEASE-rpm /boot
echo "rm -f /boot/.vmlinuz-$KERNELRELEASE-rpm /boot/.System.map-$KERNELRELEASE-rpm"
echo "fi"
echo ""
+echo "%preun"
+echo "if [ -x /sbin/new-kernel-pkg ]; then"
+echo "new-kernel-pkg --remove $KERNELRELEASE --rminitrd --initrdfile=/boot/initramfs-$KERNELRELEASE.img"
+echo "fi"
+echo ""
echo "%files"
echo '%defattr (-, root, root)'
echo "/lib/modules/$KERNELRELEASE"
--
1.8.3.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] kbuild/mkspec: clean boot loader configuration on rpm removal
2016-03-02 14:28 [PATCH] kbuild/mkspec: clean boot loader configuration on rpm removal Paolo Abeni
@ 2016-03-02 14:38 ` Hannes Frederic Sowa
2016-03-02 15:09 ` Josh Boyer
2016-03-04 21:59 ` Michal Marek
1 sibling, 1 reply; 6+ messages in thread
From: Hannes Frederic Sowa @ 2016-03-02 14:38 UTC (permalink / raw)
To: Paolo Abeni, linux-kernel; +Cc: linux-kbuild, Michal Marek
On 02.03.2016 15:28, Paolo Abeni wrote:
> This patch add a rpm preuninstall scriptlet to cleanup the
> boot loader configuration on kernel package uninstall.
> The initrd for the to-be-removed kernel is deleted, too.
>
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
> ---
> scripts/package/mkspec | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/scripts/package/mkspec b/scripts/package/mkspec
> index fe44d68..b6de63c 100755
> --- a/scripts/package/mkspec
> +++ b/scripts/package/mkspec
> @@ -138,6 +138,11 @@ echo "/sbin/installkernel $KERNELRELEASE /boot/.vmlinuz-$KERNELRELEASE-rpm /boot
> echo "rm -f /boot/.vmlinuz-$KERNELRELEASE-rpm /boot/.System.map-$KERNELRELEASE-rpm"
> echo "fi"
> echo ""
> +echo "%preun"
> +echo "if [ -x /sbin/new-kernel-pkg ]; then"
> +echo "new-kernel-pkg --remove $KERNELRELEASE --rminitrd --initrdfile=/boot/initramfs-$KERNELRELEASE.img"
> +echo "fi"
> +echo ""
> echo "%files"
> echo '%defattr (-, root, root)'
> echo "/lib/modules/$KERNELRELEASE"
>
Maybe we should also switch to new-kernel-pkg for the postinstall call?
How about switching to kernel-install?
Thanks,
Hannes
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] kbuild/mkspec: clean boot loader configuration on rpm removal
2016-03-02 14:38 ` Hannes Frederic Sowa
@ 2016-03-02 15:09 ` Josh Boyer
2016-03-03 9:09 ` Paolo Abeni
0 siblings, 1 reply; 6+ messages in thread
From: Josh Boyer @ 2016-03-02 15:09 UTC (permalink / raw)
To: Hannes Frederic Sowa
Cc: Paolo Abeni, Linux-Kernel@Vger. Kernel. Org,
linux-kbuild@vger.kernel.org, Michal Marek
On Wed, Mar 2, 2016 at 9:38 AM, Hannes Frederic Sowa
<hannes@stressinduktion.org> wrote:
> On 02.03.2016 15:28, Paolo Abeni wrote:
>>
>> This patch add a rpm preuninstall scriptlet to cleanup the
>> boot loader configuration on kernel package uninstall.
>> The initrd for the to-be-removed kernel is deleted, too.
>>
>> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
>> ---
>> scripts/package/mkspec | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/scripts/package/mkspec b/scripts/package/mkspec
>> index fe44d68..b6de63c 100755
>> --- a/scripts/package/mkspec
>> +++ b/scripts/package/mkspec
>> @@ -138,6 +138,11 @@ echo "/sbin/installkernel $KERNELRELEASE
>> /boot/.vmlinuz-$KERNELRELEASE-rpm /boot
>> echo "rm -f /boot/.vmlinuz-$KERNELRELEASE-rpm
>> /boot/.System.map-$KERNELRELEASE-rpm"
>> echo "fi"
>> echo ""
>> +echo "%preun"
>> +echo "if [ -x /sbin/new-kernel-pkg ]; then"
>> +echo "new-kernel-pkg --remove $KERNELRELEASE --rminitrd
>> --initrdfile=/boot/initramfs-$KERNELRELEASE.img"
>> +echo "fi"
>> +echo ""
>> echo "%files"
>> echo '%defattr (-, root, root)'
>> echo "/lib/modules/$KERNELRELEASE"
>>
>
> Maybe we should also switch to new-kernel-pkg for the postinstall call? How
> about switching to kernel-install?
new-kernel-pkg probably shouldn't be used here either. The
installkernel binary is the distro agnostic kernel installation tool
and the various distros provide that as either the tool they use or as
a wrapper. Switching to new-kernel-pkg implies this would only be
viable on grubby based distros, and using kernel-install would require
systemd.
josh
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] kbuild/mkspec: clean boot loader configuration on rpm removal
2016-03-02 15:09 ` Josh Boyer
@ 2016-03-03 9:09 ` Paolo Abeni
2016-03-04 21:55 ` Michal Marek
0 siblings, 1 reply; 6+ messages in thread
From: Paolo Abeni @ 2016-03-03 9:09 UTC (permalink / raw)
To: Josh Boyer
Cc: Hannes Frederic Sowa, Linux-Kernel@Vger. Kernel. Org,
linux-kbuild@vger.kernel.org, Michal Marek
On Wed, 2016-03-02 at 10:09 -0500, Josh Boyer wrote:
> On Wed, Mar 2, 2016 at 9:38 AM, Hannes Frederic Sowa
> <hannes@stressinduktion.org> wrote:
> > On 02.03.2016 15:28, Paolo Abeni wrote:
> >>
> >> This patch add a rpm preuninstall scriptlet to cleanup the
> >> boot loader configuration on kernel package uninstall.
> >> The initrd for the to-be-removed kernel is deleted, too.
> >>
> >> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
> >> ---
> >> scripts/package/mkspec | 5 +++++
> >> 1 file changed, 5 insertions(+)
> >>
> >> diff --git a/scripts/package/mkspec b/scripts/package/mkspec
> >> index fe44d68..b6de63c 100755
> >> --- a/scripts/package/mkspec
> >> +++ b/scripts/package/mkspec
> >> @@ -138,6 +138,11 @@ echo "/sbin/installkernel $KERNELRELEASE
> >> /boot/.vmlinuz-$KERNELRELEASE-rpm /boot
> >> echo "rm -f /boot/.vmlinuz-$KERNELRELEASE-rpm
> >> /boot/.System.map-$KERNELRELEASE-rpm"
> >> echo "fi"
> >> echo ""
> >> +echo "%preun"
> >> +echo "if [ -x /sbin/new-kernel-pkg ]; then"
> >> +echo "new-kernel-pkg --remove $KERNELRELEASE --rminitrd
> >> --initrdfile=/boot/initramfs-$KERNELRELEASE.img"
> >> +echo "fi"
> >> +echo ""
> >> echo "%files"
> >> echo '%defattr (-, root, root)'
> >> echo "/lib/modules/$KERNELRELEASE"
> >>
> >
> > Maybe we should also switch to new-kernel-pkg for the postinstall call? How
> > about switching to kernel-install?
>
> new-kernel-pkg probably shouldn't be used here either. The
> installkernel binary is the distro agnostic kernel installation tool
> and the various distros provide that as either the tool they use or as
> a wrapper. Switching to new-kernel-pkg implies this would only be
> viable on grubby based distros, and using kernel-install would require
> systemd.
I'm sorry, I try to dig a bit, but I did not find any distro agnostic
kernel removal tools. Can you please point out some ?
Elsewhere can we stuck with new-kernel-pkg, plus eventual fall-back to
other options, i.e. kernel-install?
Thank you,
Paolo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] kbuild/mkspec: clean boot loader configuration on rpm removal
2016-03-03 9:09 ` Paolo Abeni
@ 2016-03-04 21:55 ` Michal Marek
0 siblings, 0 replies; 6+ messages in thread
From: Michal Marek @ 2016-03-04 21:55 UTC (permalink / raw)
To: Paolo Abeni, Josh Boyer
Cc: Hannes Frederic Sowa, Linux-Kernel@Vger. Kernel. Org,
linux-kbuild@vger.kernel.org
Dne 3.3.2016 v 10:09 Paolo Abeni napsal(a):
> I'm sorry, I try to dig a bit, but I did not find any distro agnostic
> kernel removal tools. Can you please point out some ?
There isn't any, so unfortunately we need a list of various
distro-specific methods, starting with ew-kernel-pkg. The %post script
should stay as is, though.
Michal
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] kbuild/mkspec: clean boot loader configuration on rpm removal
2016-03-02 14:28 [PATCH] kbuild/mkspec: clean boot loader configuration on rpm removal Paolo Abeni
2016-03-02 14:38 ` Hannes Frederic Sowa
@ 2016-03-04 21:59 ` Michal Marek
1 sibling, 0 replies; 6+ messages in thread
From: Michal Marek @ 2016-03-04 21:59 UTC (permalink / raw)
To: Paolo Abeni, linux-kernel; +Cc: linux-kbuild, Hannes Frederic Sowa
Dne 2.3.2016 v 15:28 Paolo Abeni napsal(a):
> This patch add a rpm preuninstall scriptlet to cleanup the
> boot loader configuration on kernel package uninstall.
> The initrd for the to-be-removed kernel is deleted, too.
>
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Applied to kbuild.git#misc.
Michal
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-03-04 21:59 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-02 14:28 [PATCH] kbuild/mkspec: clean boot loader configuration on rpm removal Paolo Abeni
2016-03-02 14:38 ` Hannes Frederic Sowa
2016-03-02 15:09 ` Josh Boyer
2016-03-03 9:09 ` Paolo Abeni
2016-03-04 21:55 ` Michal Marek
2016-03-04 21:59 ` Michal Marek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).