From: Jens Axboe <axboe@fb.com>
To: Arnd Bergmann <arnd@arndb.de>, Markus Pargmann <mpa@pengutronix.de>
Cc: <nbd-general@lists.sourceforge.net>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] nbd: use correct div_s64 helper
Date: Fri, 4 Mar 2016 17:19:56 -0700 [thread overview]
Message-ID: <56DA262C.5050001@fb.com> (raw)
In-Reply-To: <1457135375-1787628-1-git-send-email-arnd@arndb.de>
On 03/04/2016 04:49 PM, Arnd Bergmann wrote:
> The do_div() macro now checks its arguments for the correct type,
> and refuses anything other than u64, so we get a warning about
> nbd_ioctl passing in an loff_t:
>
> drivers/block/nbd.c: In function '__nbd_ioctl':
> drivers/block/nbd.c:757:77: error: comparison of distinct pointer types lacks a cast [-Werror]
>
> This changes the nbd code to use div_s64() instead, which takes
> a signed argument.
Thanks Arnd, applied.
--
Jens Axboe
prev parent reply other threads:[~2016-03-05 0:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-04 23:49 [PATCH] nbd: use correct div_s64 helper Arnd Bergmann
2016-03-05 0:19 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56DA262C.5050001@fb.com \
--to=axboe@fb.com \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mpa@pengutronix.de \
--cc=nbd-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).