From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760676AbcCEAUT (ORCPT ); Fri, 4 Mar 2016 19:20:19 -0500 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:27745 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760351AbcCEAUP (ORCPT ); Fri, 4 Mar 2016 19:20:15 -0500 Subject: Re: [PATCH] nbd: use correct div_s64 helper To: Arnd Bergmann , Markus Pargmann References: <1457135375-1787628-1-git-send-email-arnd@arndb.de> CC: , From: Jens Axboe Message-ID: <56DA262C.5050001@fb.com> Date: Fri, 4 Mar 2016 17:19:56 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1457135375-1787628-1-git-send-email-arnd@arndb.de> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.54.13] X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-03-04_10:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/04/2016 04:49 PM, Arnd Bergmann wrote: > The do_div() macro now checks its arguments for the correct type, > and refuses anything other than u64, so we get a warning about > nbd_ioctl passing in an loff_t: > > drivers/block/nbd.c: In function '__nbd_ioctl': > drivers/block/nbd.c:757:77: error: comparison of distinct pointer types lacks a cast [-Werror] > > This changes the nbd code to use div_s64() instead, which takes > a signed argument. Thanks Arnd, applied. -- Jens Axboe