From: Taeung Song <treeze.taeung@gmail.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
Jiri Olsa <jolsa@redhat.com>,
perf group <linux-perf-users@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH v11 17/24] perf config: Collect configs to handle config variables
Date: Sat, 5 Mar 2016 11:55:20 +0900 [thread overview]
Message-ID: <56DA4A98.1000708@gmail.com> (raw)
In-Reply-To: <20160304135848.GA15486@danjae.kornet>
On 03/04/2016 10:58 PM, Namhyung Kim wrote:
> Hi Taeung,
>
> On Fri, Mar 04, 2016 at 09:45:44PM +0900, Taeung Song wrote:
>> Hi, Namhyung and all
>>
>> (I'm modifying this patch to be tidy)
>> I have a mere question about name of a variable for
>> current config list that contains section list which has key-value
>> pairs from ~/.perfconfig or $(sysconfdir)/perfconfig config file.
>>
>> (This variable is designed to be used by several functions
>> that handle config information(key-value pairs).)
>>
>> I used 'sections' for this variable (type is 'struct list_head'),
>> but IMHO, I think that renaming it is better e.g.
>>
>> 1) 'cfglist'
>> 2) 'configlist'
>> 3) 'config_list'
>> 4) 'cfgset'
>> 5) 'configset'
>> 6) 'config_set'
>> ... :-\
>>
>> It is trivial question,
>> but I wanna know a opinion of other people. :-)
>
> I'd go with 3 or 6. Or simply 'configs' or 'perf_configs' is fine for
> me.
>
Thank you for your opinion. :-)
Taeung
next prev parent reply other threads:[~2016-03-05 2:55 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-17 13:53 [PATCH v11 01/24] perf tools: Add 'perf-config' command Taeung Song
2015-11-17 13:53 ` [PATCH v11 02/24] perf tools: Add perf-config document Taeung Song
2015-11-17 23:13 ` Namhyung Kim
2015-11-19 19:24 ` Arnaldo Carvalho de Melo
2015-11-22 10:07 ` Taeung Song
2015-11-22 10:11 ` [PATCH v11 RESEND " Taeung Song
2015-11-23 14:17 ` Arnaldo Carvalho de Melo
2015-11-26 8:20 ` [tip:perf/core] perf config: Add initial man page tip-bot for Taeung Song
2015-11-17 13:53 ` [PATCH v11 03/24] perf config: Document variables for 'color' section in " Taeung Song
2015-11-17 23:47 ` Namhyung Kim
2015-12-01 3:59 ` Taeung Song
2015-11-17 13:53 ` [PATCH v11 04/24] perf config: Document variables for 'tui' and 'gtk' sections " Taeung Song
2015-11-18 0:01 ` Namhyung Kim
2015-11-17 13:53 ` [PATCH v11 05/24] perf config: Document 'buildid.dir' variable " Taeung Song
2015-11-18 0:03 ` Namhyung Kim
2015-11-17 13:53 ` [PATCH v11 06/24] perf config: Document variables for 'annotate' section " Taeung Song
2015-11-18 0:24 ` Namhyung Kim
2015-11-17 13:53 ` [PATCH v11 07/24] perf config: Document variables for 'help' " Taeung Song
2015-11-18 0:45 ` Namhyung Kim
2015-12-01 16:17 ` Taeung Song
2015-11-17 13:53 ` [PATCH v11 08/24] perf config: Document 'hist.percentage' variable " Taeung Song
2015-11-18 0:49 ` Namhyung Kim
2015-11-17 13:53 ` [PATCH v11 09/24] perf config: Document 'ui.show-headers' " Taeung Song
2015-11-18 0:59 ` Namhyung Kim
2015-11-17 13:53 ` [PATCH v11 10/24] perf config: Document variables for 'call-graph' section " Taeung Song
2015-11-18 2:51 ` Namhyung Kim
2015-11-30 1:42 ` Taeung Song
2015-11-30 5:03 ` Namhyung Kim
2015-11-17 13:53 ` [PATCH v11 11/24] perf config: Document variables for 'report' " Taeung Song
2015-11-18 3:01 ` Namhyung Kim
2015-11-17 13:53 ` [PATCH v11 12/24] perf config: Document 'top.chidren' variable " Taeung Song
2015-11-18 3:04 ` Namhyung Kim
2015-11-17 13:53 ` [PATCH v11 13/24] perf config: Document 'man.viewer' " Taeung Song
2015-11-18 4:58 ` Namhyung Kim
2015-11-17 13:53 ` [PATCH v11 14/24] perf config: Document 'pager.<subcommand>' variables " Taeung Song
2015-11-18 5:05 ` Namhyung Kim
2015-11-17 13:53 ` [PATCH v11 15/24] perf config: Document 'kmem.default' variable " Taeung Song
2015-11-18 5:08 ` Namhyung Kim
2015-11-17 13:53 ` [PATCH v11 16/24] perf config: Add '--system' and '--user' options to select which config file is used Taeung Song
2015-11-18 5:11 ` Namhyung Kim
2015-11-17 13:53 ` [PATCH v11 17/24] perf config: Collect configs to handle config variables Taeung Song
2015-11-18 5:15 ` Namhyung Kim
2016-03-04 12:45 ` Taeung Song
2016-03-04 13:58 ` Namhyung Kim
2016-03-05 2:55 ` Taeung Song [this message]
2015-11-17 13:53 ` [PATCH v11 18/24] perf config: Add 'list-all' option to perf-config Taeung Song
2015-11-17 13:53 ` [PATCH v11 19/24] perf config: Add a option 'skel' " Taeung Song
2015-11-17 13:53 ` [PATCH v11 20/24] perf config: Add --verbose option for showing config description Taeung Song
2015-11-17 13:53 ` [PATCH v11 21/24] perf config: Add 'get' functionality Taeung Song
2015-11-17 13:53 ` [PATCH v11 22/24] perf config: Add 'set' feature Taeung Song
2015-11-17 13:53 ` [PATCH v11 23/24] perf config: normalize a value depending on default type of it Taeung Song
2015-11-17 13:53 ` [PATCH v11 24/24] perf config: Add a option 'remove' to perf-config Taeung Song
2015-11-17 22:36 ` [PATCH v11 01/24] perf tools: Add 'perf-config' command Namhyung Kim
2015-11-26 8:20 ` [tip:perf/core] perf tools: Add 'perf config' command tip-bot for Taeung Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56DA4A98.1000708@gmail.com \
--to=treeze.taeung@gmail.com \
--cc=acme@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).