From: Wei Ni <wni@nvidia.com>
To: <thierry.reding@gmail.com>, <rui.zhang@intel.com>,
<mikko.perttunen@kapsi.fi>
Cc: Matt Longnecker <mlongnecker@nvidia.com>, <swarren@wwwdotorg.org>,
<linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] thermal: tegra_soctherm: fix sign bit of temperature
Date: Mon, 7 Mar 2016 16:26:06 +0800 [thread overview]
Message-ID: <56DD3B1E.4030805@nvidia.com> (raw)
In-Reply-To: <56D78081.6050106@nvidia.com>
Hi, Rui and Thierry
Could you please take a look at this patch?
Thanks.
Wei.
On 2016年03月03日 08:08, Matt Longnecker wrote:
>
>
> On 03/01/2016 11:40 PM, Wei Ni wrote:
>> >diff --git a/drivers/thermal/tegra_soctherm.c b/drivers/thermal/tegra_soctherm.c
>> >index 74ea5765938b..136975220c92 100644
>> >--- a/drivers/thermal/tegra_soctherm.c
>> >+++ b/drivers/thermal/tegra_soctherm.c
>> >@@ -57,7 +57,7 @@
>> > #define READBACK_VALUE_MASK 0xff00
>> > #define READBACK_VALUE_SHIFT 8
>> > #define READBACK_ADD_HALF BIT(7)
>> >-#define READBACK_NEGATE BIT(1)
>> >+#define READBACK_NEGATE BIT(0)
> I confirm that this change is technically correct. It fixes a bug.
next prev parent reply other threads:[~2016-03-07 8:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-29 9:51 [PATCH] thermal: tegra_soctherm: fix sign bit of temperature Wei Ni
2016-03-02 7:40 ` Wei Ni
2016-03-03 0:08 ` Matt Longnecker
2016-03-07 8:26 ` Wei Ni [this message]
2016-03-07 8:55 ` Zhang, Rui
2016-03-07 9:16 ` Wei Ni
2016-03-07 12:27 ` Zhang, Rui
2016-03-07 8:32 ` Thierry Reding
2016-03-07 8:38 ` Thierry Reding
2016-03-07 8:45 ` Wei Ni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56DD3B1E.4030805@nvidia.com \
--to=wni@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mikko.perttunen@kapsi.fi \
--cc=mlongnecker@nvidia.com \
--cc=rui.zhang@intel.com \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox