From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752354AbcCGJED (ORCPT <rfc822;w@1wt.eu>);
	Mon, 7 Mar 2016 04:04:03 -0500
Received: from comal.ext.ti.com ([198.47.26.152]:49258 "EHLO comal.ext.ti.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752108AbcCGJDv (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 7 Mar 2016 04:03:51 -0500
Subject: Re: [PATCH v5 09/26] mtd: nand: omap: Clean up device tree support
To: Brian Norris <computersforpeace@gmail.com>
References: <1455916548-3441-1-git-send-email-rogerq@ti.com>
 <1455916548-3441-10-git-send-email-rogerq@ti.com>
 <20160305022823.GO55664@google.com>
CC: <tony@atomide.com>, <dwmw2@infradead.org>, <ezequiel@vanguardiasur.com.ar>,
        <javier@dowhile0.org>, <fcooper@ti.com>, <nsekhar@ti.com>,
        <linux-mtd@lists.infradead.org>, <linux-omap@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
From: Roger Quadros <rogerq@ti.com>
Message-ID: <56DD43C2.2080406@ti.com>
Date: Mon, 7 Mar 2016 11:02:58 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <20160305022823.GO55664@google.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 05/03/16 04:28, Brian Norris wrote:
> Sorry, another small thing I noticed.
> 
> On Fri, Feb 19, 2016 at 11:15:31PM +0200, Roger Quadros wrote:
>> Move NAND specific device tree parsing to NAND driver.
>>
>> The NAND controller node must have a compatible id, register space
>> resource and interrupt resource.
>>
>> Signed-off-by: Roger Quadros <rogerq@ti.com>
>> ---
> [...]
> 
>> diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
>> index 9e99199..0a637c4 100644
>> --- a/drivers/mtd/nand/omap2.c
>> +++ b/drivers/mtd/nand/omap2.c
>> @@ -24,6 +24,7 @@
>>  #include <linux/slab.h>
>>  #include <linux/of.h>
>>  #include <linux/of_device.h>
>> +#include <linux/of_mtd.h>
>>  
>>  #include <linux/mtd/nand_bch.h>
>>  #include <linux/platform_data/elm.h>
>> @@ -177,10 +178,11 @@ struct omap_nand_info {
>>  	struct gpmc_nand_regs		reg;
>>  	struct gpmc_nand_ops		*ops;
>>  	/* generated at runtime depending on ECC algorithm and layout selected */
> 
> ^^^ I don't think that comment describes the following line. You
> probably meant to delete this one?

Yes. I'll remove that. Was my bad on cherry-pick conflict resolution.

> 
>> +	bool				flash_bbt;
>> +	/* generated at runtime depending on ECC algorithm and layout */
>>  	struct nand_ecclayout		oobinfo;
>>  	/* fields specific for BCHx_HW ECC scheme */
>>  	struct device			*elm_dev;
>> -	struct device_node		*of_node;
>>  };
>>  
>>  static inline struct omap_nand_info *mtd_to_omap(struct mtd_info *mtd)
> 
> [...]
> 

cheers,
-roger