From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752521AbcCGJQA (ORCPT ); Mon, 7 Mar 2016 04:16:00 -0500 Received: from hqemgate15.nvidia.com ([216.228.121.64]:6316 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752046AbcCGJPy convert rfc822-to-8bit (ORCPT ); Mon, 7 Mar 2016 04:15:54 -0500 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Mon, 07 Mar 2016 01:15:23 -0800 Message-ID: <56DD46D3.3060708@nvidia.com> Date: Mon, 7 Mar 2016 17:16:03 +0800 From: Wei Ni User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: "Zhang, Rui" , "thierry.reding@gmail.com" , "mikko.perttunen@kapsi.fi" , Eduardo Valentin CC: Matt Longnecker , "swarren@wwwdotorg.org" , "linux-tegra@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] thermal: tegra_soctherm: fix sign bit of temperature References: <1456739480-3304-1-git-send-email-wni@nvidia.com> <56D698FE.7070706@nvidia.com> <56D78081.6050106@nvidia.com> <56DD3B1E.4030805@nvidia.com> <744357E9AAD1214791ACBA4B0B9092633A9721DE@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <744357E9AAD1214791ACBA4B0B9092633A9721DE@SHSMSX101.ccr.corp.intel.com> X-Originating-IP: [10.19.224.146] X-ClientProxiedBy: DRBGMAIL104.nvidia.com (10.18.16.23) To HKMAIL101.nvidia.com (10.18.16.10) Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016年03月07日 16:55, Zhang, Rui wrote: > For the soc thermal driver changes, you'd better cc Eduardo at the same time so that he can include this in his soc-thermal pull request. > Surely I can queue this for 4.6 if Eduardo miss this. Thanks for your help. BTW, please add: Reviewed-by: Matt Longnecker Or I need to send v2 patch to add it? Thanks. Wei. > > Thanks, > rui > >> -----Original Message----- >> From: Wei Ni [mailto:wni@nvidia.com] >> Sent: Monday, March 07, 2016 4:26 PM >> To: thierry.reding@gmail.com; Zhang, Rui ; >> mikko.perttunen@kapsi.fi >> Cc: Matt Longnecker ; swarren@wwwdotorg.org; >> linux-tegra@vger.kernel.org; linux-kernel@vger.kernel.org >> Subject: Re: [PATCH] thermal: tegra_soctherm: fix sign bit of temperature >> Importance: High >> >> Hi, Rui and Thierry >> Could you please take a look at this patch? >> >> Thanks. >> Wei. >> >> On 2016年03月03日 08:08, Matt Longnecker wrote: >>> >>> >>> On 03/01/2016 11:40 PM, Wei Ni wrote: >>>>> diff --git a/drivers/thermal/tegra_soctherm.c >> b/drivers/thermal/tegra_soctherm.c >>>>> index 74ea5765938b..136975220c92 100644 >>>>> --- a/drivers/thermal/tegra_soctherm.c >>>>> +++ b/drivers/thermal/tegra_soctherm.c >>>>> @@ -57,7 +57,7 @@ >>>>> #define READBACK_VALUE_MASK 0xff00 >>>>> #define READBACK_VALUE_SHIFT 8 >>>>> #define READBACK_ADD_HALF BIT(7) >>>>> -#define READBACK_NEGATE BIT(1) >>>>> +#define READBACK_NEGATE BIT(0) >>> I confirm that this change is technically correct. It fixes a bug.