* [PATCH] thermal: tegra_soctherm: fix sign bit of temperature @ 2016-02-29 9:51 Wei Ni 2016-03-02 7:40 ` Wei Ni 2016-03-07 8:38 ` Thierry Reding 0 siblings, 2 replies; 10+ messages in thread From: Wei Ni @ 2016-02-29 9:51 UTC (permalink / raw) To: thierry.reding, rui.zhang, MLongnecker, mikko.perttunen Cc: swarren, linux-tegra, linux-kernel, Wei Ni The sign bit of temperature readback is bit 0, not bit 1. Change to BIT(0) to fix it. Signed-off-by: Wei Ni <wni@nvidia.com> --- drivers/thermal/tegra_soctherm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thermal/tegra_soctherm.c b/drivers/thermal/tegra_soctherm.c index 74ea5765938b..136975220c92 100644 --- a/drivers/thermal/tegra_soctherm.c +++ b/drivers/thermal/tegra_soctherm.c @@ -57,7 +57,7 @@ #define READBACK_VALUE_MASK 0xff00 #define READBACK_VALUE_SHIFT 8 #define READBACK_ADD_HALF BIT(7) -#define READBACK_NEGATE BIT(1) +#define READBACK_NEGATE BIT(0) #define FUSE_TSENSOR8_CALIB 0x180 #define FUSE_SPARE_REALIGNMENT_REG_0 0x1fc -- 1.9.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] thermal: tegra_soctherm: fix sign bit of temperature 2016-02-29 9:51 [PATCH] thermal: tegra_soctherm: fix sign bit of temperature Wei Ni @ 2016-03-02 7:40 ` Wei Ni 2016-03-03 0:08 ` Matt Longnecker 2016-03-07 8:38 ` Thierry Reding 1 sibling, 1 reply; 10+ messages in thread From: Wei Ni @ 2016-03-02 7:40 UTC (permalink / raw) To: thierry.reding, rui.zhang, MLongnecker, mikko.perttunen Cc: swarren, linux-tegra, linux-kernel Hi, Rui & Thierry & Matt Could you please take a look on this patch. It's a bug on the temperature's sign bit, it can't show the negative temperature, although it will not cause problems for now. Thanks. Wei. On 2016年02月29日 17:51, Wei Ni wrote: > The sign bit of temperature readback is bit 0, not bit 1. > Change to BIT(0) to fix it. > > Signed-off-by: Wei Ni <wni@nvidia.com> > --- > drivers/thermal/tegra_soctherm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/thermal/tegra_soctherm.c b/drivers/thermal/tegra_soctherm.c > index 74ea5765938b..136975220c92 100644 > --- a/drivers/thermal/tegra_soctherm.c > +++ b/drivers/thermal/tegra_soctherm.c > @@ -57,7 +57,7 @@ > #define READBACK_VALUE_MASK 0xff00 > #define READBACK_VALUE_SHIFT 8 > #define READBACK_ADD_HALF BIT(7) > -#define READBACK_NEGATE BIT(1) > +#define READBACK_NEGATE BIT(0) > > #define FUSE_TSENSOR8_CALIB 0x180 > #define FUSE_SPARE_REALIGNMENT_REG_0 0x1fc > ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] thermal: tegra_soctherm: fix sign bit of temperature 2016-03-02 7:40 ` Wei Ni @ 2016-03-03 0:08 ` Matt Longnecker 2016-03-07 8:26 ` Wei Ni 2016-03-07 8:32 ` Thierry Reding 0 siblings, 2 replies; 10+ messages in thread From: Matt Longnecker @ 2016-03-03 0:08 UTC (permalink / raw) To: Wei Ni, thierry.reding, rui.zhang, mikko.perttunen Cc: swarren, linux-tegra, linux-kernel On 03/01/2016 11:40 PM, Wei Ni wrote: > >diff --git a/drivers/thermal/tegra_soctherm.c b/drivers/thermal/tegra_soctherm.c > >index 74ea5765938b..136975220c92 100644 > >--- a/drivers/thermal/tegra_soctherm.c > >+++ b/drivers/thermal/tegra_soctherm.c > >@@ -57,7 +57,7 @@ > > #define READBACK_VALUE_MASK 0xff00 > > #define READBACK_VALUE_SHIFT 8 > > #define READBACK_ADD_HALF BIT(7) > >-#define READBACK_NEGATE BIT(1) > >+#define READBACK_NEGATE BIT(0) I confirm that this change is technically correct. It fixes a bug. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] thermal: tegra_soctherm: fix sign bit of temperature 2016-03-03 0:08 ` Matt Longnecker @ 2016-03-07 8:26 ` Wei Ni 2016-03-07 8:55 ` Zhang, Rui 2016-03-07 8:32 ` Thierry Reding 1 sibling, 1 reply; 10+ messages in thread From: Wei Ni @ 2016-03-07 8:26 UTC (permalink / raw) To: thierry.reding, rui.zhang, mikko.perttunen Cc: Matt Longnecker, swarren, linux-tegra, linux-kernel Hi, Rui and Thierry Could you please take a look at this patch? Thanks. Wei. On 2016年03月03日 08:08, Matt Longnecker wrote: > > > On 03/01/2016 11:40 PM, Wei Ni wrote: >> >diff --git a/drivers/thermal/tegra_soctherm.c b/drivers/thermal/tegra_soctherm.c >> >index 74ea5765938b..136975220c92 100644 >> >--- a/drivers/thermal/tegra_soctherm.c >> >+++ b/drivers/thermal/tegra_soctherm.c >> >@@ -57,7 +57,7 @@ >> > #define READBACK_VALUE_MASK 0xff00 >> > #define READBACK_VALUE_SHIFT 8 >> > #define READBACK_ADD_HALF BIT(7) >> >-#define READBACK_NEGATE BIT(1) >> >+#define READBACK_NEGATE BIT(0) > I confirm that this change is technically correct. It fixes a bug. ^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH] thermal: tegra_soctherm: fix sign bit of temperature 2016-03-07 8:26 ` Wei Ni @ 2016-03-07 8:55 ` Zhang, Rui 2016-03-07 9:16 ` Wei Ni 0 siblings, 1 reply; 10+ messages in thread From: Zhang, Rui @ 2016-03-07 8:55 UTC (permalink / raw) To: Wei Ni, thierry.reding@gmail.com, mikko.perttunen@kapsi.fi, Eduardo Valentin Cc: Matt Longnecker, swarren@wwwdotorg.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org For the soc thermal driver changes, you'd better cc Eduardo at the same time so that he can include this in his soc-thermal pull request. Surely I can queue this for 4.6 if Eduardo miss this. Thanks, rui > -----Original Message----- > From: Wei Ni [mailto:wni@nvidia.com] > Sent: Monday, March 07, 2016 4:26 PM > To: thierry.reding@gmail.com; Zhang, Rui <rui.zhang@intel.com>; > mikko.perttunen@kapsi.fi > Cc: Matt Longnecker <mlongnecker@nvidia.com>; swarren@wwwdotorg.org; > linux-tegra@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH] thermal: tegra_soctherm: fix sign bit of temperature > Importance: High > > Hi, Rui and Thierry > Could you please take a look at this patch? > > Thanks. > Wei. > > On 2016年03月03日 08:08, Matt Longnecker wrote: > > > > > > On 03/01/2016 11:40 PM, Wei Ni wrote: > >> >diff --git a/drivers/thermal/tegra_soctherm.c > b/drivers/thermal/tegra_soctherm.c > >> >index 74ea5765938b..136975220c92 100644 > >> >--- a/drivers/thermal/tegra_soctherm.c > >> >+++ b/drivers/thermal/tegra_soctherm.c > >> >@@ -57,7 +57,7 @@ > >> > #define READBACK_VALUE_MASK 0xff00 > >> > #define READBACK_VALUE_SHIFT 8 > >> > #define READBACK_ADD_HALF BIT(7) > >> >-#define READBACK_NEGATE BIT(1) > >> >+#define READBACK_NEGATE BIT(0) > > I confirm that this change is technically correct. It fixes a bug. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] thermal: tegra_soctherm: fix sign bit of temperature 2016-03-07 8:55 ` Zhang, Rui @ 2016-03-07 9:16 ` Wei Ni 2016-03-07 12:27 ` Zhang, Rui 0 siblings, 1 reply; 10+ messages in thread From: Wei Ni @ 2016-03-07 9:16 UTC (permalink / raw) To: Zhang, Rui, thierry.reding@gmail.com, mikko.perttunen@kapsi.fi, Eduardo Valentin Cc: Matt Longnecker, swarren@wwwdotorg.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org On 2016年03月07日 16:55, Zhang, Rui wrote: > For the soc thermal driver changes, you'd better cc Eduardo at the same time so that he can include this in his soc-thermal pull request. > Surely I can queue this for 4.6 if Eduardo miss this. Thanks for your help. BTW, please add: Reviewed-by: Matt Longnecker <mlongnecker@nvidia.com> Or I need to send v2 patch to add it? Thanks. Wei. > > Thanks, > rui > >> -----Original Message----- >> From: Wei Ni [mailto:wni@nvidia.com] >> Sent: Monday, March 07, 2016 4:26 PM >> To: thierry.reding@gmail.com; Zhang, Rui <rui.zhang@intel.com>; >> mikko.perttunen@kapsi.fi >> Cc: Matt Longnecker <mlongnecker@nvidia.com>; swarren@wwwdotorg.org; >> linux-tegra@vger.kernel.org; linux-kernel@vger.kernel.org >> Subject: Re: [PATCH] thermal: tegra_soctherm: fix sign bit of temperature >> Importance: High >> >> Hi, Rui and Thierry >> Could you please take a look at this patch? >> >> Thanks. >> Wei. >> >> On 2016年03月03日 08:08, Matt Longnecker wrote: >>> >>> >>> On 03/01/2016 11:40 PM, Wei Ni wrote: >>>>> diff --git a/drivers/thermal/tegra_soctherm.c >> b/drivers/thermal/tegra_soctherm.c >>>>> index 74ea5765938b..136975220c92 100644 >>>>> --- a/drivers/thermal/tegra_soctherm.c >>>>> +++ b/drivers/thermal/tegra_soctherm.c >>>>> @@ -57,7 +57,7 @@ >>>>> #define READBACK_VALUE_MASK 0xff00 >>>>> #define READBACK_VALUE_SHIFT 8 >>>>> #define READBACK_ADD_HALF BIT(7) >>>>> -#define READBACK_NEGATE BIT(1) >>>>> +#define READBACK_NEGATE BIT(0) >>> I confirm that this change is technically correct. It fixes a bug. ^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH] thermal: tegra_soctherm: fix sign bit of temperature 2016-03-07 9:16 ` Wei Ni @ 2016-03-07 12:27 ` Zhang, Rui 0 siblings, 0 replies; 10+ messages in thread From: Zhang, Rui @ 2016-03-07 12:27 UTC (permalink / raw) To: Wei Ni, thierry.reding@gmail.com, mikko.perttunen@kapsi.fi, Eduardo Valentin Cc: Matt Longnecker, swarren@wwwdotorg.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Oh, BTW, you need to CC linux-pm@vger.kernel.org as well, so that we can see your patch via patchwork. Please resend patch V2 to linux-pm@vger.kernel.org. Thanks, rui > -----Original Message----- > From: Wei Ni [mailto:wni@nvidia.com] > Sent: Monday, March 07, 2016 5:16 PM > To: Zhang, Rui <rui.zhang@intel.com>; thierry.reding@gmail.com; > mikko.perttunen@kapsi.fi; Eduardo Valentin <edubezval@gmail.com> > Cc: Matt Longnecker <mlongnecker@nvidia.com>; swarren@wwwdotorg.org; > linux-tegra@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH] thermal: tegra_soctherm: fix sign bit of temperature > Importance: High > > > > On 2016年03月07日 16:55, Zhang, Rui wrote: > > For the soc thermal driver changes, you'd better cc Eduardo at the same > time so that he can include this in his soc-thermal pull request. > > Surely I can queue this for 4.6 if Eduardo miss this. > > Thanks for your help. > > BTW, please add: > Reviewed-by: Matt Longnecker <mlongnecker@nvidia.com> > > Or I need to send v2 patch to add it? > > Thanks. > Wei. > > > > > Thanks, > > rui > > > >> -----Original Message----- > >> From: Wei Ni [mailto:wni@nvidia.com] > >> Sent: Monday, March 07, 2016 4:26 PM > >> To: thierry.reding@gmail.com; Zhang, Rui <rui.zhang@intel.com>; > >> mikko.perttunen@kapsi.fi > >> Cc: Matt Longnecker <mlongnecker@nvidia.com>; > swarren@wwwdotorg.org; > >> linux-tegra@vger.kernel.org; linux-kernel@vger.kernel.org > >> Subject: Re: [PATCH] thermal: tegra_soctherm: fix sign bit of > >> temperature > >> Importance: High > >> > >> Hi, Rui and Thierry > >> Could you please take a look at this patch? > >> > >> Thanks. > >> Wei. > >> > >> On 2016年03月03日 08:08, Matt Longnecker wrote: > >>> > >>> > >>> On 03/01/2016 11:40 PM, Wei Ni wrote: > >>>>> diff --git a/drivers/thermal/tegra_soctherm.c > >> b/drivers/thermal/tegra_soctherm.c > >>>>> index 74ea5765938b..136975220c92 100644 > >>>>> --- a/drivers/thermal/tegra_soctherm.c > >>>>> +++ b/drivers/thermal/tegra_soctherm.c > >>>>> @@ -57,7 +57,7 @@ > >>>>> #define READBACK_VALUE_MASK 0xff00 > >>>>> #define READBACK_VALUE_SHIFT 8 > >>>>> #define READBACK_ADD_HALF BIT(7) > >>>>> -#define READBACK_NEGATE BIT(1) > >>>>> +#define READBACK_NEGATE BIT(0) > >>> I confirm that this change is technically correct. It fixes a bug. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] thermal: tegra_soctherm: fix sign bit of temperature 2016-03-03 0:08 ` Matt Longnecker 2016-03-07 8:26 ` Wei Ni @ 2016-03-07 8:32 ` Thierry Reding 1 sibling, 0 replies; 10+ messages in thread From: Thierry Reding @ 2016-03-07 8:32 UTC (permalink / raw) To: Matt Longnecker Cc: Wei Ni, rui.zhang, mikko.perttunen, swarren, linux-tegra, linux-kernel [-- Attachment #1: Type: text/plain, Size: 697 bytes --] On Wed, Mar 02, 2016 at 04:08:33PM -0800, Matt Longnecker wrote: > > > On 03/01/2016 11:40 PM, Wei Ni wrote: > >>diff --git a/drivers/thermal/tegra_soctherm.c b/drivers/thermal/tegra_soctherm.c > >>index 74ea5765938b..136975220c92 100644 > >>--- a/drivers/thermal/tegra_soctherm.c > >>+++ b/drivers/thermal/tegra_soctherm.c > >>@@ -57,7 +57,7 @@ > >> #define READBACK_VALUE_MASK 0xff00 > >> #define READBACK_VALUE_SHIFT 8 > >> #define READBACK_ADD_HALF BIT(7) > >>-#define READBACK_NEGATE BIT(1) > >>+#define READBACK_NEGATE BIT(0) > I confirm that this change is technically correct. It fixes a bug. That usually translates to a Reviewed-by: tag. =) Thierry [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 819 bytes --] ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] thermal: tegra_soctherm: fix sign bit of temperature 2016-02-29 9:51 [PATCH] thermal: tegra_soctherm: fix sign bit of temperature Wei Ni 2016-03-02 7:40 ` Wei Ni @ 2016-03-07 8:38 ` Thierry Reding 2016-03-07 8:45 ` Wei Ni 1 sibling, 1 reply; 10+ messages in thread From: Thierry Reding @ 2016-03-07 8:38 UTC (permalink / raw) To: Wei Ni Cc: rui.zhang, MLongnecker, mikko.perttunen, swarren, linux-tegra, linux-kernel [-- Attachment #1: Type: text/plain, Size: 1119 bytes --] On Mon, Feb 29, 2016 at 05:51:20PM +0800, Wei Ni wrote: > The sign bit of temperature readback is bit 0, not bit 1. > Change to BIT(0) to fix it. > > Signed-off-by: Wei Ni <wni@nvidia.com> > --- > drivers/thermal/tegra_soctherm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/thermal/tegra_soctherm.c b/drivers/thermal/tegra_soctherm.c > index 74ea5765938b..136975220c92 100644 > --- a/drivers/thermal/tegra_soctherm.c > +++ b/drivers/thermal/tegra_soctherm.c > @@ -57,7 +57,7 @@ > #define READBACK_VALUE_MASK 0xff00 > #define READBACK_VALUE_SHIFT 8 > #define READBACK_ADD_HALF BIT(7) > -#define READBACK_NEGATE BIT(1) > +#define READBACK_NEGATE BIT(0) I haven't found this documented anywhere. The register documentation indicates that the SOC_THERM_TSENSOR_TEMP1 and SOC_THERM_TSENSOR_TEMP2 registers are in some kind of "temp readback format", but I can't find any specification of that format. Can you point me at the source for this information and file an internal bug report so that we can get the documentation updated? Thierry [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 819 bytes --] ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] thermal: tegra_soctherm: fix sign bit of temperature 2016-03-07 8:38 ` Thierry Reding @ 2016-03-07 8:45 ` Wei Ni 0 siblings, 0 replies; 10+ messages in thread From: Wei Ni @ 2016-03-07 8:45 UTC (permalink / raw) To: Thierry Reding Cc: rui.zhang, MLongnecker, mikko.perttunen, swarren, linux-tegra, linux-kernel On 2016年03月07日 16:38, Thierry Reding wrote: > * PGP Signed by an unknown key > > On Mon, Feb 29, 2016 at 05:51:20PM +0800, Wei Ni wrote: >> The sign bit of temperature readback is bit 0, not bit 1. >> Change to BIT(0) to fix it. >> >> Signed-off-by: Wei Ni <wni@nvidia.com> >> --- >> drivers/thermal/tegra_soctherm.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/thermal/tegra_soctherm.c b/drivers/thermal/tegra_soctherm.c >> index 74ea5765938b..136975220c92 100644 >> --- a/drivers/thermal/tegra_soctherm.c >> +++ b/drivers/thermal/tegra_soctherm.c >> @@ -57,7 +57,7 @@ >> #define READBACK_VALUE_MASK 0xff00 >> #define READBACK_VALUE_SHIFT 8 >> #define READBACK_ADD_HALF BIT(7) >> -#define READBACK_NEGATE BIT(1) >> +#define READBACK_NEGATE BIT(0) > > I haven't found this documented anywhere. The register documentation > indicates that the SOC_THERM_TSENSOR_TEMP1 and SOC_THERM_TSENSOR_TEMP2 > registers are in some kind of "temp readback format", but I can't find > any specification of that format. Can you point me at the source for > this information and file an internal bug report so that we can get > the documentation updated? Sure, I will do it. Thanks for your comment. > > Thierry > > * Unknown Key > * 0x7F3EB3A1 > ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2016-03-07 12:28 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-02-29 9:51 [PATCH] thermal: tegra_soctherm: fix sign bit of temperature Wei Ni 2016-03-02 7:40 ` Wei Ni 2016-03-03 0:08 ` Matt Longnecker 2016-03-07 8:26 ` Wei Ni 2016-03-07 8:55 ` Zhang, Rui 2016-03-07 9:16 ` Wei Ni 2016-03-07 12:27 ` Zhang, Rui 2016-03-07 8:32 ` Thierry Reding 2016-03-07 8:38 ` Thierry Reding 2016-03-07 8:45 ` Wei Ni
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox